You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2012/07/27 23:07:35 UTC
[jira] [Created] (HADOOP-8627) FS deleteOnExit may delete the wrong
path
Daryn Sharp created HADOOP-8627:
-----------------------------------
Summary: FS deleteOnExit may delete the wrong path
Key: HADOOP-8627
URL: https://issues.apache.org/jira/browse/HADOOP-8627
Project: Hadoop Common
Issue Type: Bug
Components: fs
Affects Versions: 2.0.0-alpha, 0.23.0, 3.0.0
Reporter: Daryn Sharp
Assignee: Daryn Sharp
Priority: Critical
{{FilterFileSystem}} is incorrectly delegating {{deleteOnExit}} to the raw underlying fs. This is wrong, because each fs instance is intended to maintain its own pool of temp files. Worse yet, this means registering a file via {{ChRootedFileSystem#deleteOnExit}} will delete the file w/o the chroot path prepended!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HADOOP-8627) FS deleteOnExit may delete the wrong
path
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy closed HADOOP-8627.
---------------------------------
> FS deleteOnExit may delete the wrong path
> -----------------------------------------
>
> Key: HADOOP-8627
> URL: https://issues.apache.org/jira/browse/HADOOP-8627
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Priority: Critical
> Fix For: 0.23.3, 2.0.2-alpha
>
> Attachments: HADOOP-8627-1.patch, HADOOP-8627.patch
>
>
> {{FilterFileSystem}} is incorrectly delegating {{deleteOnExit}} to the raw underlying fs. This is wrong, because each fs instance is intended to maintain its own pool of temp files. Worse yet, this means registering a file via {{ChRootedFileSystem#deleteOnExit}} will delete the file w/o the chroot path prepended!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8627) FS deleteOnExit may delete the
wrong path
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424174#comment-13424174 ]
Hadoop QA commented on HADOOP-8627:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12538214/HADOOP-8627.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.fs.TestFilterFileSystem
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1227//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1227//console
This message is automatically generated.
> FS deleteOnExit may delete the wrong path
> -----------------------------------------
>
> Key: HADOOP-8627
> URL: https://issues.apache.org/jira/browse/HADOOP-8627
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Priority: Critical
> Attachments: HADOOP-8627.patch
>
>
> {{FilterFileSystem}} is incorrectly delegating {{deleteOnExit}} to the raw underlying fs. This is wrong, because each fs instance is intended to maintain its own pool of temp files. Worse yet, this means registering a file via {{ChRootedFileSystem#deleteOnExit}} will delete the file w/o the chroot path prepended!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8627) FS deleteOnExit may delete the wrong
path
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-8627:
--------------------------------
Attachment: HADOOP-8627-1.patch
Add test I missed while teasing about patches.
> FS deleteOnExit may delete the wrong path
> -----------------------------------------
>
> Key: HADOOP-8627
> URL: https://issues.apache.org/jira/browse/HADOOP-8627
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Priority: Critical
> Attachments: HADOOP-8627-1.patch, HADOOP-8627.patch
>
>
> {{FilterFileSystem}} is incorrectly delegating {{deleteOnExit}} to the raw underlying fs. This is wrong, because each fs instance is intended to maintain its own pool of temp files. Worse yet, this means registering a file via {{ChRootedFileSystem#deleteOnExit}} will delete the file w/o the chroot path prepended!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8627) FS deleteOnExit may delete the
wrong path
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424892#comment-13424892 ]
Robert Joseph Evans commented on HADOOP-8627:
---------------------------------------------
The new patch looks good, and the tests pass +1. I'll check it in.
> FS deleteOnExit may delete the wrong path
> -----------------------------------------
>
> Key: HADOOP-8627
> URL: https://issues.apache.org/jira/browse/HADOOP-8627
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Priority: Critical
> Attachments: HADOOP-8627-1.patch, HADOOP-8627.patch
>
>
> {{FilterFileSystem}} is incorrectly delegating {{deleteOnExit}} to the raw underlying fs. This is wrong, because each fs instance is intended to maintain its own pool of temp files. Worse yet, this means registering a file via {{ChRootedFileSystem#deleteOnExit}} will delete the file w/o the chroot path prepended!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8627) FS deleteOnExit may delete the
wrong path
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424890#comment-13424890 ]
Daryn Sharp commented on HADOOP-8627:
-------------------------------------
Test failure is unrelated. Failover tests randomly timeout.
> FS deleteOnExit may delete the wrong path
> -----------------------------------------
>
> Key: HADOOP-8627
> URL: https://issues.apache.org/jira/browse/HADOOP-8627
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Priority: Critical
> Attachments: HADOOP-8627-1.patch, HADOOP-8627.patch
>
>
> {{FilterFileSystem}} is incorrectly delegating {{deleteOnExit}} to the raw underlying fs. This is wrong, because each fs instance is intended to maintain its own pool of temp files. Worse yet, this means registering a file via {{ChRootedFileSystem#deleteOnExit}} will delete the file w/o the chroot path prepended!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8627) FS deleteOnExit may delete the wrong
path
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-8627:
--------------------------------
Attachment: HADOOP-8627.patch
Remove the problematic method so {{delete}} is called by the close/shutdown hook which will correctly translate the path.
> FS deleteOnExit may delete the wrong path
> -----------------------------------------
>
> Key: HADOOP-8627
> URL: https://issues.apache.org/jira/browse/HADOOP-8627
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Priority: Critical
> Attachments: HADOOP-8627.patch
>
>
> {{FilterFileSystem}} is incorrectly delegating {{deleteOnExit}} to the raw underlying fs. This is wrong, because each fs instance is intended to maintain its own pool of temp files. Worse yet, this means registering a file via {{ChRootedFileSystem#deleteOnExit}} will delete the file w/o the chroot path prepended!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8627) FS deleteOnExit may delete the
wrong path
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425040#comment-13425040 ]
Hudson commented on HADOOP-8627:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2596 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2596/])
HADOOP-8627. FS deleteOnExit may delete the wrong path (daryn via bobby) (Revision 1367114)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367114
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFilterFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
> FS deleteOnExit may delete the wrong path
> -----------------------------------------
>
> Key: HADOOP-8627
> URL: https://issues.apache.org/jira/browse/HADOOP-8627
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Priority: Critical
> Fix For: 0.23.3, 3.0.0, 2.2.0-alpha
>
> Attachments: HADOOP-8627-1.patch, HADOOP-8627.patch
>
>
> {{FilterFileSystem}} is incorrectly delegating {{deleteOnExit}} to the raw underlying fs. This is wrong, because each fs instance is intended to maintain its own pool of temp files. Worse yet, this means registering a file via {{ChRootedFileSystem#deleteOnExit}} will delete the file w/o the chroot path prepended!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8627) FS deleteOnExit may delete the
wrong path
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424155#comment-13424155 ]
Robert Joseph Evans commented on HADOOP-8627:
---------------------------------------------
The patch looks good to me. I like it when we fix bugs by removing code :) +1 pending Jenkins.
> FS deleteOnExit may delete the wrong path
> -----------------------------------------
>
> Key: HADOOP-8627
> URL: https://issues.apache.org/jira/browse/HADOOP-8627
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Priority: Critical
> Attachments: HADOOP-8627.patch
>
>
> {{FilterFileSystem}} is incorrectly delegating {{deleteOnExit}} to the raw underlying fs. This is wrong, because each fs instance is intended to maintain its own pool of temp files. Worse yet, this means registering a file via {{ChRootedFileSystem#deleteOnExit}} will delete the file w/o the chroot path prepended!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8627) FS deleteOnExit may delete the
wrong path
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425721#comment-13425721 ]
Hudson commented on HADOOP-8627:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #330 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/330/])
svn merge -c 1367114 FIXES: HADOOP-8627. FS deleteOnExit may delete the wrong path (daryn via bobby) (Revision 1367119)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367119
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFilterFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
> FS deleteOnExit may delete the wrong path
> -----------------------------------------
>
> Key: HADOOP-8627
> URL: https://issues.apache.org/jira/browse/HADOOP-8627
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Priority: Critical
> Fix For: 0.23.3, 3.0.0, 2.2.0-alpha
>
> Attachments: HADOOP-8627-1.patch, HADOOP-8627.patch
>
>
> {{FilterFileSystem}} is incorrectly delegating {{deleteOnExit}} to the raw underlying fs. This is wrong, because each fs instance is intended to maintain its own pool of temp files. Worse yet, this means registering a file via {{ChRootedFileSystem#deleteOnExit}} will delete the file w/o the chroot path prepended!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8627) FS deleteOnExit may delete the
wrong path
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424885#comment-13424885 ]
Hadoop QA commented on HADOOP-8627:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12538345/HADOOP-8627-1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1228//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1228//console
This message is automatically generated.
> FS deleteOnExit may delete the wrong path
> -----------------------------------------
>
> Key: HADOOP-8627
> URL: https://issues.apache.org/jira/browse/HADOOP-8627
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Priority: Critical
> Attachments: HADOOP-8627-1.patch, HADOOP-8627.patch
>
>
> {{FilterFileSystem}} is incorrectly delegating {{deleteOnExit}} to the raw underlying fs. This is wrong, because each fs instance is intended to maintain its own pool of temp files. Worse yet, this means registering a file via {{ChRootedFileSystem#deleteOnExit}} will delete the file w/o the chroot path prepended!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8627) FS deleteOnExit may delete the wrong
path
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-8627:
--------------------------------
Status: Patch Available (was: Open)
> FS deleteOnExit may delete the wrong path
> -----------------------------------------
>
> Key: HADOOP-8627
> URL: https://issues.apache.org/jira/browse/HADOOP-8627
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.0-alpha, 0.23.0, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Priority: Critical
> Attachments: HADOOP-8627.patch
>
>
> {{FilterFileSystem}} is incorrectly delegating {{deleteOnExit}} to the raw underlying fs. This is wrong, because each fs instance is intended to maintain its own pool of temp files. Worse yet, this means registering a file via {{ChRootedFileSystem#deleteOnExit}} will delete the file w/o the chroot path prepended!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8627) FS deleteOnExit may delete the
wrong path
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425013#comment-13425013 ]
Hudson commented on HADOOP-8627:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2552 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2552/])
HADOOP-8627. FS deleteOnExit may delete the wrong path (daryn via bobby) (Revision 1367114)
Result = FAILURE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367114
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFilterFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
> FS deleteOnExit may delete the wrong path
> -----------------------------------------
>
> Key: HADOOP-8627
> URL: https://issues.apache.org/jira/browse/HADOOP-8627
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Priority: Critical
> Fix For: 0.23.3, 3.0.0, 2.2.0-alpha
>
> Attachments: HADOOP-8627-1.patch, HADOOP-8627.patch
>
>
> {{FilterFileSystem}} is incorrectly delegating {{deleteOnExit}} to the raw underlying fs. This is wrong, because each fs instance is intended to maintain its own pool of temp files. Worse yet, this means registering a file via {{ChRootedFileSystem#deleteOnExit}} will delete the file w/o the chroot path prepended!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8627) FS deleteOnExit may delete the
wrong path
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425037#comment-13425037 ]
Hudson commented on HADOOP-8627:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2532 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2532/])
HADOOP-8627. FS deleteOnExit may delete the wrong path (daryn via bobby) (Revision 1367114)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1367114
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFilterFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
> FS deleteOnExit may delete the wrong path
> -----------------------------------------
>
> Key: HADOOP-8627
> URL: https://issues.apache.org/jira/browse/HADOOP-8627
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Priority: Critical
> Fix For: 0.23.3, 3.0.0, 2.2.0-alpha
>
> Attachments: HADOOP-8627-1.patch, HADOOP-8627.patch
>
>
> {{FilterFileSystem}} is incorrectly delegating {{deleteOnExit}} to the raw underlying fs. This is wrong, because each fs instance is intended to maintain its own pool of temp files. Worse yet, this means registering a file via {{ChRootedFileSystem#deleteOnExit}} will delete the file w/o the chroot path prepended!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8627) FS deleteOnExit may delete the wrong
path
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated HADOOP-8627:
----------------------------------------
Resolution: Fixed
Fix Version/s: 2.2.0-alpha
3.0.0
0.23.3
Status: Resolved (was: Patch Available)
Thanks Daryn,
I put this into trunk, branch-2, and branch-0.23
> FS deleteOnExit may delete the wrong path
> -----------------------------------------
>
> Key: HADOOP-8627
> URL: https://issues.apache.org/jira/browse/HADOOP-8627
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Priority: Critical
> Fix For: 0.23.3, 3.0.0, 2.2.0-alpha
>
> Attachments: HADOOP-8627-1.patch, HADOOP-8627.patch
>
>
> {{FilterFileSystem}} is incorrectly delegating {{deleteOnExit}} to the raw underlying fs. This is wrong, because each fs instance is intended to maintain its own pool of temp files. Worse yet, this means registering a file via {{ChRootedFileSystem#deleteOnExit}} will delete the file w/o the chroot path prepended!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira