[GitHub] [doris] HappenLee commented on a diff in pull request #10447: [Load][Vectorized] load opt code by change `replace` and `replace_if_not_null` do not copy value

[GitBox <gi...@apache.org>]

HappenLee commented on code in PR #10447:
URL: https://github.com/apache/doris/pull/10447#discussion_r907020817


##########
be/src/vec/aggregate_functions/aggregate_function_window.h:
##########
@@ -210,26 +210,30 @@ class WindowFunctionNTile final
 struct Value {
 public:
     bool is_null() const { return _is_null; }
-    StringRef get_value() const { return _value; }
-
     void set_null(bool is_null) { _is_null = is_null; }
-    void set_value(StringRef value) { _value = value; }
+    StringRef get_value() const { return _ptr->get_data_at(_offset); }
+
+    void set_value(StringRef ref) {

Review Comment:
   just keep same with `copy_value` do make sure the interface is same



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org