[GitHub] [spark] cloud-fan commented on a change in pull request #27151: [SPARK-26218][SQL][Follow up] Fix the corner case when casting float to Integer.

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27151: [SPARK-26218][SQL][Follow up] Fix the corner case when casting float to Integer.
URL: https://github.com/apache/spark/pull/27151#discussion_r375068452
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/float4.sql
 ##########
 @@ -106,7 +106,6 @@ SELECT smallint(float('32767.6'));
 SELECT smallint(float('-32768.4'));
 SELECT smallint(float('-32768.6'));
 SELECT int(float('2147483520'));
-SELECT int(float('2147483647'));
 
 Review comment:
   These tests are copied from pgsql and we shouldn't change it. We just need to re-generate the answer file and keep the actual result as it is.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org