You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "der-eismann (via GitHub)" <gi...@apache.org> on 2024/04/22 09:51:59 UTC

[I] Add compression option for JSON Template Layout (logging-log4j2)

der-eismann opened a new issue, #2496:
URL: https://github.com/apache/logging-log4j2/issues/2496

   As it was explained in https://github.com/apache/logging-log4j2/discussions/2495#discussioncomment-9186368, all JSON-based layouts are deprecated in favor of JSON Template Layout. However the GELF layout has a `compressionType` option, which is missing from the JTL. 
   Would be really nice to have, as it can save a nice amount of traffic costs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Wrapper layout compressing the output of a delegate (LOG4J2-3023) (logging-log4j2)

Posted by "der-eismann (via GitHub)" <gi...@apache.org>.
der-eismann commented on issue #2496:
URL: https://github.com/apache/logging-log4j2/issues/2496#issuecomment-2069078162

   I'm kinda interested, but my Java knowledge is very basic and I'm not sure if my help is really useful here :see_no_evil: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Wrapper layout compressing the output of a delegate (LOG4J2-3023) (logging-log4j2)

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on issue #2496:
URL: https://github.com/apache/logging-log4j2/issues/2496#issuecomment-2069148758

   I marked [LOG4J2-3023](https://issues.apache.org/jira/browse/LOG4J2-3023) as duplicate of this issue, so we don't need to use JIRA any more.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Wrapper layout compressing the output of a delegate (LOG4J2-3023) (logging-log4j2)

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on issue #2496:
URL: https://github.com/apache/logging-log4j2/issues/2496#issuecomment-2069142947

   I think we should introduce an `OutputStream` abstraction:
   
   ```java
   public interface OutputStreamWrapper {
   
       OutputStream wrap(OutputStream stream);
   }
   ```
   
   Such an abstraction could solve several issues:
   
   * it would allow users to introduce their own compression/decompression algorithms (apache/logging-log4j2#1508),
   * it would allow us to remove the dependency on `commons-compress` from Log4j Core,
   * it would allow users to implement some sort of end-to-end encryption (cf. [LOG4J2-1000](https://issues.apache.org/jira/browse/LOG4J2-1000) and [LOG4J2-2930](https://issues.apache.org/jira/browse/LOG4J2-2930)).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add compression option for JSON Template Layout (logging-log4j2)

Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on issue #2496:
URL: https://github.com/apache/logging-log4j2/issues/2496#issuecomment-2068999593

   Instead adding compression support to `<your-layout-of-preference>`, we better create a wrapper layout that compresses the output of another layout. This issue has already been discussed in [LOG4J2-3023](https://issues.apache.org/jira/browse/LOG4J2-3023).
   
   @der-eismann, would you be interested in submitting a PR? If so, I would be more than happy to assist you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org