You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "mihailoale-db (via GitHub)" <gi...@apache.org> on 2025/05/13 10:29:13 UTC
[PR] Revert SPARK-52046 and SPARK-52019: Strip outer references and prettify correlated aggregate functions [spark]
mihailoale-db opened a new pull request, #50869:
URL: https://github.com/apache/spark/pull/50869
### What changes were proposed in this pull request?
In this PR we revert changes made in https://github.com/apache/spark/pull/50804 and https://github.com/apache/spark/pull/50836. This is necessary because we also change the alias name for outer references in LATERAL JOIN which is incorrect.
### Why are the changes needed?
To fix the behavior for LATERAL JOIN.
### Does this PR introduce _any_ user-facing change?
No (we revert to the previous working state).
### How was this patch tested?
Existing tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Revert SPARK-52046 and SPARK-52019: Strip outer references and prettify correlated aggregate functions [spark]
Posted by "mihailoale-db (via GitHub)" <gi...@apache.org>.
mihailoale-db commented on PR #50869:
URL: https://github.com/apache/spark/pull/50869#issuecomment-2876319714
@cloud-fan PTAL when you have time (passed all the tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Revert SPARK-52046 and SPARK-52019: Strip outer references and prettify correlated aggregate functions [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #50869: Revert SPARK-52046 and SPARK-52019: Strip outer references and prettify correlated aggregate functions
URL: https://github.com/apache/spark/pull/50869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Revert SPARK-52046 and SPARK-52019: Strip outer references and prettify correlated aggregate functions [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #50869:
URL: https://github.com/apache/spark/pull/50869#issuecomment-2876999233
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org