You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by vm...@apache.org on 2002/01/01 22:03:51 UTC
cvs commit: jakarta-struts/contrib/scaffold build.xml
vmassol 02/01/01 13:03:51
Modified: contrib/scaffold build.xml
Log:
added source zip to distribution file
Revision Changes Path
1.3 +23 -2 jakarta-struts/contrib/scaffold/build.xml
Index: build.xml
===================================================================
RCS file: /home/cvs/jakarta-struts/contrib/scaffold/build.xml,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- build.xml 28 Dec 2001 13:34:56 -0000 1.2
+++ build.xml 1 Jan 2002 21:03:50 -0000 1.3
@@ -57,7 +57,7 @@
@author <a href="mailto:ted@husted.com">Ted Husted</a>
@author <a href="mailto:vmassol@apache.org">Vincent Massol</a>
- @version $Id: build.xml,v 1.2 2001/12/28 13:34:56 vmassol Exp $
+ @version $Id: build.xml,v 1.3 2002/01/01 21:03:50 vmassol Exp $
=============================================================================
-->
<project name="Scaffold" default="dist" basedir=".">
@@ -135,6 +135,10 @@
<property name="target.sample.name" value="${project.name.file}-sample"/>
<property name="target.sample.dir" value="${target.dir}"/>
+ <!-- Name of the source zip that is included in the main scaffold zip -->
+ <property name="target.source.name" value="${project.name.file}-src"/>
+ <property name="target.source.dir" value="${target.dir}"/>
+
<!--
========================================================================
Names of deliverables
@@ -395,7 +399,21 @@
Generate distributables
========================================================================
-->
- <target name="dist" depends="jar,javadoc,sample">
+ <target name="dist" depends="jar,javadoc,sample"
+ description="Generates all distributables (binary, source, sample)">
+
+ <!-- Copy the source to the distribution area so that they are included
+ in the release -->
+ <mkdir dir="${target.source.dir}"/>
+
+ <zip zipfile="${target.source.dir}/${target.source.name}.zip">
+ <fileset dir=".">
+ <include name="conf/**"/>
+ <include name="src/**"/>
+ <include name="*"/>
+ <exclude name="build.properties"/>
+ </fileset>
+ </zip>
<mkdir dir="${dist.main.dir}"/>
@@ -410,6 +428,9 @@
<zipfileset dir="." prefix="doc">
<include name="LICENSE"/>
</zipfileset>
+ <fileset dir="${target.source.dir}">
+ <include name="${target.source.name}.zip"/>
+ </fileset>
</zip>
</target>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-struts/contrib/scaffold build.xml
Posted by Ted Husted <hu...@apache.org>.
Vincent Massol wrote:
> That looks very much like the sample target or scaffold; it builds a
> sample war containing unit tests, ... However, we could go also one more
> step further, as I've been doing with Cactus : include a full sample
> application with build process and directory structure. Thus is shows
> not only how to code an application using the library but also to
> integrate it in an automated build process. However, it is very suitable
> for Cactus as it is a tool that must be integrated with your build
> process (as I've done for Scaffold :-)) but probably less interesting
> for a library like scaffold which has no specific relationship to a
> build process ...
Five years ago, no one was doing unit tests they way they are encouraged
to be done today. So, people distributed code archives the way we
distribute Struts and Turbine today. The codebase was one thing, and all
the applications, including the tests, are another.
I'm suggesting that with unit tests now being an excepted part of the
development of anything, especially a library, it might be time for a
paradigm shift. Perhaps the library *should be* an application for
running its own unit tests and documentation.
In development, I should be running the tests as I go along, or even
writing the tests before drafting the code. So when I build the code,
should I not be building the tests that go with the library code, and
then running the tests as part of the development process? So is not the
test application an integral part of the library codebase?
My questions then is this: What is the benefit of distributing the code
archive and the unit test application seperately? Are we not saying they
are now all part of the same whole?
If the unit test application is part of the code archive, then why not
distribute the code archive as the test application with the source code
included?
Right now, I have my CVS archive in one place, and my development
webapps in another. Why can't I have it all it all in one place?
If there is a good reason, then so be it. But I'm still not clear why
distributing Scaffold like this:
http://husted.com/struts/resources/scaffold.zip
with the package unit tests replacing the "blank application" is a bad
idea.
I'm not going to veto the change, since I trust your judgment, but I am
still curious why we can't do an all-in-one distribution.
-- Ted Husted, Husted dot Com, Fairport NY USA.
-- Building Java web applications with Struts.
-- Tel +1 585 737-3463.
-- Web http://www.husted.com/struts/
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: cvs commit: jakarta-struts/contrib/scaffold build.xml
Posted by Vincent Massol <vm...@octo.com>.
> -----Original Message-----
> From: Ted Husted [mailto:husted@apache.org]
> Sent: 02 January 2002 14:12
> To: Struts Developers List
> Subject: Re: cvs commit: jakarta-struts/contrib/scaffold build.xml
>
> Vincent Massol wrote:
> > What do you mean by source ? Only the java files or the full tree,
> > including build, conf, etc ?
>
> Everything, just as it stands.
>
> > Well, it shows how to package a scaffold application and how to unit
> > test one which is not that bad after all ... :-)
>
> Sorry, didn't notice the unit tests.
There aren't much now (it was more to show to implement them) but it is
the idea ...
> It just looked like the blank
> application with the scaffold.jar thrown int.
>
> > Hey, I'm not saying I'm right here ... ;-). I'm trying to
understand
> > the motivation behind packaging scaffold as a war ...
> >
> > I find it troubling to deliver a library as a WAR when what we want
to
> > deliver is actually a jar. However, it is also very important to
always
> > deliver a sample application for any library, which shows how to use
it
> > and a war fits nicely for this.
>
> I guess I'm thinking that the Scaffold "application" could be the
> documentation and unit tests, which would also serve as a sample
> application. To use Scaffold in their own application, they can just
> pull out the JAR, or download the JAR directly from distribution
folder.
> (As is being discussed on General.)
>
> We might also consider an alternative target in the build that created
a
> blank application, but with the unit tests (since every application
> should have unit tests!), that they could build, and then rename for
> their own application. Rather like the struts-blank, except that you
> just build and new one and rename it, rather than copy and rename.
> Perhaps there could be some settings in the build.xml that also
> customized some of the files for the new blank application?
>
That looks very much like the sample target or scaffold; it builds a
sample war containing unit tests, ... However, we could go also one more
step further, as I've been doing with Cactus : include a full sample
application with build process and directory structure. Thus is shows
not only how to code an application using the library but also to
integrate it in an automated build process. However, it is very suitable
for Cactus as it is a tool that must be integrated with your build
process (as I've done for Scaffold :-)) but probably less interesting
for a library like scaffold which has no specific relationship to a
build process ...
-Vincent
>
> -- Ted Husted, Husted dot Com, Fairport NY USA.
> -- Building Java web applications with Struts.
> -- Tel +1 585 737-3463.
> -- Web http://www.husted.com/struts/
>
> --
> To unsubscribe, e-mail: <mailto:struts-dev-
> unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:struts-dev-
> help@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-struts/contrib/scaffold build.xml
Posted by Ted Husted <hu...@apache.org>.
Vincent Massol wrote:
> What do you mean by source ? Only the java files or the full tree,
> including build, conf, etc ?
Everything, just as it stands.
> Well, it shows how to package a scaffold application and how to unit
> test one which is not that bad after all ... :-)
Sorry, didn't notice the unit tests. It just looked like the blank
application with the scaffold.jar thrown int.
> Hey, I'm not saying I'm right here ... ;-). I'm trying to understand
> the motivation behind packaging scaffold as a war ...
>
> I find it troubling to deliver a library as a WAR when what we want to
> deliver is actually a jar. However, it is also very important to always
> deliver a sample application for any library, which shows how to use it
> and a war fits nicely for this.
I guess I'm thinking that the Scaffold "application" could be the
documentation and unit tests, which would also serve as a sample
application. To use Scaffold in their own application, they can just
pull out the JAR, or download the JAR directly from distribution folder.
(As is being discussed on General.)
We might also consider an alternative target in the build that created a
blank application, but with the unit tests (since every application
should have unit tests!), that they could build, and then rename for
their own application. Rather like the struts-blank, except that you
just build and new one and rename it, rather than copy and rename.
Perhaps there could be some settings in the build.xml that also
customized some of the files for the new blank application?
-- Ted Husted, Husted dot Com, Fairport NY USA.
-- Building Java web applications with Struts.
-- Tel +1 585 737-3463.
-- Web http://www.husted.com/struts/
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: cvs commit: jakarta-struts/contrib/scaffold build.xml
Posted by Vincent Massol <vm...@octo.com>.
> -----Original Message-----
> From: Ted Husted [mailto:husted@apache.org]
> Sent: 01 January 2002 22:19
> To: Struts Developers List
> Subject: Re: cvs commit: jakarta-struts/contrib/scaffold build.xml
>
> Having two distributions for Artimus just doesn't seem useful. It
seems
> sufficient to just have the WAR, and include the source in that.
>
> > jakarta-artimus.war (with source intact under WEB-INF/src)
What do you mean by source ? Only the java files or the full tree,
including build, conf, etc ?
>
> I've always thought we should do the same thing with the Struts
samples,
> so those WARs could be downloaded and then examined in place.
>
> The best thing might be for Scaffolding to be distributed like Struts
or
> Velocity, or any other programming package. The current sample WAR
isn't
> useful, and could be discarded.
Well, it shows how to package a scaffold application and how to unit
test one which is not that bad after all ... :-)
> But we would still need a slot for the
> unit tests. So, I guess that implies a binary ZIP with the docs and
any
> sample WARs, a -src ZIP, and the JAR.
>
> Though, I still very much like the idea of just bundling it as WAR
with
> the source intact, with unit tests as the "application". Other
> applications based on the package could go into their own
distributions,
> like Artimus.
>
> But, Vincent believes the new layout will be more useful, and I trust
> his judgment.
Hey, I'm not saying I'm right here ... ;-). I'm trying to understand
the motivation behind packaging scaffold as a war ...
I find it troubling to deliver a library as a WAR when what we want to
deliver is actually a jar. However, it is also very important to always
deliver a sample application for any library, which shows how to use it
and a war fits nicely for this.
-Vincent
>
> -- Ted Husted, Husted dot Com, Fairport NY USA.
> -- Building Java web applications with Struts.
> -- Tel +1 585 737-3463.
> -- Web http://www.husted.com/struts/
>
> --
> To unsubscribe, e-mail: <mailto:struts-dev-
> unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:struts-dev-
> help@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-struts/contrib/scaffold build.xml
Posted by Ted Husted <hu...@apache.org>.
Having two distributions for Artimus just doesn't seem useful. It seems
sufficient to just have the WAR, and include the source in that.
> jakarta-artimus.war (with source intact under WEB-INF/src)
I've always thought we should do the same thing with the Struts samples,
so those WARs could be downloaded and then examined in place.
The best thing might be for Scaffolding to be distributed like Struts or
Velocity, or any other programming package. The current sample WAR isn't
useful, and could be discarded. But we would still need a slot for the
unit tests. So, I guess that implies a binary ZIP with the docs and any
sample WARs, a -src ZIP, and the JAR.
Though, I still very much like the idea of just bundling it as WAR with
the source intact, with unit tests as the "application". Other
applications based on the package could go into their own distributions,
like Artimus.
But, Vincent believes the new layout will be more useful, and I trust
his judgment.
-- Ted Husted, Husted dot Com, Fairport NY USA.
-- Building Java web applications with Struts.
-- Tel +1 585 737-3463.
-- Web http://www.husted.com/struts/
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: cvs commit: jakarta-struts/contrib/scaffold build.xml
Posted by Vincent Massol <vm...@octo.com>.
> -----Original Message-----
> From: Martin Cooper [mailto:martin.cooper@tumbleweed.com]
> Sent: 01 January 2002 21:53
> To: Struts Developers List
> Subject: Re: cvs commit: jakarta-struts/contrib/scaffold build.xml
>
> I think what might make the most sense is:
>
> jakarta-scaffold.jar
> jakarta-scaffold-src.zip
> jakarta-artimus.war
> jakarta-artimus-src.zip
>
> Note that the binary distribution of Scaffold is just the jar file,
and
> the
> binary distribution of Artimus is just the war file.
>
Fine, but where is the sample WAR application for Scaffold ?
-Vincent
> --
> Martin Cooper
>
>
> ----- Original Message -----
> From: "Vincent Massol" <vm...@octo.com>
> To: "'Struts Developers List'" <st...@jakarta.apache.org>
> Sent: Tuesday, January 01, 2002 1:37 PM
> Subject: RE: cvs commit: jakarta-struts/contrib/scaffold build.xml
>
>
> >
> >
> > > -----Original Message-----
> > > From: Ted Husted [mailto:husted@apache.org]
> > > Sent: 01 January 2002 21:26
> > > To: Struts Developers List
> > > Subject: Re: cvs commit: jakarta-struts/contrib/scaffold build.xml
> > >
> > > I just ran it, and it doesn't include the CVS directories.
> > >
> > > It does nest the scaffold-src.zip inside jakarta-scaffold.zip
though,
> > > which is probably going to confuse people.
> > >
> > > Vincent, how about if we go with a jakarta-scaffold.jar and
> > > jakarta-scaffold-src.zip in the dist folder.
> > >
> >
> > Where do you put the sample WAR ? In jakarta-scaffold-src.zip ? I
did
> > not want to separate the src from the distribution as I thought it
was
> > not needed and could be handy for users of scaffold, especially in
the
> > current state of scaffold which has very little documentation.
> >
> > In other words, here is what I am advocating :
> >
> > jakarta-scaffold.zip (the main and only distributable file)
> > |_ lib
> > |_ scaffold.jar
> > |_ doc
> > |_ api
> > |_ (javadoc files)
> > |_ scaffold-sample.war
> > |_ scaffold-src.zip
> >
> > If I understand correctly, you would prefer to have just the jar
> > standalone for persons who don't need sample nor documentation nor
> > source and a zip containing the rest, as in :
> >
> > jakarta-scaffold.jar
> > jakarta-scaffold-src.zip
> > |_ scaffold-src.zip
> > |_ scaffold-sample.war
> >
> > I'm not sure what you intend to have in Jakarta-scaffold-src.zip ?
The
> > expanded directories ? Then, where do you put the sample WAR ? In a
dist
> > subdirectory ? Somewhere else ?
> >
> > -Vincent
> >
> > > For Artimus, which is an application rather than a development
> > package,
> > > can we keep the src folders where they are, and just ZIP up the
WAR.
> > > There's probably not much use for a binary distribution of
Artimus.
> > >
> > > -Ted.
> > >
> > > Martin Cooper wrote:
> > > >
> > > > I haven't actually tried this, but it looks like the source zip
> > would
> > > also
> > > > include all the 'CVS' directories in the tree, along with their
> > > contents. If
> > > > that's the case, you might want to add an 'exclude' in the
fileset,
> > > since we
> > > > wouldn't want those files in the distribution.
> > > >
> > > > --
> > > > Martin Cooper
> > > >
> > > > ----- Original Message -----
> > > > From: <vm...@apache.org>
> > > > To: <ja...@apache.org>
> > > > Sent: Tuesday, January 01, 2002 1:03 PM
> > > > Subject: cvs commit: jakarta-struts/contrib/scaffold build.xml
> > > >
> > > > > vmassol 02/01/01 13:03:51
> > > > >
> > > > > Modified: contrib/scaffold build.xml
> > > > > Log:
> > > > > added source zip to distribution file
> > > > >
> > > > > Revision Changes Path
> > > > > 1.3 +23 -2
jakarta-struts/contrib/scaffold/build.xml
> > > > >
> > > > > Index: build.xml
> > > > >
> > ===================================================================
> > > > > RCS file:
/home/cvs/jakarta-struts/contrib/scaffold/build.xml,v
> > > > > retrieving revision 1.2
> > > > > retrieving revision 1.3
> > > > > diff -u -r1.2 -r1.3
> > > > > --- build.xml 28 Dec 2001 13:34:56 -0000 1.2
> > > > > +++ build.xml 1 Jan 2002 21:03:50 -0000 1.3
> > > > > @@ -57,7 +57,7 @@
> > > > >
> > > > > @author <a href="mailto:ted@husted.com">Ted Husted</a>
> > > > > @author <a href="mailto:vmassol@apache.org">Vincent
> > Massol</a>
> > > > > - @version $Id: build.xml,v 1.2 2001/12/28 13:34:56
vmassol
> > Exp $
> > > > > + @version $Id: build.xml,v 1.3 2002/01/01 21:03:50
vmassol
> > Exp $
> > > > >
> > > >
> > >
> >
========================================================================
> > ==
> > > ==
> > > > =
> > > > > -->
> > > > > <project name="Scaffold" default="dist" basedir=".">
> > > > > @@ -135,6 +135,10 @@
> > > > > <property name="target.sample.name"
> > > > value="${project.name.file}-sample"/>
> > > > > <property name="target.sample.dir"
value="${target.dir}"/>
> > > > >
> > > > > + <!-- Name of the source zip that is included in the
main
> > > scaffold
> > > > zip -->
> > > > > + <property name="target.source.name"
> > > > value="${project.name.file}-src"/>
> > > > > + <property name="target.source.dir"
value="${target.dir}"/>
> > > > > +
> > > > > <!--
> > > > >
> > > >
> >
========================================================================
> > > > > Names of deliverables
> > > > > @@ -395,7 +399,21 @@
> > > > > Generate distributables
> > > > >
> > > >
> >
========================================================================
> > > > > -->
> > > > > - <target name="dist" depends="jar,javadoc,sample">
> > > > > + <target name="dist" depends="jar,javadoc,sample"
> > > > > + description="Generates all distributables (binary,
source,
> > > > sample)">
> > > > > +
> > > > > + <!-- Copy the source to the distribution area so
that
> > they
> > > are
> > > > included
> > > > > + in the release -->
> > > > > + <mkdir dir="${target.source.dir}"/>
> > > > > +
> > > > > + <zip
> > > zipfile="${target.source.dir}/${target.source.name}.zip">
> > > > > + <fileset dir=".">
> > > > > + <include name="conf/**"/>
> > > > > + <include name="src/**"/>
> > > > > + <include name="*"/>
> > > > > + <exclude name="build.properties"/>
> > > > > + </fileset>
> > > > > + </zip>
> > > > >
> > > > > <mkdir dir="${dist.main.dir}"/>
> > > > >
> > > > > @@ -410,6 +428,9 @@
> > > > > <zipfileset dir="." prefix="doc">
> > > > > <include name="LICENSE"/>
> > > > > </zipfileset>
> > > > > + <fileset dir="${target.source.dir}">
> > > > > + <include name="${target.source.name}.zip"/>
> > > > > + </fileset>
> > > > > </zip>
> > > > >
> > > > > </target>
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > To unsubscribe, e-mail:
> > > > <ma...@jakarta.apache.org>
> > > > > For additional commands, e-mail:
> > > > <ma...@jakarta.apache.org>
> > > > >
> > > >
> > > > --
> > > > To unsubscribe, e-mail: <mailto:struts-dev-
> > > unsubscribe@jakarta.apache.org>
> > > > For additional commands, e-mail: <mailto:struts-dev-
> > > help@jakarta.apache.org>
> > >
> > > -- Ted Husted, Husted dot Com, Fairport NY USA.
> > > -- Building Java web applications with Struts.
> > > -- Tel +1 585 737-3463.
> > > -- Web http://www.husted.com/struts/
> > >
> > > --
> > > To unsubscribe, e-mail: <mailto:struts-dev-
> > > unsubscribe@jakarta.apache.org>
> > > For additional commands, e-mail: <mailto:struts-dev-
> > > help@jakarta.apache.org>
> > >
> >
> >
> >
> >
> > --
> > To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> > For additional commands, e-mail:
> <ma...@jakarta.apache.org>
> >
>
>
> --
> To unsubscribe, e-mail: <mailto:struts-dev-
> unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:struts-dev-
> help@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-struts/contrib/scaffold build.xml
Posted by Martin Cooper <ma...@tumbleweed.com>.
I think what might make the most sense is:
jakarta-scaffold.jar
jakarta-scaffold-src.zip
jakarta-artimus.war
jakarta-artimus-src.zip
Note that the binary distribution of Scaffold is just the jar file, and the
binary distribution of Artimus is just the war file.
--
Martin Cooper
----- Original Message -----
From: "Vincent Massol" <vm...@octo.com>
To: "'Struts Developers List'" <st...@jakarta.apache.org>
Sent: Tuesday, January 01, 2002 1:37 PM
Subject: RE: cvs commit: jakarta-struts/contrib/scaffold build.xml
>
>
> > -----Original Message-----
> > From: Ted Husted [mailto:husted@apache.org]
> > Sent: 01 January 2002 21:26
> > To: Struts Developers List
> > Subject: Re: cvs commit: jakarta-struts/contrib/scaffold build.xml
> >
> > I just ran it, and it doesn't include the CVS directories.
> >
> > It does nest the scaffold-src.zip inside jakarta-scaffold.zip though,
> > which is probably going to confuse people.
> >
> > Vincent, how about if we go with a jakarta-scaffold.jar and
> > jakarta-scaffold-src.zip in the dist folder.
> >
>
> Where do you put the sample WAR ? In jakarta-scaffold-src.zip ? I did
> not want to separate the src from the distribution as I thought it was
> not needed and could be handy for users of scaffold, especially in the
> current state of scaffold which has very little documentation.
>
> In other words, here is what I am advocating :
>
> jakarta-scaffold.zip (the main and only distributable file)
> |_ lib
> |_ scaffold.jar
> |_ doc
> |_ api
> |_ (javadoc files)
> |_ scaffold-sample.war
> |_ scaffold-src.zip
>
> If I understand correctly, you would prefer to have just the jar
> standalone for persons who don't need sample nor documentation nor
> source and a zip containing the rest, as in :
>
> jakarta-scaffold.jar
> jakarta-scaffold-src.zip
> |_ scaffold-src.zip
> |_ scaffold-sample.war
>
> I'm not sure what you intend to have in Jakarta-scaffold-src.zip ? The
> expanded directories ? Then, where do you put the sample WAR ? In a dist
> subdirectory ? Somewhere else ?
>
> -Vincent
>
> > For Artimus, which is an application rather than a development
> package,
> > can we keep the src folders where they are, and just ZIP up the WAR.
> > There's probably not much use for a binary distribution of Artimus.
> >
> > -Ted.
> >
> > Martin Cooper wrote:
> > >
> > > I haven't actually tried this, but it looks like the source zip
> would
> > also
> > > include all the 'CVS' directories in the tree, along with their
> > contents. If
> > > that's the case, you might want to add an 'exclude' in the fileset,
> > since we
> > > wouldn't want those files in the distribution.
> > >
> > > --
> > > Martin Cooper
> > >
> > > ----- Original Message -----
> > > From: <vm...@apache.org>
> > > To: <ja...@apache.org>
> > > Sent: Tuesday, January 01, 2002 1:03 PM
> > > Subject: cvs commit: jakarta-struts/contrib/scaffold build.xml
> > >
> > > > vmassol 02/01/01 13:03:51
> > > >
> > > > Modified: contrib/scaffold build.xml
> > > > Log:
> > > > added source zip to distribution file
> > > >
> > > > Revision Changes Path
> > > > 1.3 +23 -2 jakarta-struts/contrib/scaffold/build.xml
> > > >
> > > > Index: build.xml
> > > >
> ===================================================================
> > > > RCS file: /home/cvs/jakarta-struts/contrib/scaffold/build.xml,v
> > > > retrieving revision 1.2
> > > > retrieving revision 1.3
> > > > diff -u -r1.2 -r1.3
> > > > --- build.xml 28 Dec 2001 13:34:56 -0000 1.2
> > > > +++ build.xml 1 Jan 2002 21:03:50 -0000 1.3
> > > > @@ -57,7 +57,7 @@
> > > >
> > > > @author <a href="mailto:ted@husted.com">Ted Husted</a>
> > > > @author <a href="mailto:vmassol@apache.org">Vincent
> Massol</a>
> > > > - @version $Id: build.xml,v 1.2 2001/12/28 13:34:56 vmassol
> Exp $
> > > > + @version $Id: build.xml,v 1.3 2002/01/01 21:03:50 vmassol
> Exp $
> > > >
> > >
> >
> ========================================================================
> ==
> > ==
> > > =
> > > > -->
> > > > <project name="Scaffold" default="dist" basedir=".">
> > > > @@ -135,6 +135,10 @@
> > > > <property name="target.sample.name"
> > > value="${project.name.file}-sample"/>
> > > > <property name="target.sample.dir" value="${target.dir}"/>
> > > >
> > > > + <!-- Name of the source zip that is included in the main
> > scaffold
> > > zip -->
> > > > + <property name="target.source.name"
> > > value="${project.name.file}-src"/>
> > > > + <property name="target.source.dir" value="${target.dir}"/>
> > > > +
> > > > <!--
> > > >
> > >
> ========================================================================
> > > > Names of deliverables
> > > > @@ -395,7 +399,21 @@
> > > > Generate distributables
> > > >
> > >
> ========================================================================
> > > > -->
> > > > - <target name="dist" depends="jar,javadoc,sample">
> > > > + <target name="dist" depends="jar,javadoc,sample"
> > > > + description="Generates all distributables (binary, source,
> > > sample)">
> > > > +
> > > > + <!-- Copy the source to the distribution area so that
> they
> > are
> > > included
> > > > + in the release -->
> > > > + <mkdir dir="${target.source.dir}"/>
> > > > +
> > > > + <zip
> > zipfile="${target.source.dir}/${target.source.name}.zip">
> > > > + <fileset dir=".">
> > > > + <include name="conf/**"/>
> > > > + <include name="src/**"/>
> > > > + <include name="*"/>
> > > > + <exclude name="build.properties"/>
> > > > + </fileset>
> > > > + </zip>
> > > >
> > > > <mkdir dir="${dist.main.dir}"/>
> > > >
> > > > @@ -410,6 +428,9 @@
> > > > <zipfileset dir="." prefix="doc">
> > > > <include name="LICENSE"/>
> > > > </zipfileset>
> > > > + <fileset dir="${target.source.dir}">
> > > > + <include name="${target.source.name}.zip"/>
> > > > + </fileset>
> > > > </zip>
> > > >
> > > > </target>
> > > >
> > > >
> > > >
> > > >
> > > > --
> > > > To unsubscribe, e-mail:
> > > <ma...@jakarta.apache.org>
> > > > For additional commands, e-mail:
> > > <ma...@jakarta.apache.org>
> > > >
> > >
> > > --
> > > To unsubscribe, e-mail: <mailto:struts-dev-
> > unsubscribe@jakarta.apache.org>
> > > For additional commands, e-mail: <mailto:struts-dev-
> > help@jakarta.apache.org>
> >
> > -- Ted Husted, Husted dot Com, Fairport NY USA.
> > -- Building Java web applications with Struts.
> > -- Tel +1 585 737-3463.
> > -- Web http://www.husted.com/struts/
> >
> > --
> > To unsubscribe, e-mail: <mailto:struts-dev-
> > unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail: <mailto:struts-dev-
> > help@jakarta.apache.org>
> >
>
>
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: cvs commit: jakarta-struts/contrib/scaffold build.xml
Posted by Vincent Massol <vm...@octo.com>.
> -----Original Message-----
> From: Ted Husted [mailto:husted@apache.org]
> Sent: 01 January 2002 21:26
> To: Struts Developers List
> Subject: Re: cvs commit: jakarta-struts/contrib/scaffold build.xml
>
> I just ran it, and it doesn't include the CVS directories.
>
> It does nest the scaffold-src.zip inside jakarta-scaffold.zip though,
> which is probably going to confuse people.
>
> Vincent, how about if we go with a jakarta-scaffold.jar and
> jakarta-scaffold-src.zip in the dist folder.
>
Where do you put the sample WAR ? In jakarta-scaffold-src.zip ? I did
not want to separate the src from the distribution as I thought it was
not needed and could be handy for users of scaffold, especially in the
current state of scaffold which has very little documentation.
In other words, here is what I am advocating :
jakarta-scaffold.zip (the main and only distributable file)
|_ lib
|_ scaffold.jar
|_ doc
|_ api
|_ (javadoc files)
|_ scaffold-sample.war
|_ scaffold-src.zip
If I understand correctly, you would prefer to have just the jar
standalone for persons who don't need sample nor documentation nor
source and a zip containing the rest, as in :
jakarta-scaffold.jar
jakarta-scaffold-src.zip
|_ scaffold-src.zip
|_ scaffold-sample.war
I'm not sure what you intend to have in Jakarta-scaffold-src.zip ? The
expanded directories ? Then, where do you put the sample WAR ? In a dist
subdirectory ? Somewhere else ?
-Vincent
> For Artimus, which is an application rather than a development
package,
> can we keep the src folders where they are, and just ZIP up the WAR.
> There's probably not much use for a binary distribution of Artimus.
>
> -Ted.
>
> Martin Cooper wrote:
> >
> > I haven't actually tried this, but it looks like the source zip
would
> also
> > include all the 'CVS' directories in the tree, along with their
> contents. If
> > that's the case, you might want to add an 'exclude' in the fileset,
> since we
> > wouldn't want those files in the distribution.
> >
> > --
> > Martin Cooper
> >
> > ----- Original Message -----
> > From: <vm...@apache.org>
> > To: <ja...@apache.org>
> > Sent: Tuesday, January 01, 2002 1:03 PM
> > Subject: cvs commit: jakarta-struts/contrib/scaffold build.xml
> >
> > > vmassol 02/01/01 13:03:51
> > >
> > > Modified: contrib/scaffold build.xml
> > > Log:
> > > added source zip to distribution file
> > >
> > > Revision Changes Path
> > > 1.3 +23 -2 jakarta-struts/contrib/scaffold/build.xml
> > >
> > > Index: build.xml
> > >
===================================================================
> > > RCS file: /home/cvs/jakarta-struts/contrib/scaffold/build.xml,v
> > > retrieving revision 1.2
> > > retrieving revision 1.3
> > > diff -u -r1.2 -r1.3
> > > --- build.xml 28 Dec 2001 13:34:56 -0000 1.2
> > > +++ build.xml 1 Jan 2002 21:03:50 -0000 1.3
> > > @@ -57,7 +57,7 @@
> > >
> > > @author <a href="mailto:ted@husted.com">Ted Husted</a>
> > > @author <a href="mailto:vmassol@apache.org">Vincent
Massol</a>
> > > - @version $Id: build.xml,v 1.2 2001/12/28 13:34:56 vmassol
Exp $
> > > + @version $Id: build.xml,v 1.3 2002/01/01 21:03:50 vmassol
Exp $
> > >
> >
>
========================================================================
==
> ==
> > =
> > > -->
> > > <project name="Scaffold" default="dist" basedir=".">
> > > @@ -135,6 +135,10 @@
> > > <property name="target.sample.name"
> > value="${project.name.file}-sample"/>
> > > <property name="target.sample.dir" value="${target.dir}"/>
> > >
> > > + <!-- Name of the source zip that is included in the main
> scaffold
> > zip -->
> > > + <property name="target.source.name"
> > value="${project.name.file}-src"/>
> > > + <property name="target.source.dir" value="${target.dir}"/>
> > > +
> > > <!--
> > >
> >
========================================================================
> > > Names of deliverables
> > > @@ -395,7 +399,21 @@
> > > Generate distributables
> > >
> >
========================================================================
> > > -->
> > > - <target name="dist" depends="jar,javadoc,sample">
> > > + <target name="dist" depends="jar,javadoc,sample"
> > > + description="Generates all distributables (binary, source,
> > sample)">
> > > +
> > > + <!-- Copy the source to the distribution area so that
they
> are
> > included
> > > + in the release -->
> > > + <mkdir dir="${target.source.dir}"/>
> > > +
> > > + <zip
> zipfile="${target.source.dir}/${target.source.name}.zip">
> > > + <fileset dir=".">
> > > + <include name="conf/**"/>
> > > + <include name="src/**"/>
> > > + <include name="*"/>
> > > + <exclude name="build.properties"/>
> > > + </fileset>
> > > + </zip>
> > >
> > > <mkdir dir="${dist.main.dir}"/>
> > >
> > > @@ -410,6 +428,9 @@
> > > <zipfileset dir="." prefix="doc">
> > > <include name="LICENSE"/>
> > > </zipfileset>
> > > + <fileset dir="${target.source.dir}">
> > > + <include name="${target.source.name}.zip"/>
> > > + </fileset>
> > > </zip>
> > >
> > > </target>
> > >
> > >
> > >
> > >
> > > --
> > > To unsubscribe, e-mail:
> > <ma...@jakarta.apache.org>
> > > For additional commands, e-mail:
> > <ma...@jakarta.apache.org>
> > >
> >
> > --
> > To unsubscribe, e-mail: <mailto:struts-dev-
> unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail: <mailto:struts-dev-
> help@jakarta.apache.org>
>
> -- Ted Husted, Husted dot Com, Fairport NY USA.
> -- Building Java web applications with Struts.
> -- Tel +1 585 737-3463.
> -- Web http://www.husted.com/struts/
>
> --
> To unsubscribe, e-mail: <mailto:struts-dev-
> unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:struts-dev-
> help@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-struts/contrib/scaffold build.xml
Posted by Ted Husted <hu...@apache.org>.
I just ran it, and it doesn't include the CVS directories.
It does nest the scaffold-src.zip inside jakarta-scaffold.zip though,
which is probably going to confuse people.
Vincent, how about if we go with a jakarta-scaffold.jar and
jakarta-scaffold-src.zip in the dist folder.
For Artimus, which is an application rather than a development package,
can we keep the src folders where they are, and just ZIP up the WAR.
There's probably not much use for a binary distribution of Artimus.
-Ted.
Martin Cooper wrote:
>
> I haven't actually tried this, but it looks like the source zip would also
> include all the 'CVS' directories in the tree, along with their contents. If
> that's the case, you might want to add an 'exclude' in the fileset, since we
> wouldn't want those files in the distribution.
>
> --
> Martin Cooper
>
> ----- Original Message -----
> From: <vm...@apache.org>
> To: <ja...@apache.org>
> Sent: Tuesday, January 01, 2002 1:03 PM
> Subject: cvs commit: jakarta-struts/contrib/scaffold build.xml
>
> > vmassol 02/01/01 13:03:51
> >
> > Modified: contrib/scaffold build.xml
> > Log:
> > added source zip to distribution file
> >
> > Revision Changes Path
> > 1.3 +23 -2 jakarta-struts/contrib/scaffold/build.xml
> >
> > Index: build.xml
> > ===================================================================
> > RCS file: /home/cvs/jakarta-struts/contrib/scaffold/build.xml,v
> > retrieving revision 1.2
> > retrieving revision 1.3
> > diff -u -r1.2 -r1.3
> > --- build.xml 28 Dec 2001 13:34:56 -0000 1.2
> > +++ build.xml 1 Jan 2002 21:03:50 -0000 1.3
> > @@ -57,7 +57,7 @@
> >
> > @author <a href="mailto:ted@husted.com">Ted Husted</a>
> > @author <a href="mailto:vmassol@apache.org">Vincent Massol</a>
> > - @version $Id: build.xml,v 1.2 2001/12/28 13:34:56 vmassol Exp $
> > + @version $Id: build.xml,v 1.3 2002/01/01 21:03:50 vmassol Exp $
> >
> ============================================================================
> =
> > -->
> > <project name="Scaffold" default="dist" basedir=".">
> > @@ -135,6 +135,10 @@
> > <property name="target.sample.name"
> value="${project.name.file}-sample"/>
> > <property name="target.sample.dir" value="${target.dir}"/>
> >
> > + <!-- Name of the source zip that is included in the main scaffold
> zip -->
> > + <property name="target.source.name"
> value="${project.name.file}-src"/>
> > + <property name="target.source.dir" value="${target.dir}"/>
> > +
> > <!--
> >
> ========================================================================
> > Names of deliverables
> > @@ -395,7 +399,21 @@
> > Generate distributables
> >
> ========================================================================
> > -->
> > - <target name="dist" depends="jar,javadoc,sample">
> > + <target name="dist" depends="jar,javadoc,sample"
> > + description="Generates all distributables (binary, source,
> sample)">
> > +
> > + <!-- Copy the source to the distribution area so that they are
> included
> > + in the release -->
> > + <mkdir dir="${target.source.dir}"/>
> > +
> > + <zip zipfile="${target.source.dir}/${target.source.name}.zip">
> > + <fileset dir=".">
> > + <include name="conf/**"/>
> > + <include name="src/**"/>
> > + <include name="*"/>
> > + <exclude name="build.properties"/>
> > + </fileset>
> > + </zip>
> >
> > <mkdir dir="${dist.main.dir}"/>
> >
> > @@ -410,6 +428,9 @@
> > <zipfileset dir="." prefix="doc">
> > <include name="LICENSE"/>
> > </zipfileset>
> > + <fileset dir="${target.source.dir}">
> > + <include name="${target.source.name}.zip"/>
> > + </fileset>
> > </zip>
> >
> > </target>
> >
> >
> >
> >
> > --
> > To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> > For additional commands, e-mail:
> <ma...@jakarta.apache.org>
> >
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
-- Ted Husted, Husted dot Com, Fairport NY USA.
-- Building Java web applications with Struts.
-- Tel +1 585 737-3463.
-- Web http://www.husted.com/struts/
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-struts/contrib/scaffold build.xml
Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
Good ol' "default excludes":
http://jakarta.apache.org/ant/manual/dirtasks.html
(at the bottom of that page)
Erik
----- Original Message -----
From: "Martin Cooper" <ma...@tumbleweed.com>
To: "Struts Developers List" <st...@jakarta.apache.org>
Sent: Tuesday, January 01, 2002 4:39 PM
Subject: Re: cvs commit: jakarta-struts/contrib/scaffold build.xml
> Ah, OK. I didn't realise that.
>
> --
> Martin Cooper
>
>
> ----- Original Message -----
> From: "Vincent Massol" <vm...@octo.com>
> To: "'Struts Developers List'" <st...@jakarta.apache.org>
> Sent: Tuesday, January 01, 2002 1:17 PM
> Subject: RE: cvs commit: jakarta-struts/contrib/scaffold build.xml
>
>
> >
> >
> > > -----Original Message-----
> > > From: Martin Cooper [mailto:martin.cooper@tumbleweed.com]
> > > Sent: 01 January 2002 21:16
> > > To: Struts Developers List
> > > Subject: Re: cvs commit: jakarta-struts/contrib/scaffold build.xml
> > >
> > > I haven't actually tried this, but it looks like the source zip would
> > also
> > > include all the 'CVS' directories in the tree, along with their
> > contents.
> > > If
> > > that's the case, you might want to add an 'exclude' in the fileset,
> > since
> > > we
> > > wouldn't want those files in the distribution.
> > >
> >
> > Thanks Martin but no ... the Ant zip task excludes the CVS directories
> > by default.
> >
> > -Vincent
> >
> > > --
> > > Martin Cooper
> > >
> > >
> > > ----- Original Message -----
> > > From: <vm...@apache.org>
> > > To: <ja...@apache.org>
> > > Sent: Tuesday, January 01, 2002 1:03 PM
> > > Subject: cvs commit: jakarta-struts/contrib/scaffold build.xml
> > >
> > >
> > > > vmassol 02/01/01 13:03:51
> > > >
> > > > Modified: contrib/scaffold build.xml
> > > > Log:
> > > > added source zip to distribution file
> > > >
> > > > Revision Changes Path
> > > > 1.3 +23 -2 jakarta-struts/contrib/scaffold/build.xml
> > > >
> > > > Index: build.xml
> > > >
> > ===================================================================
> > > > RCS file: /home/cvs/jakarta-struts/contrib/scaffold/build.xml,v
> > > > retrieving revision 1.2
> > > > retrieving revision 1.3
> > > > diff -u -r1.2 -r1.3
> > > > --- build.xml 28 Dec 2001 13:34:56 -0000 1.2
> > > > +++ build.xml 1 Jan 2002 21:03:50 -0000 1.3
> > > > @@ -57,7 +57,7 @@
> > > >
> > > > @author <a href="mailto:ted@husted.com">Ted Husted</a>
> > > > @author <a href="mailto:vmassol@apache.org">Vincent
> > Massol</a>
> > > > - @version $Id: build.xml,v 1.2 2001/12/28 13:34:56 vmassol Exp
> > $
> > > > + @version $Id: build.xml,v 1.3 2002/01/01 21:03:50 vmassol Exp
> > $
> > > >
> > >
> > ========================================================================
> > ==
> > > ==
> > > =
> > > > -->
> > > > <project name="Scaffold" default="dist" basedir=".">
> > > > @@ -135,6 +135,10 @@
> > > > <property name="target.sample.name"
> > > value="${project.name.file}-sample"/>
> > > > <property name="target.sample.dir" value="${target.dir}"/>
> > > >
> > > > + <!-- Name of the source zip that is included in the main
> > scaffold
> > > zip -->
> > > > + <property name="target.source.name"
> > > value="${project.name.file}-src"/>
> > > > + <property name="target.source.dir" value="${target.dir}"/>
> > > > +
> > > > <!--
> > > >
> > >
> > ========================================================================
> > > > Names of deliverables
> > > > @@ -395,7 +399,21 @@
> > > > Generate distributables
> > > >
> > >
> > ========================================================================
> > > > -->
> > > > - <target name="dist" depends="jar,javadoc,sample">
> > > > + <target name="dist" depends="jar,javadoc,sample"
> > > > + description="Generates all distributables (binary, source,
> > > sample)">
> > > > +
> > > > + <!-- Copy the source to the distribution area so that
> > they
> > > are
> > > included
> > > > + in the release -->
> > > > + <mkdir dir="${target.source.dir}"/>
> > > > +
> > > > + <zip
> > > zipfile="${target.source.dir}/${target.source.name}.zip">
> > > > + <fileset dir=".">
> > > > + <include name="conf/**"/>
> > > > + <include name="src/**"/>
> > > > + <include name="*"/>
> > > > + <exclude name="build.properties"/>
> > > > + </fileset>
> > > > + </zip>
> > > >
> > > > <mkdir dir="${dist.main.dir}"/>
> > > >
> > > > @@ -410,6 +428,9 @@
> > > > <zipfileset dir="." prefix="doc">
> > > > <include name="LICENSE"/>
> > > > </zipfileset>
> > > > + <fileset dir="${target.source.dir}">
> > > > + <include name="${target.source.name}.zip"/>
> > > > + </fileset>
> > > > </zip>
> > > >
> > > > </target>
> > > >
> > > >
> > > >
> > > >
> > > > --
> > > > To unsubscribe, e-mail:
> > > <ma...@jakarta.apache.org>
> > > > For additional commands, e-mail:
> > > <ma...@jakarta.apache.org>
> > > >
> > >
> > >
> > > --
> > > To unsubscribe, e-mail: <mailto:struts-dev-
> > > unsubscribe@jakarta.apache.org>
> > > For additional commands, e-mail: <mailto:struts-dev-
> > > help@jakarta.apache.org>
> > >
> >
> >
> >
> >
> > --
> > To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> > For additional commands, e-mail:
> <ma...@jakarta.apache.org>
> >
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-struts/contrib/scaffold build.xml
Posted by Martin Cooper <ma...@tumbleweed.com>.
Ah, OK. I didn't realise that.
--
Martin Cooper
----- Original Message -----
From: "Vincent Massol" <vm...@octo.com>
To: "'Struts Developers List'" <st...@jakarta.apache.org>
Sent: Tuesday, January 01, 2002 1:17 PM
Subject: RE: cvs commit: jakarta-struts/contrib/scaffold build.xml
>
>
> > -----Original Message-----
> > From: Martin Cooper [mailto:martin.cooper@tumbleweed.com]
> > Sent: 01 January 2002 21:16
> > To: Struts Developers List
> > Subject: Re: cvs commit: jakarta-struts/contrib/scaffold build.xml
> >
> > I haven't actually tried this, but it looks like the source zip would
> also
> > include all the 'CVS' directories in the tree, along with their
> contents.
> > If
> > that's the case, you might want to add an 'exclude' in the fileset,
> since
> > we
> > wouldn't want those files in the distribution.
> >
>
> Thanks Martin but no ... the Ant zip task excludes the CVS directories
> by default.
>
> -Vincent
>
> > --
> > Martin Cooper
> >
> >
> > ----- Original Message -----
> > From: <vm...@apache.org>
> > To: <ja...@apache.org>
> > Sent: Tuesday, January 01, 2002 1:03 PM
> > Subject: cvs commit: jakarta-struts/contrib/scaffold build.xml
> >
> >
> > > vmassol 02/01/01 13:03:51
> > >
> > > Modified: contrib/scaffold build.xml
> > > Log:
> > > added source zip to distribution file
> > >
> > > Revision Changes Path
> > > 1.3 +23 -2 jakarta-struts/contrib/scaffold/build.xml
> > >
> > > Index: build.xml
> > >
> ===================================================================
> > > RCS file: /home/cvs/jakarta-struts/contrib/scaffold/build.xml,v
> > > retrieving revision 1.2
> > > retrieving revision 1.3
> > > diff -u -r1.2 -r1.3
> > > --- build.xml 28 Dec 2001 13:34:56 -0000 1.2
> > > +++ build.xml 1 Jan 2002 21:03:50 -0000 1.3
> > > @@ -57,7 +57,7 @@
> > >
> > > @author <a href="mailto:ted@husted.com">Ted Husted</a>
> > > @author <a href="mailto:vmassol@apache.org">Vincent
> Massol</a>
> > > - @version $Id: build.xml,v 1.2 2001/12/28 13:34:56 vmassol Exp
> $
> > > + @version $Id: build.xml,v 1.3 2002/01/01 21:03:50 vmassol Exp
> $
> > >
> >
> ========================================================================
> ==
> > ==
> > =
> > > -->
> > > <project name="Scaffold" default="dist" basedir=".">
> > > @@ -135,6 +135,10 @@
> > > <property name="target.sample.name"
> > value="${project.name.file}-sample"/>
> > > <property name="target.sample.dir" value="${target.dir}"/>
> > >
> > > + <!-- Name of the source zip that is included in the main
> scaffold
> > zip -->
> > > + <property name="target.source.name"
> > value="${project.name.file}-src"/>
> > > + <property name="target.source.dir" value="${target.dir}"/>
> > > +
> > > <!--
> > >
> >
> ========================================================================
> > > Names of deliverables
> > > @@ -395,7 +399,21 @@
> > > Generate distributables
> > >
> >
> ========================================================================
> > > -->
> > > - <target name="dist" depends="jar,javadoc,sample">
> > > + <target name="dist" depends="jar,javadoc,sample"
> > > + description="Generates all distributables (binary, source,
> > sample)">
> > > +
> > > + <!-- Copy the source to the distribution area so that
> they
> > are
> > included
> > > + in the release -->
> > > + <mkdir dir="${target.source.dir}"/>
> > > +
> > > + <zip
> > zipfile="${target.source.dir}/${target.source.name}.zip">
> > > + <fileset dir=".">
> > > + <include name="conf/**"/>
> > > + <include name="src/**"/>
> > > + <include name="*"/>
> > > + <exclude name="build.properties"/>
> > > + </fileset>
> > > + </zip>
> > >
> > > <mkdir dir="${dist.main.dir}"/>
> > >
> > > @@ -410,6 +428,9 @@
> > > <zipfileset dir="." prefix="doc">
> > > <include name="LICENSE"/>
> > > </zipfileset>
> > > + <fileset dir="${target.source.dir}">
> > > + <include name="${target.source.name}.zip"/>
> > > + </fileset>
> > > </zip>
> > >
> > > </target>
> > >
> > >
> > >
> > >
> > > --
> > > To unsubscribe, e-mail:
> > <ma...@jakarta.apache.org>
> > > For additional commands, e-mail:
> > <ma...@jakarta.apache.org>
> > >
> >
> >
> > --
> > To unsubscribe, e-mail: <mailto:struts-dev-
> > unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail: <mailto:struts-dev-
> > help@jakarta.apache.org>
> >
>
>
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: cvs commit: jakarta-struts/contrib/scaffold build.xml
Posted by Vincent Massol <vm...@octo.com>.
> -----Original Message-----
> From: Martin Cooper [mailto:martin.cooper@tumbleweed.com]
> Sent: 01 January 2002 21:16
> To: Struts Developers List
> Subject: Re: cvs commit: jakarta-struts/contrib/scaffold build.xml
>
> I haven't actually tried this, but it looks like the source zip would
also
> include all the 'CVS' directories in the tree, along with their
contents.
> If
> that's the case, you might want to add an 'exclude' in the fileset,
since
> we
> wouldn't want those files in the distribution.
>
Thanks Martin but no ... the Ant zip task excludes the CVS directories
by default.
-Vincent
> --
> Martin Cooper
>
>
> ----- Original Message -----
> From: <vm...@apache.org>
> To: <ja...@apache.org>
> Sent: Tuesday, January 01, 2002 1:03 PM
> Subject: cvs commit: jakarta-struts/contrib/scaffold build.xml
>
>
> > vmassol 02/01/01 13:03:51
> >
> > Modified: contrib/scaffold build.xml
> > Log:
> > added source zip to distribution file
> >
> > Revision Changes Path
> > 1.3 +23 -2 jakarta-struts/contrib/scaffold/build.xml
> >
> > Index: build.xml
> >
===================================================================
> > RCS file: /home/cvs/jakarta-struts/contrib/scaffold/build.xml,v
> > retrieving revision 1.2
> > retrieving revision 1.3
> > diff -u -r1.2 -r1.3
> > --- build.xml 28 Dec 2001 13:34:56 -0000 1.2
> > +++ build.xml 1 Jan 2002 21:03:50 -0000 1.3
> > @@ -57,7 +57,7 @@
> >
> > @author <a href="mailto:ted@husted.com">Ted Husted</a>
> > @author <a href="mailto:vmassol@apache.org">Vincent
Massol</a>
> > - @version $Id: build.xml,v 1.2 2001/12/28 13:34:56 vmassol Exp
$
> > + @version $Id: build.xml,v 1.3 2002/01/01 21:03:50 vmassol Exp
$
> >
>
========================================================================
==
> ==
> =
> > -->
> > <project name="Scaffold" default="dist" basedir=".">
> > @@ -135,6 +135,10 @@
> > <property name="target.sample.name"
> value="${project.name.file}-sample"/>
> > <property name="target.sample.dir" value="${target.dir}"/>
> >
> > + <!-- Name of the source zip that is included in the main
scaffold
> zip -->
> > + <property name="target.source.name"
> value="${project.name.file}-src"/>
> > + <property name="target.source.dir" value="${target.dir}"/>
> > +
> > <!--
> >
>
========================================================================
> > Names of deliverables
> > @@ -395,7 +399,21 @@
> > Generate distributables
> >
>
========================================================================
> > -->
> > - <target name="dist" depends="jar,javadoc,sample">
> > + <target name="dist" depends="jar,javadoc,sample"
> > + description="Generates all distributables (binary, source,
> sample)">
> > +
> > + <!-- Copy the source to the distribution area so that
they
> are
> included
> > + in the release -->
> > + <mkdir dir="${target.source.dir}"/>
> > +
> > + <zip
> zipfile="${target.source.dir}/${target.source.name}.zip">
> > + <fileset dir=".">
> > + <include name="conf/**"/>
> > + <include name="src/**"/>
> > + <include name="*"/>
> > + <exclude name="build.properties"/>
> > + </fileset>
> > + </zip>
> >
> > <mkdir dir="${dist.main.dir}"/>
> >
> > @@ -410,6 +428,9 @@
> > <zipfileset dir="." prefix="doc">
> > <include name="LICENSE"/>
> > </zipfileset>
> > + <fileset dir="${target.source.dir}">
> > + <include name="${target.source.name}.zip"/>
> > + </fileset>
> > </zip>
> >
> > </target>
> >
> >
> >
> >
> > --
> > To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> > For additional commands, e-mail:
> <ma...@jakarta.apache.org>
> >
>
>
> --
> To unsubscribe, e-mail: <mailto:struts-dev-
> unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:struts-dev-
> help@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-struts/contrib/scaffold build.xml
Posted by Martin Cooper <ma...@tumbleweed.com>.
I haven't actually tried this, but it looks like the source zip would also
include all the 'CVS' directories in the tree, along with their contents. If
that's the case, you might want to add an 'exclude' in the fileset, since we
wouldn't want those files in the distribution.
--
Martin Cooper
----- Original Message -----
From: <vm...@apache.org>
To: <ja...@apache.org>
Sent: Tuesday, January 01, 2002 1:03 PM
Subject: cvs commit: jakarta-struts/contrib/scaffold build.xml
> vmassol 02/01/01 13:03:51
>
> Modified: contrib/scaffold build.xml
> Log:
> added source zip to distribution file
>
> Revision Changes Path
> 1.3 +23 -2 jakarta-struts/contrib/scaffold/build.xml
>
> Index: build.xml
> ===================================================================
> RCS file: /home/cvs/jakarta-struts/contrib/scaffold/build.xml,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -r1.2 -r1.3
> --- build.xml 28 Dec 2001 13:34:56 -0000 1.2
> +++ build.xml 1 Jan 2002 21:03:50 -0000 1.3
> @@ -57,7 +57,7 @@
>
> @author <a href="mailto:ted@husted.com">Ted Husted</a>
> @author <a href="mailto:vmassol@apache.org">Vincent Massol</a>
> - @version $Id: build.xml,v 1.2 2001/12/28 13:34:56 vmassol Exp $
> + @version $Id: build.xml,v 1.3 2002/01/01 21:03:50 vmassol Exp $
>
============================================================================
=
> -->
> <project name="Scaffold" default="dist" basedir=".">
> @@ -135,6 +135,10 @@
> <property name="target.sample.name"
value="${project.name.file}-sample"/>
> <property name="target.sample.dir" value="${target.dir}"/>
>
> + <!-- Name of the source zip that is included in the main scaffold
zip -->
> + <property name="target.source.name"
value="${project.name.file}-src"/>
> + <property name="target.source.dir" value="${target.dir}"/>
> +
> <!--
>
========================================================================
> Names of deliverables
> @@ -395,7 +399,21 @@
> Generate distributables
>
========================================================================
> -->
> - <target name="dist" depends="jar,javadoc,sample">
> + <target name="dist" depends="jar,javadoc,sample"
> + description="Generates all distributables (binary, source,
sample)">
> +
> + <!-- Copy the source to the distribution area so that they are
included
> + in the release -->
> + <mkdir dir="${target.source.dir}"/>
> +
> + <zip zipfile="${target.source.dir}/${target.source.name}.zip">
> + <fileset dir=".">
> + <include name="conf/**"/>
> + <include name="src/**"/>
> + <include name="*"/>
> + <exclude name="build.properties"/>
> + </fileset>
> + </zip>
>
> <mkdir dir="${dist.main.dir}"/>
>
> @@ -410,6 +428,9 @@
> <zipfileset dir="." prefix="doc">
> <include name="LICENSE"/>
> </zipfileset>
> + <fileset dir="${target.source.dir}">
> + <include name="${target.source.name}.zip"/>
> + </fileset>
> </zip>
>
> </target>
>
>
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>