You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/29 04:15:18 UTC
[GitHub] [spark] cloud-fan commented on issue #25264:
[SPARK-28213][SQL][followup] code cleanup and bug fix for columnar
execution framework
cloud-fan commented on issue #25264: [SPARK-28213][SQL][followup] code cleanup and bug fix for columnar execution framework
URL: https://github.com/apache/spark/pull/25264#issuecomment-515837966
After more thoughts, I think we should still insert `InputAdapter` under `ColumnarToRowExec`. But we can simplify the whole-stage-codegen planning logic a bit, because codegen stage can never overlap with a columnar stage, as whole-stage-codegen is completely row-based. When these 2 stages are adjacent, it's either a `RowToColumnarExec` above `WholeStageExec`, or a `ColumnarToRowExec` above the `InputAdapter`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org