You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/02/08 11:37:48 UTC
Review Request 56438: Reset Workflow on newly created workflow blocks
UI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56438/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-19918
https://issues.apache.org/jira/browse/AMBARI-19918
Repository: ambari
Description
-------
Reset Workflow on newly created workflow blocks UI.
Steps.
create new worklow.
create a node.
click reset workflow.
Observe that UI is blocked by some modal.
Expected behaviour-: the workflow should become empty workflow with only start and end node.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 445b86e
contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js b045798
contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js 0b689b0
contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 86c8dc9
contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 90fba0d
contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 93ce758
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs b29ae21
Diff: https://reviews.apache.org/r/56438/diff/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 56438: Reset Workflow on newly created workflow
blocks UI
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56438/#review164665
-----------------------------------------------------------
Ship it!
Ship It!
- Nitiraj Rathore
On Feb. 8, 2017, 11:37 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56438/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 11:37 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19918
> https://issues.apache.org/jira/browse/AMBARI-19918
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Reset Workflow on newly created workflow blocks UI.
> Steps.
> create new worklow.
> create a node.
> click reset workflow.
> Observe that UI is blocked by some modal.
>
> Expected behaviour-: the workflow should become empty workflow with only start and end node.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 445b86e
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js b045798
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js 0b689b0
> contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 86c8dc9
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 90fba0d
> contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 93ce758
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs b29ae21
>
> Diff: https://reviews.apache.org/r/56438/diff/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 56438: Reset Workflow on newly created workflow
blocks UI
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56438/#review164672
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 8, 2017, 11:37 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56438/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 11:37 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19918
> https://issues.apache.org/jira/browse/AMBARI-19918
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Reset Workflow on newly created workflow blocks UI.
> Steps.
> create new worklow.
> create a node.
> click reset workflow.
> Observe that UI is blocked by some modal.
>
> Expected behaviour-: the workflow should become empty workflow with only start and end node.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 445b86e
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js b045798
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js 0b689b0
> contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js 86c8dc9
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 90fba0d
> contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 93ce758
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs b29ae21
>
> Diff: https://reviews.apache.org/r/56438/diff/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>