You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@myfaces.apache.org by John Sherwood <jo...@ipsystems.com.au> on 2006/11/01 06:30:02 UTC
Re: Using rowIndexVar in datatable for setting rowId fails
I'm getting the same problem except that I upgraded to MyFaces 1.1.4 from
1.1.4-SNAPSHOT.
For some reason, it renders the first row without any information and also
renders another row at the end.
E.g. rendering a list of things with ids from 1 to 5:
<tr >thing 1 stuff</tr>
<tr id="1">thing 2 stuff</tr>
<tr id="2">thing 3 stuff</tr>
<tr id="3">thing 4 stuff</tr>
<tr id="4">thing 5 stuff</tr>
<tr id="5"></tr>
I dunno what the heck is wrong with it. I would really appreciate some help
with this. Otherwise, it'll be back to the snapshots :(
--
View this message in context: http://www.nabble.com/Using-rowIndexVar-in-datatable-for-setting-rowId-fails-tf1863626.html#a7108336
Sent from the MyFaces - Users mailing list archive at Nabble.com.
Re: Using rowIndexVar in datatable for setting rowId fails
Posted by Simon Kitching <si...@rhe.co.nz>.
Hi,
I think you're referring to this bug, which also bit us:
http://issues.apache.org/jira/browse/TOMAHAWK-485
It's a problem in HtmlTableRendererBase.encodeInnerHtml in the version
of myfaces-shared that is included in the tomahawk 1.1.3 jar.
This could well be causing the effect you see.
The bug is fixed in the trunk version of the myfaces-shared project, so
we just created a subclass of the tomahawk HtmlDataTable class that
overrides the buggy method using the latest code
forHtmlTableRendererBase.encodeInnerHtml on trunk. We then set up the
faces config file to define that new class as the renderer for the table
component and all was well again, while still running a standard
tomahawk-1.1.3 release.
Using tomahawk snapshot (which of course uses a snapshot of
myfaces-shared) would be another alternative.
Cheers,
Simon
Andrew Robinson wrote:
> That was a bug, I'm not sure of the issue number, but I remember I had
> to pull the patches out of SVN and apply them to my 1.1.3 source to
> fix the issue.
>
> On 11/1/06, Torsten Krah <tk...@fachschaft.imn.htwk-leipzig.de> wrote:
>> I cannot confirm this, the id output works fine and there no missing nor
>> an additional row in the output.
>> I am using myfaces 1.1.4 and tomahawks 1.1.4-snapshot, its working like
>> expected.
>>
>> Torsten
>>
>> Am Dienstag, den 31.10.2006, 21:30 -0800 schrieb John Sherwood:
>> > I'm getting the same problem except that I upgraded to MyFaces
>> 1.1.4 from
>> > 1.1.4-SNAPSHOT.
>> >
>> > For some reason, it renders the first row without any information
>> and also
>> > renders another row at the end.
>> >
>> > E.g. rendering a list of things with ids from 1 to 5:
>> >
>> > <tr >thing 1 stuff</tr>
>> > <tr id="1">thing 2 stuff</tr>
>> > <tr id="2">thing 3 stuff</tr>
>> > <tr id="3">thing 4 stuff</tr>
>> > <tr id="4">thing 5 stuff</tr>
>> > <tr id="5"></tr>
>> >
>> > I dunno what the heck is wrong with it. I would really appreciate
>> some help
>> > with this. Otherwise, it'll be back to the snapshots :(
>>
>>
>>
Re: Using rowIndexVar in datatable for setting rowId fails
Posted by Andrew Robinson <an...@gmail.com>.
That was a bug, I'm not sure of the issue number, but I remember I had
to pull the patches out of SVN and apply them to my 1.1.3 source to
fix the issue.
On 11/1/06, Torsten Krah <tk...@fachschaft.imn.htwk-leipzig.de> wrote:
> I cannot confirm this, the id output works fine and there no missing nor
> an additional row in the output.
> I am using myfaces 1.1.4 and tomahawks 1.1.4-snapshot, its working like
> expected.
>
> Torsten
>
> Am Dienstag, den 31.10.2006, 21:30 -0800 schrieb John Sherwood:
> > I'm getting the same problem except that I upgraded to MyFaces 1.1.4 from
> > 1.1.4-SNAPSHOT.
> >
> > For some reason, it renders the first row without any information and also
> > renders another row at the end.
> >
> > E.g. rendering a list of things with ids from 1 to 5:
> >
> > <tr >thing 1 stuff</tr>
> > <tr id="1">thing 2 stuff</tr>
> > <tr id="2">thing 3 stuff</tr>
> > <tr id="3">thing 4 stuff</tr>
> > <tr id="4">thing 5 stuff</tr>
> > <tr id="5"></tr>
> >
> > I dunno what the heck is wrong with it. I would really appreciate some help
> > with this. Otherwise, it'll be back to the snapshots :(
>
>
>
Re: Using rowIndexVar in datatable for setting rowId fails
Posted by Torsten Krah <tk...@fachschaft.imn.htwk-leipzig.de>.
I cannot confirm this, the id output works fine and there no missing nor
an additional row in the output.
I am using myfaces 1.1.4 and tomahawks 1.1.4-snapshot, its working like
expected.
Torsten
Am Dienstag, den 31.10.2006, 21:30 -0800 schrieb John Sherwood:
> I'm getting the same problem except that I upgraded to MyFaces 1.1.4 from
> 1.1.4-SNAPSHOT.
>
> For some reason, it renders the first row without any information and also
> renders another row at the end.
>
> E.g. rendering a list of things with ids from 1 to 5:
>
> <tr >thing 1 stuff</tr>
> <tr id="1">thing 2 stuff</tr>
> <tr id="2">thing 3 stuff</tr>
> <tr id="3">thing 4 stuff</tr>
> <tr id="4">thing 5 stuff</tr>
> <tr id="5"></tr>
>
> I dunno what the heck is wrong with it. I would really appreciate some help
> with this. Otherwise, it'll be back to the snapshots :(