You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/13 13:50:28 UTC

[GitHub] [flink] Airblader commented on a change in pull request #17451: [FLINK-24476][docs] Rename Elasticsearch to remove CamelCase

Airblader commented on a change in pull request #17451:
URL: https://github.com/apache/flink/pull/17451#discussion_r728084582



##########
File path: flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSink.java
##########
@@ -78,10 +78,10 @@ public Elasticsearch6DynamicSink(
     // on the sink itself.
     // --------------------------------------------------------------
 
-    private final ElasticSearchBuilderProvider builderProvider;
+    private final ElasticsearchBuilderProvider builderProvider;
 
     @FunctionalInterface
-    interface ElasticSearchBuilderProvider {
+    interface ElasticsearchBuilderProvider {

Review comment:
       Despite the comment surrounding this block, annotation-wise this is technically Public API. I'd still +1 to change it, but any committer merging this should be aware of this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org