You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2016/06/27 04:18:54 UTC
[GitHub] spark pull request #13917: [MINOR][SQL][TEST] checkAnswer does not print the...
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/13917
[MINOR][SQL][TEST] checkAnswer does not print the rows being compared in a correct order
## What changes were proposed in this pull request?
This PR corrects the order of rows being printed in `checkAnswer()` function. For example,
```scala
val a = Seq("foo", "bar", "bla", "blabla").toDF()
val b = Seq("fooo","barr", "bla", "blabla").toDF()
checkAnswer(a, b)
```
The codes above print the error message as below:
```
== Results ==
!== Correct Answer - 4 == == Spark Answer - 4 ==
![barr] [bar]
[bla] [bla]
[blabla] [blabla]
![fooo] [foo]
```
I understand it compares after sorting the rows but the error message seems not sensible.
This PR corrects the order as it is rather than sorts the rows as below:
```
== Results ==
!== Correct Answer - 4 == == Spark Answer - 4 ==
![fooo] [foo]
![barr] [bar]
[bla] [bla]
[blabla] [blabla]
```
**This PR does not change the actual comparison but just the contents being printed.**
## How was this patch tested?
Manually tested.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark test-msg
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13917.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13917
----
commit 8f0232d7c37bbef069d39c4cf1a0386f47b8c647
Author: hyukjinkwon <gu...@gmail.com>
Date: 2016-06-27T04:03:58Z
Print correct order of rows being compared
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13917: [MINOR][SQL][TEST] checkAnswer does not print the rows b...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13917
**[Test build #61284 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61284/consoleFull)** for PR 13917 at commit [`8f0232d`](https://github.com/apache/spark/commit/8f0232d7c37bbef069d39c4cf1a0386f47b8c647).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13917: [MINOR][SQL][TEST] checkAnswer does not print the rows b...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13917
**[Test build #61284 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61284/consoleFull)** for PR 13917 at commit [`8f0232d`](https://github.com/apache/spark/commit/8f0232d7c37bbef069d39c4cf1a0386f47b8c647).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13917: [MINOR][SQL][TEST] checkAnswer does not print the...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon closed the pull request at:
https://github.com/apache/spark/pull/13917
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13917: [MINOR][SQL][TEST] checkAnswer does not print the rows b...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13917
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13917: [MINOR][SQL][TEST] checkAnswer does not print the rows b...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/13917
Sorry, this will prints wrong items when the order is different. Closing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13917: [MINOR][SQL][TEST] checkAnswer does not print the rows b...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13917
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61284/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org