You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/07/16 14:49:02 UTC
[GitHub] [mynewt-newt] utzig commented on a change in pull request #309:
Allow to override path escaping from command line
utzig commented on a change in pull request #309: Allow to override path escaping from command line
URL: https://github.com/apache/mynewt-newt/pull/309#discussion_r303952868
##########
File path: newt/newt.go
##########
@@ -128,7 +126,7 @@ func newtCmd() *cobra.Command {
newtCmd.PersistentFlags().BoolVarP(&newtHelp, "help", "h",
false, "Help for newt commands")
newtCmd.PersistentFlags().BoolVarP(&newtEscapeShellCmds, "escape", "",
- false, "Apply Windows escapes to shell commands")
+ runtime.GOOS == "windows", "Apply Windows escapes to shell commands")
Review comment:
Does it really matter to turn it on by default for Windows here, if above you have `util.EscapeShellCmds = newtEscapeShellCmds`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services