You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Christian Moen (JIRA)" <ji...@apache.org> on 2012/06/07 21:43:24 UTC
[jira] [Created] (SOLR-3520) Add missing tests for
JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
Christian Moen created SOLR-3520:
------------------------------------
Summary: Add missing tests for JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
Key: SOLR-3520
URL: https://issues.apache.org/jira/browse/SOLR-3520
Project: Solr
Issue Type: Test
Affects Versions: 4.0, 5.0
Reporter: Christian Moen
Priority: Minor
{{JapaneseReadingFormFilterFactory}} and {{JapaneseKatakanaStemFilterFactory}} doesn't have any tests and it would be good to have some.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3520) Add missing tests for
JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
Posted by "Christian Moen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Moen updated SOLR-3520:
---------------------------------
Attachment: SOLR-3520.patch
> Add missing tests for JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-3520
> URL: https://issues.apache.org/jira/browse/SOLR-3520
> Project: Solr
> Issue Type: Test
> Affects Versions: 4.0, 5.0
> Reporter: Christian Moen
> Priority: Minor
> Attachments: SOLR-3520.patch
>
>
> {{JapaneseReadingFormFilterFactory}} and {{JapaneseKatakanaStemFilterFactory}} doesn't have any tests and it would be good to have some.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3520) Add missing tests for
JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
Posted by "Christian Moen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291639#comment-13291639 ]
Christian Moen commented on SOLR-3520:
--------------------------------------
Thanks, Robert.
We have them in Lucene, but not adding some for Solr was an oversight on my part. Very good idea to keep an eye the Clover reports.
I'll commit this shortly.
> Add missing tests for JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-3520
> URL: https://issues.apache.org/jira/browse/SOLR-3520
> Project: Solr
> Issue Type: Test
> Affects Versions: 4.0, 5.0
> Reporter: Christian Moen
> Priority: Minor
> Attachments: SOLR-3520.patch
>
>
> {{JapaneseReadingFormFilterFactory}} and {{JapaneseKatakanaStemFilterFactory}} doesn't have any tests and it would be good to have some.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3520) Add missing tests for
JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
Posted by "Christian Moen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291275#comment-13291275 ]
Christian Moen commented on SOLR-3520:
--------------------------------------
Attaching a patch.
> Add missing tests for JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-3520
> URL: https://issues.apache.org/jira/browse/SOLR-3520
> Project: Solr
> Issue Type: Test
> Affects Versions: 4.0, 5.0
> Reporter: Christian Moen
> Priority: Minor
> Attachments: SOLR-3520.patch
>
>
> {{JapaneseReadingFormFilterFactory}} and {{JapaneseKatakanaStemFilterFactory}} doesn't have any tests and it would be good to have some.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Comment Edited] (SOLR-3520) Add missing tests for
JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
Posted by "Christian Moen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291853#comment-13291853 ]
Christian Moen edited comment on SOLR-3520 at 6/8/12 4:42 PM:
--------------------------------------------------------------
Committed r1348148 on {{branch_4x}}.
was (Author: cm):
Committed r1348148 on {{branch_4x}}
> Add missing tests for JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-3520
> URL: https://issues.apache.org/jira/browse/SOLR-3520
> Project: Solr
> Issue Type: Test
> Affects Versions: 4.0, 5.0
> Reporter: Christian Moen
> Priority: Minor
> Attachments: SOLR-3520.patch, SOLR-3520.patch
>
>
> {{JapaneseReadingFormFilterFactory}} and {{JapaneseKatakanaStemFilterFactory}} doesn't have any tests and it would be good to have some.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (SOLR-3520) Add missing tests for
JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
Posted by "Christian Moen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Moen reassigned SOLR-3520:
------------------------------------
Assignee: Christian Moen
> Add missing tests for JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-3520
> URL: https://issues.apache.org/jira/browse/SOLR-3520
> Project: Solr
> Issue Type: Test
> Affects Versions: 4.0, 5.0
> Reporter: Christian Moen
> Assignee: Christian Moen
> Priority: Minor
> Attachments: SOLR-3520.patch, SOLR-3520.patch
>
>
> {{JapaneseReadingFormFilterFactory}} and {{JapaneseKatakanaStemFilterFactory}} doesn't have any tests and it would be good to have some.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3520) Add missing tests for
JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
Posted by "Christian Moen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Moen updated SOLR-3520:
---------------------------------
Attachment: SOLR-3520.patch
> Add missing tests for JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-3520
> URL: https://issues.apache.org/jira/browse/SOLR-3520
> Project: Solr
> Issue Type: Test
> Affects Versions: 4.0, 5.0
> Reporter: Christian Moen
> Priority: Minor
> Attachments: SOLR-3520.patch, SOLR-3520.patch
>
>
> {{JapaneseReadingFormFilterFactory}} and {{JapaneseKatakanaStemFilterFactory}} doesn't have any tests and it would be good to have some.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3520) Add missing tests for
JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291637#comment-13291637 ]
Robert Muir commented on SOLR-3520:
-----------------------------------
+1
its dangerous when these don't have tests, there could be very simple bugs or patches in the future that break things
and we won't notice.
we should also keep an eye on https://builds.apache.org/job/Solr-trunk/clover/org/apache/solr/analysis/pkg-summary.html
which makes it very easy to see which ones are missing tests.
> Add missing tests for JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-3520
> URL: https://issues.apache.org/jira/browse/SOLR-3520
> Project: Solr
> Issue Type: Test
> Affects Versions: 4.0, 5.0
> Reporter: Christian Moen
> Priority: Minor
> Attachments: SOLR-3520.patch
>
>
> {{JapaneseReadingFormFilterFactory}} and {{JapaneseKatakanaStemFilterFactory}} doesn't have any tests and it would be good to have some.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3520) Add missing tests for
JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
Posted by "Christian Moen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Moen resolved SOLR-3520.
----------------------------------
Resolution: Fixed
> Add missing tests for JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-3520
> URL: https://issues.apache.org/jira/browse/SOLR-3520
> Project: Solr
> Issue Type: Test
> Affects Versions: 4.0, 5.0
> Reporter: Christian Moen
> Assignee: Christian Moen
> Priority: Minor
> Attachments: SOLR-3520.patch, SOLR-3520.patch
>
>
> {{JapaneseReadingFormFilterFactory}} and {{JapaneseKatakanaStemFilterFactory}} doesn't have any tests and it would be good to have some.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3520) Add missing tests for
JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
Posted by "Christian Moen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291853#comment-13291853 ]
Christian Moen commented on SOLR-3520:
--------------------------------------
Committed r1348148 on {{branch_4x}}
> Add missing tests for JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-3520
> URL: https://issues.apache.org/jira/browse/SOLR-3520
> Project: Solr
> Issue Type: Test
> Affects Versions: 4.0, 5.0
> Reporter: Christian Moen
> Priority: Minor
> Attachments: SOLR-3520.patch, SOLR-3520.patch
>
>
> {{JapaneseReadingFormFilterFactory}} and {{JapaneseKatakanaStemFilterFactory}} doesn't have any tests and it would be good to have some.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3520) Add missing tests for
JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
Posted by "Christian Moen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291837#comment-13291837 ]
Christian Moen commented on SOLR-3520:
--------------------------------------
Updated patch with a case that also deals with short katakana terms that shouldn't be stemmed by default. Will commit shortly.
> Add missing tests for JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-3520
> URL: https://issues.apache.org/jira/browse/SOLR-3520
> Project: Solr
> Issue Type: Test
> Affects Versions: 4.0, 5.0
> Reporter: Christian Moen
> Priority: Minor
> Attachments: SOLR-3520.patch, SOLR-3520.patch
>
>
> {{JapaneseReadingFormFilterFactory}} and {{JapaneseKatakanaStemFilterFactory}} doesn't have any tests and it would be good to have some.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3520) Add missing tests for
JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
Posted by "Christian Moen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291839#comment-13291839 ]
Christian Moen commented on SOLR-3520:
--------------------------------------
Committed r1348134 on {{trunk}}.
> Add missing tests for JapaneseReadingFormFilterFactory and JapaneseKatakanaStemFilterFactory
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-3520
> URL: https://issues.apache.org/jira/browse/SOLR-3520
> Project: Solr
> Issue Type: Test
> Affects Versions: 4.0, 5.0
> Reporter: Christian Moen
> Priority: Minor
> Attachments: SOLR-3520.patch, SOLR-3520.patch
>
>
> {{JapaneseReadingFormFilterFactory}} and {{JapaneseKatakanaStemFilterFactory}} doesn't have any tests and it would be good to have some.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org