[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7339: Fix exclusive start partitions for sequenceMetadata

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #7339: Fix exclusive start partitions for sequenceMetadata
URL: https://github.com/apache/incubator-druid/pull/7339#discussion_r268836768
 
 

 ##########
 File path: indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java
 ##########
 @@ -1072,9 +1105,26 @@ private void addSequence(final SequenceMetadata<PartitionIdType, SequenceOffsetT
       }
     }
 
+    if (!isEndOffsetExclusive() && !sequences.isEmpty()) {
 
 Review comment:
   I thought it too, but I decided to check separately because `sequences` is a `CopyOnWriteArrayList` and so it can be updated between lines.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org