[GitHub] [inlong] healchow commented on a diff in pull request #5852: [INLONG-5851][TubeMQ] Optimize while-sleep to ScheduledExecutorService in tube-manager

[GitBox <gi...@apache.org>]

healchow commented on code in PR #5852:
URL: https://github.com/apache/inlong/pull/5852#discussion_r973647501


##########
inlong-tubemq/tubemq-manager/pom.xml:
##########
@@ -176,6 +176,10 @@
             <groupId>jakarta.validation</groupId>
             <artifactId>jakarta.validation-api</artifactId>
         </dependency>
+      <dependency>
+        <groupId>io.netty</groupId>
+        <artifactId>netty-common</artifactId>

Review Comment:
   Excuse me, where did you use the netty-common package?



##########
licenses/inlong-tubemq-manager/LICENSE:
##########
@@ -452,6 +452,7 @@ The text of each license is also included at licenses/LICENSE-[project].txt.
   org.springframework:spring-web:5.3.20 - Spring Web (https://github.com/spring-projects/spring-framework), (Apache License, Version 2.0)
   org.springframework:spring-webmvc:5.3.18 - Spring Web MVC (https://github.com/spring-projects/spring-framework), (Apache License, Version 2.0)
   org.apache.tomcat.embed:tomcat-embed-core:9.0.60 - tomcat-embed-core (https://tomcat.apache.org/), (Apache License, Version 2.0)
+  io.netty:netty-common:4.1.72.Final - Netty/Common (https://github.com/netty/netty/tree/netty-4.1.72.Final), (Apache License, Version 2.0)

Review Comment:
   If the netty-common jar is needed, it should be sorted alphabetically by artifactId, here it's `netty-common`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org