You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2016/11/10 21:27:22 UTC

Review Request 53659: HIVE-15148 disallow loading data into bucketed tables (by default)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53659/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Repository: hive-git


Description
-------

see jira


Diffs
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 56289c9 
  data/scripts/q_test_init.sql 0c8668c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java a7005f1 
  ql/src/test/queries/clientnegative/alter_concatenate_indexed_table.q 4193315 
  ql/src/test/queries/clientnegative/bucket_mapjoin_mismatch1.q 7dce81f 
  ql/src/test/queries/clientnegative/dynamic_partitions_with_whitelist.q 8623db8 
  ql/src/test/queries/clientnegative/insertover_dynapart_ifnotexists.q a8f77c2 
  ql/src/test/queries/clientpositive/alter_concatenate_indexed_table.q d2bc440 
  ql/src/test/queries/clientpositive/alter_merge.q 0ff0294 
  ql/src/test/queries/clientpositive/alter_merge_2.q e09703d 
  ql/src/test/queries/clientpositive/alter_merge_stats.q 0af87e2 
  ql/src/test/queries/clientpositive/autoColumnStats_1.q bb7252a 
  ql/src/test/queries/clientpositive/autoColumnStats_2.q c1abcb1 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_1.q 6c2fbba 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_11.q aa345b5 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_12.q b344bd0 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_16.q 83b67f8 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_2.q 2cf809b 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_3.q b14b32b 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_4.q b08649e 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_5.q 489f556 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_7.q 161bc8a 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_8.q cc2ba28 
  ql/src/test/queries/clientpositive/bucket_map_join_spark1.q 3f9ccc4 
  ql/src/test/queries/clientpositive/bucket_map_join_spark2.q 4a70671 
  ql/src/test/queries/clientpositive/bucket_map_join_spark3.q 9ae7986 
  ql/src/test/queries/clientpositive/bucket_map_join_tez1.q ade04dd 
  ql/src/test/queries/clientpositive/bucket_map_join_tez2.q fd997df 
  ql/src/test/queries/clientpositive/bucketcontext_1.q ad0f473 
  ql/src/test/queries/clientpositive/bucketcontext_2.q 931f55a 
  ql/src/test/queries/clientpositive/bucketcontext_3.q e03b285 
  ql/src/test/queries/clientpositive/bucketcontext_4.q af08f07 
  ql/src/test/queries/clientpositive/bucketcontext_5.q 5078072 
  ql/src/test/queries/clientpositive/bucketcontext_6.q 5549f3b 
  ql/src/test/queries/clientpositive/bucketcontext_7.q 44cdb5e 
  ql/src/test/queries/clientpositive/bucketcontext_8.q bb655e2 
  ql/src/test/queries/clientpositive/bucketizedhiveinputformat_auto.q a2b0bbe 
  ql/src/test/queries/clientpositive/bucketmapjoin1.q 2fd3804 
  ql/src/test/queries/clientpositive/bucketmapjoin10.q 09c0ae2 
  ql/src/test/queries/clientpositive/bucketmapjoin11.q d330b77 
  ql/src/test/queries/clientpositive/bucketmapjoin12.q 43a9de4 
  ql/src/test/queries/clientpositive/bucketmapjoin2.q d14261f 
  ql/src/test/queries/clientpositive/bucketmapjoin3.q 78c23d5 
  ql/src/test/queries/clientpositive/bucketmapjoin4.q 54626e7 
  ql/src/test/queries/clientpositive/bucketmapjoin5.q 6c03bbb 
  ql/src/test/queries/clientpositive/bucketmapjoin7.q cd4efe7 
  ql/src/test/queries/clientpositive/bucketmapjoin8.q f467ea6 
  ql/src/test/queries/clientpositive/bucketmapjoin9.q f1d5f58 
  ql/src/test/queries/clientpositive/bucketmapjoin_negative.q ea140dd 
  ql/src/test/queries/clientpositive/bucketmapjoin_negative2.q 36d34dc 
  ql/src/test/queries/clientpositive/bucketmapjoin_negative3.q 6398fff 
  ql/src/test/queries/clientpositive/cbo_rp_udaf_percentile_approx_23.q 0f2d0dd 
  ql/src/test/queries/clientpositive/char_1.q e617a49 
  ql/src/test/queries/clientpositive/char_serde.q 4340b4d 
  ql/src/test/queries/clientpositive/create_merge_compressed.q 483931b 
  ql/src/test/queries/clientpositive/explainanalyze_2.q 8b3df87 
  ql/src/test/queries/clientpositive/explainanalyze_3.q 61f68a1 
  ql/src/test/queries/clientpositive/explainuser_1.q 3791662 
  ql/src/test/queries/clientpositive/explainuser_2.q 3f8bdb4 
  ql/src/test/queries/clientpositive/explainuser_3.q 57029f1 
  ql/src/test/queries/clientpositive/global_limit.q 8c5f2ea 
  ql/src/test/queries/clientpositive/infer_bucket_sort_dyn_part.q 4937be4 
  ql/src/test/queries/clientpositive/merge_dynamic_partition.q fa4d442 
  ql/src/test/queries/clientpositive/merge_dynamic_partition2.q 73a71e6 
  ql/src/test/queries/clientpositive/merge_dynamic_partition3.q 79ae2b9 
  ql/src/test/queries/clientpositive/merge_dynamic_partition4.q 33388c6 
  ql/src/test/queries/clientpositive/merge_dynamic_partition5.q 9a35101 
  ql/src/test/queries/clientpositive/mergejoin.q fa53a76 
  ql/src/test/queries/clientpositive/smb_mapjoin_1.q 4f913e7 
  ql/src/test/queries/clientpositive/smb_mapjoin_10.q 1fbe209 
  ql/src/test/queries/clientpositive/smb_mapjoin_2.q 5e729d9 
  ql/src/test/queries/clientpositive/smb_mapjoin_25.q 834d44c 
  ql/src/test/queries/clientpositive/smb_mapjoin_3.q 549eb85 
  ql/src/test/queries/clientpositive/smb_mapjoin_4.q e9d28ba 
  ql/src/test/queries/clientpositive/smb_mapjoin_5.q 5b6eeb8 
  ql/src/test/queries/clientpositive/smb_mapjoin_7.q bd859b7 
  ql/src/test/queries/clientpositive/smb_mapjoin_8.q dc6a35f 
  ql/src/test/queries/clientpositive/stats1.q e5133c8 
  ql/src/test/queries/clientpositive/stats11.q d037c00 
  ql/src/test/queries/clientpositive/stats18.q e773cd7 
  ql/src/test/queries/clientpositive/tez_fsstat.q 4aecd71 
  ql/src/test/queries/clientpositive/tez_smb_1.q 089ffe3 
  ql/src/test/queries/clientpositive/tez_smb_empty.q 4661ada 
  ql/src/test/queries/clientpositive/tez_smb_main.q 9ed5959 
  ql/src/test/queries/clientpositive/udaf_percentile_approx_20.q 7aae8ae 
  ql/src/test/queries/clientpositive/udaf_percentile_approx_23.q aa4a4ce 
  ql/src/test/queries/clientpositive/varchar_1.q efaf3e5 
  ql/src/test/queries/clientpositive/varchar_serde.q ea2a022 

Diff: https://reviews.apache.org/r/53659/diff/


Testing
-------


Thanks,

Sergey Shelukhin

Re: Review Request 53659: HIVE-15148 disallow loading data into bucketed tables (by default)

Posted by Lefty Leverenz <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53659/#review155771
-----------------------------------------------------------




common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 1013 - 1014)
<https://reviews.apache.org/r/53659/#comment225857>

    carterian -> Cartesian


- Lefty Leverenz


On Nov. 10, 2016, 1:27 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53659/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2016, 1:27 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 56289c9 
>   data/scripts/q_test_init.sql 0c8668c 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java a7005f1 
>   ql/src/test/queries/clientnegative/alter_concatenate_indexed_table.q 4193315 
>   ql/src/test/queries/clientnegative/bucket_mapjoin_mismatch1.q 7dce81f 
>   ql/src/test/queries/clientnegative/dynamic_partitions_with_whitelist.q 8623db8 
>   ql/src/test/queries/clientnegative/insertover_dynapart_ifnotexists.q a8f77c2 
>   ql/src/test/queries/clientpositive/alter_concatenate_indexed_table.q d2bc440 
>   ql/src/test/queries/clientpositive/alter_merge.q 0ff0294 
>   ql/src/test/queries/clientpositive/alter_merge_2.q e09703d 
>   ql/src/test/queries/clientpositive/alter_merge_stats.q 0af87e2 
>   ql/src/test/queries/clientpositive/autoColumnStats_1.q bb7252a 
>   ql/src/test/queries/clientpositive/autoColumnStats_2.q c1abcb1 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_1.q 6c2fbba 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_11.q aa345b5 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_12.q b344bd0 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_16.q 83b67f8 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_2.q 2cf809b 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_3.q b14b32b 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_4.q b08649e 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_5.q 489f556 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_7.q 161bc8a 
>   ql/src/test/queries/clientpositive/auto_sortmerge_join_8.q cc2ba28 
>   ql/src/test/queries/clientpositive/bucket_map_join_spark1.q 3f9ccc4 
>   ql/src/test/queries/clientpositive/bucket_map_join_spark2.q 4a70671 
>   ql/src/test/queries/clientpositive/bucket_map_join_spark3.q 9ae7986 
>   ql/src/test/queries/clientpositive/bucket_map_join_tez1.q ade04dd 
>   ql/src/test/queries/clientpositive/bucket_map_join_tez2.q fd997df 
>   ql/src/test/queries/clientpositive/bucketcontext_1.q ad0f473 
>   ql/src/test/queries/clientpositive/bucketcontext_2.q 931f55a 
>   ql/src/test/queries/clientpositive/bucketcontext_3.q e03b285 
>   ql/src/test/queries/clientpositive/bucketcontext_4.q af08f07 
>   ql/src/test/queries/clientpositive/bucketcontext_5.q 5078072 
>   ql/src/test/queries/clientpositive/bucketcontext_6.q 5549f3b 
>   ql/src/test/queries/clientpositive/bucketcontext_7.q 44cdb5e 
>   ql/src/test/queries/clientpositive/bucketcontext_8.q bb655e2 
>   ql/src/test/queries/clientpositive/bucketizedhiveinputformat_auto.q a2b0bbe 
>   ql/src/test/queries/clientpositive/bucketmapjoin1.q 2fd3804 
>   ql/src/test/queries/clientpositive/bucketmapjoin10.q 09c0ae2 
>   ql/src/test/queries/clientpositive/bucketmapjoin11.q d330b77 
>   ql/src/test/queries/clientpositive/bucketmapjoin12.q 43a9de4 
>   ql/src/test/queries/clientpositive/bucketmapjoin2.q d14261f 
>   ql/src/test/queries/clientpositive/bucketmapjoin3.q 78c23d5 
>   ql/src/test/queries/clientpositive/bucketmapjoin4.q 54626e7 
>   ql/src/test/queries/clientpositive/bucketmapjoin5.q 6c03bbb 
>   ql/src/test/queries/clientpositive/bucketmapjoin7.q cd4efe7 
>   ql/src/test/queries/clientpositive/bucketmapjoin8.q f467ea6 
>   ql/src/test/queries/clientpositive/bucketmapjoin9.q f1d5f58 
>   ql/src/test/queries/clientpositive/bucketmapjoin_negative.q ea140dd 
>   ql/src/test/queries/clientpositive/bucketmapjoin_negative2.q 36d34dc 
>   ql/src/test/queries/clientpositive/bucketmapjoin_negative3.q 6398fff 
>   ql/src/test/queries/clientpositive/cbo_rp_udaf_percentile_approx_23.q 0f2d0dd 
>   ql/src/test/queries/clientpositive/char_1.q e617a49 
>   ql/src/test/queries/clientpositive/char_serde.q 4340b4d 
>   ql/src/test/queries/clientpositive/create_merge_compressed.q 483931b 
>   ql/src/test/queries/clientpositive/explainanalyze_2.q 8b3df87 
>   ql/src/test/queries/clientpositive/explainanalyze_3.q 61f68a1 
>   ql/src/test/queries/clientpositive/explainuser_1.q 3791662 
>   ql/src/test/queries/clientpositive/explainuser_2.q 3f8bdb4 
>   ql/src/test/queries/clientpositive/explainuser_3.q 57029f1 
>   ql/src/test/queries/clientpositive/global_limit.q 8c5f2ea 
>   ql/src/test/queries/clientpositive/infer_bucket_sort_dyn_part.q 4937be4 
>   ql/src/test/queries/clientpositive/merge_dynamic_partition.q fa4d442 
>   ql/src/test/queries/clientpositive/merge_dynamic_partition2.q 73a71e6 
>   ql/src/test/queries/clientpositive/merge_dynamic_partition3.q 79ae2b9 
>   ql/src/test/queries/clientpositive/merge_dynamic_partition4.q 33388c6 
>   ql/src/test/queries/clientpositive/merge_dynamic_partition5.q 9a35101 
>   ql/src/test/queries/clientpositive/mergejoin.q fa53a76 
>   ql/src/test/queries/clientpositive/smb_mapjoin_1.q 4f913e7 
>   ql/src/test/queries/clientpositive/smb_mapjoin_10.q 1fbe209 
>   ql/src/test/queries/clientpositive/smb_mapjoin_2.q 5e729d9 
>   ql/src/test/queries/clientpositive/smb_mapjoin_25.q 834d44c 
>   ql/src/test/queries/clientpositive/smb_mapjoin_3.q 549eb85 
>   ql/src/test/queries/clientpositive/smb_mapjoin_4.q e9d28ba 
>   ql/src/test/queries/clientpositive/smb_mapjoin_5.q 5b6eeb8 
>   ql/src/test/queries/clientpositive/smb_mapjoin_7.q bd859b7 
>   ql/src/test/queries/clientpositive/smb_mapjoin_8.q dc6a35f 
>   ql/src/test/queries/clientpositive/stats1.q e5133c8 
>   ql/src/test/queries/clientpositive/stats11.q d037c00 
>   ql/src/test/queries/clientpositive/stats18.q e773cd7 
>   ql/src/test/queries/clientpositive/tez_fsstat.q 4aecd71 
>   ql/src/test/queries/clientpositive/tez_smb_1.q 089ffe3 
>   ql/src/test/queries/clientpositive/tez_smb_empty.q 4661ada 
>   ql/src/test/queries/clientpositive/tez_smb_main.q 9ed5959 
>   ql/src/test/queries/clientpositive/udaf_percentile_approx_20.q 7aae8ae 
>   ql/src/test/queries/clientpositive/udaf_percentile_approx_23.q aa4a4ce 
>   ql/src/test/queries/clientpositive/varchar_1.q efaf3e5 
>   ql/src/test/queries/clientpositive/varchar_serde.q ea2a022 
> 
> Diff: https://reviews.apache.org/r/53659/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>