You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Alan Gates (JIRA)" <ji...@apache.org> on 2012/09/27 18:52:07 UTC
[jira] [Created] (PIG-2935) Catch NoSuchMethodError when
StoreFuncInterface's new cleanupOnSuccess method isn't implemented.
Alan Gates created PIG-2935:
-------------------------------
Summary: Catch NoSuchMethodError when StoreFuncInterface's new cleanupOnSuccess method isn't implemented.
Key: PIG-2935
URL: https://issues.apache.org/jira/browse/PIG-2935
Project: Pig
Issue Type: Bug
Components: impl
Affects Versions: 0.11
Reporter: Alan Gates
Assignee: Alan Gates
Priority: Critical
Fix For: 0.11
We should catch a NoSuchMethodError here so that old implementations of StoreFuncInterface still work. This will still be incompatible for people who re-compile their store functions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2935) Catch NoSuchMethodError when
StoreFuncInterface's new cleanupOnSuccess method isn't implemented.
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465086#comment-13465086 ]
Dmitriy V. Ryaboy commented on PIG-2935:
----------------------------------------
I would guess those are problems (one way to find out..).
I know for sure that the AME is what gets thrown in this case, cause that's what we saw when running an existing ElephantBird storefunc implementation with trunk.
> Catch NoSuchMethodError when StoreFuncInterface's new cleanupOnSuccess method isn't implemented.
> ------------------------------------------------------------------------------------------------
>
> Key: PIG-2935
> URL: https://issues.apache.org/jira/browse/PIG-2935
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.11
> Reporter: Alan Gates
> Assignee: Alan Gates
> Priority: Critical
> Fix For: 0.11
>
> Attachments: PIG-2935.patch
>
>
> We should catch a NoSuchMethodError here so that old implementations of StoreFuncInterface still work. This will still be incompatible for people who re-compile their store functions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2935) Catch NoSuchMethodError when
StoreFuncInterface's new cleanupOnSuccess method isn't implemented.
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465081#comment-13465081 ]
Alan Gates commented on PIG-2935:
---------------------------------
Hmm, that's interesting, because there are other places where we catch NoSuchMethodError and it seems to be the same situation. Checkout SyncProgressNotificationAdaptor.initialPlanNotification() and ScriptState.emitInitialPlanNotification(). Are these errors or is something different happening here? But I can change the patch to catch the right error.
> Catch NoSuchMethodError when StoreFuncInterface's new cleanupOnSuccess method isn't implemented.
> ------------------------------------------------------------------------------------------------
>
> Key: PIG-2935
> URL: https://issues.apache.org/jira/browse/PIG-2935
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.11
> Reporter: Alan Gates
> Assignee: Alan Gates
> Priority: Critical
> Fix For: 0.11
>
> Attachments: PIG-2935.patch
>
>
> We should catch a NoSuchMethodError here so that old implementations of StoreFuncInterface still work. This will still be incompatible for people who re-compile their store functions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2935) Catch NoSuchMethodError when
StoreFuncInterface's new cleanupOnSuccess method isn't implemented.
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467842#comment-13467842 ]
Alan Gates commented on PIG-2935:
---------------------------------
+1.
> Catch NoSuchMethodError when StoreFuncInterface's new cleanupOnSuccess method isn't implemented.
> ------------------------------------------------------------------------------------------------
>
> Key: PIG-2935
> URL: https://issues.apache.org/jira/browse/PIG-2935
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.11
> Reporter: Alan Gates
> Assignee: Alan Gates
> Priority: Critical
> Fix For: 0.11
>
> Attachments: PIG-2935.2.patch, PIG-2935.patch
>
>
> We should catch a NoSuchMethodError here so that old implementations of StoreFuncInterface still work. This will still be incompatible for people who re-compile their store functions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2935) Catch NoSuchMethodError when
StoreFuncInterface's new cleanupOnSuccess method isn't implemented.
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-2935:
-----------------------------------
Attachment: PIG-2935.2.patch
same, but with the right method being caught.
> Catch NoSuchMethodError when StoreFuncInterface's new cleanupOnSuccess method isn't implemented.
> ------------------------------------------------------------------------------------------------
>
> Key: PIG-2935
> URL: https://issues.apache.org/jira/browse/PIG-2935
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.11
> Reporter: Alan Gates
> Assignee: Alan Gates
> Priority: Critical
> Fix For: 0.11
>
> Attachments: PIG-2935.2.patch, PIG-2935.patch
>
>
> We should catch a NoSuchMethodError here so that old implementations of StoreFuncInterface still work. This will still be incompatible for people who re-compile their store functions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2935) Catch NoSuchMethodError when
StoreFuncInterface's new cleanupOnSuccess method isn't implemented.
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-2935:
-----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to trunk.
> Catch NoSuchMethodError when StoreFuncInterface's new cleanupOnSuccess method isn't implemented.
> ------------------------------------------------------------------------------------------------
>
> Key: PIG-2935
> URL: https://issues.apache.org/jira/browse/PIG-2935
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.11
> Reporter: Alan Gates
> Assignee: Alan Gates
> Priority: Critical
> Fix For: 0.11
>
> Attachments: PIG-2935.2.patch, PIG-2935.patch
>
>
> We should catch a NoSuchMethodError here so that old implementations of StoreFuncInterface still work. This will still be incompatible for people who re-compile their store functions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2935) Catch NoSuchMethodError when
StoreFuncInterface's new cleanupOnSuccess method isn't implemented.
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Gates updated PIG-2935:
----------------------------
Attachment: PIG-2935.patch
> Catch NoSuchMethodError when StoreFuncInterface's new cleanupOnSuccess method isn't implemented.
> ------------------------------------------------------------------------------------------------
>
> Key: PIG-2935
> URL: https://issues.apache.org/jira/browse/PIG-2935
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.11
> Reporter: Alan Gates
> Assignee: Alan Gates
> Priority: Critical
> Fix For: 0.11
>
> Attachments: PIG-2935.patch
>
>
> We should catch a NoSuchMethodError here so that old implementations of StoreFuncInterface still work. This will still be incompatible for people who re-compile their store functions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2935) Catch NoSuchMethodError when
StoreFuncInterface's new cleanupOnSuccess method isn't implemented.
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-2935:
-----------------------------------
Status: Patch Available (was: Open)
Alan, quick sanity check?
> Catch NoSuchMethodError when StoreFuncInterface's new cleanupOnSuccess method isn't implemented.
> ------------------------------------------------------------------------------------------------
>
> Key: PIG-2935
> URL: https://issues.apache.org/jira/browse/PIG-2935
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.11
> Reporter: Alan Gates
> Assignee: Alan Gates
> Priority: Critical
> Fix For: 0.11
>
> Attachments: PIG-2935.2.patch, PIG-2935.patch
>
>
> We should catch a NoSuchMethodError here so that old implementations of StoreFuncInterface still work. This will still be incompatible for people who re-compile their store functions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2935) Catch NoSuchMethodError when
StoreFuncInterface's new cleanupOnSuccess method isn't implemented.
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465006#comment-13465006 ]
Dmitriy V. Ryaboy commented on PIG-2935:
----------------------------------------
Alan, that won't work -- the error thrown is not NoSuchMethod, but AbstractMethodError (the abstract method is declared in the new interface, so the method exists, but has no implementation). These are both children of IncompatibleClassChangeError , which would capture the case of somehow using the new PigServer but the old StoreFuncInterface, though that's probably overkill (I don't know how one would get into such a bind).
> Catch NoSuchMethodError when StoreFuncInterface's new cleanupOnSuccess method isn't implemented.
> ------------------------------------------------------------------------------------------------
>
> Key: PIG-2935
> URL: https://issues.apache.org/jira/browse/PIG-2935
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.11
> Reporter: Alan Gates
> Assignee: Alan Gates
> Priority: Critical
> Fix For: 0.11
>
> Attachments: PIG-2935.patch
>
>
> We should catch a NoSuchMethodError here so that old implementations of StoreFuncInterface still work. This will still be incompatible for people who re-compile their store functions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira