You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Zhenya Stanilovsky <ar...@mail.ru.INVALID> on 2022/08/30 17:35:19 UTC
Apache calcite dependency update issue.
Igniters, i found that new release of apache calcite was released (1.31) [1]. This release contains great improvement [2] which makes possible to resolve [3], but also contains a bug [4] with natural join validation (possibly not one, but apache ignite sql test suite highlight only this one). I tried to override such a validation in IgniteSqlValidator but seems there are lot of custom private stuff, so i failed here.
I don`t have my own opinion here, so we can:
* update calcite version, mute test under calcite issue and wait new calcite release.
* do nothing and just wait new calcite version.
What do you think ?
Thanks !
[1] https://calcite.apache.org/docs/history.html#v1-31-0
[2] https://issues.apache.org/jira/browse/CALCITE-4913
[3] https://issues.apache.org/jira/browse/IGNITE-16040
[4] https://issues.apache.org/jira/browse/CALCITE-5253
Re[2]: Apache calcite dependency update issue.
Posted by Zhenya Stanilovsky <ar...@mail.ru.INVALID>.
Hello, i plan to proceed with CALCITE-5253 soon.
Great, lets move forward with new ver.
>Hello!
>
>Apache Calcite 1.32 is already released, but [1] is still not resolved.
>I propose not to wait for this ticket. "NATURAL JOIN" is a relatively rare
>case, I think we can live with it for a while. Other improvements
>look more valuable.
>I've prepared a ticket to upgrade Apache Calcite dependency [2], if there
>are no objections, I will merge it soon.
>
>[1]: https://issues.apache.org/jira/browse/CALCITE-5253
>[2]: https://issues.apache.org/jira/browse/IGNITE-17722
>
>ср, 31 авг. 2022 г. в 08:10, Ivan Daschinsky < ivandasch@gmail.com >:
>
>> Oh, sorry, I see that it has been alredy reported. So let us wait for a bug
>> fix.
>>
>> ср, 31 авг. 2022 г., 08:10 Ivan Daschinsky < ivandasch@gmail.com >:
>>
>> > I suppose that we are not in rush, because we have just cut off a release
>> > branch for 2.14. Let us wait for a new release of Calcite. By the way,
>> has
>> > that bug been already reported?
>> >
>> > вт, 30 авг. 2022 г., 20:35 Zhenya Stanilovsky < arzamas123@mail.ru.invalid
>> > >:
>> >
>> >>
>> >> Igniters, i found that new release of apache calcite was released (1.31)
>> >> [1]. This release contains great improvement [2] which makes possible to
>> >> resolve [3], but also contains a bug [4] with natural join validation
>> >> (possibly not one, but apache ignite sql test suite highlight only this
>> >> one). I tried to override such a validation in IgniteSqlValidator but
>> seems
>> >> there are lot of custom private stuff, so i failed here.
>> >> I don`t have my own opinion here, so we can:
>> >> * update calcite version, mute test under calcite issue and wait new
>> >> calcite release.
>> >> * do nothing and just wait new calcite version.
>> >> What do you think ?
>> >> Thanks !
>> >>
>> >> [1] https://calcite.apache.org/docs/history.html#v1-31-0
>> >> [2] https://issues.apache.org/jira/browse/CALCITE-4913
>> >> [3] https://issues.apache.org/jira/browse/IGNITE-16040
>> >> [4] https://issues.apache.org/jira/browse/CALCITE-5253
>> >>
>> >>
>> >>
>> >
>> >
>>
Re: Apache calcite dependency update issue.
Posted by Alex Plehanov <pl...@gmail.com>.
Hello!
Apache Calcite 1.32 is already released, but [1] is still not resolved.
I propose not to wait for this ticket. "NATURAL JOIN" is a relatively rare
case, I think we can live with it for a while. Other improvements
look more valuable.
I've prepared a ticket to upgrade Apache Calcite dependency [2], if there
are no objections, I will merge it soon.
[1]: https://issues.apache.org/jira/browse/CALCITE-5253
[2]: https://issues.apache.org/jira/browse/IGNITE-17722
ср, 31 авг. 2022 г. в 08:10, Ivan Daschinsky <iv...@gmail.com>:
> Oh, sorry, I see that it has been alredy reported. So let us wait for a bug
> fix.
>
> ср, 31 авг. 2022 г., 08:10 Ivan Daschinsky <iv...@gmail.com>:
>
> > I suppose that we are not in rush, because we have just cut off a release
> > branch for 2.14. Let us wait for a new release of Calcite. By the way,
> has
> > that bug been already reported?
> >
> > вт, 30 авг. 2022 г., 20:35 Zhenya Stanilovsky <arzamas123@mail.ru.invalid
> > >:
> >
> >>
> >> Igniters, i found that new release of apache calcite was released (1.31)
> >> [1]. This release contains great improvement [2] which makes possible to
> >> resolve [3], but also contains a bug [4] with natural join validation
> >> (possibly not one, but apache ignite sql test suite highlight only this
> >> one). I tried to override such a validation in IgniteSqlValidator but
> seems
> >> there are lot of custom private stuff, so i failed here.
> >> I don`t have my own opinion here, so we can:
> >> * update calcite version, mute test under calcite issue and wait new
> >> calcite release.
> >> * do nothing and just wait new calcite version.
> >> What do you think ?
> >> Thanks !
> >>
> >> [1] https://calcite.apache.org/docs/history.html#v1-31-0
> >> [2] https://issues.apache.org/jira/browse/CALCITE-4913
> >> [3] https://issues.apache.org/jira/browse/IGNITE-16040
> >> [4] https://issues.apache.org/jira/browse/CALCITE-5253
> >>
> >>
> >>
> >
> >
>
Re: Apache calcite dependency update issue.
Posted by Ivan Daschinsky <iv...@gmail.com>.
Oh, sorry, I see that it has been alredy reported. So let us wait for a bug
fix.
ср, 31 авг. 2022 г., 08:10 Ivan Daschinsky <iv...@gmail.com>:
> I suppose that we are not in rush, because we have just cut off a release
> branch for 2.14. Let us wait for a new release of Calcite. By the way, has
> that bug been already reported?
>
> вт, 30 авг. 2022 г., 20:35 Zhenya Stanilovsky <arzamas123@mail.ru.invalid
> >:
>
>>
>> Igniters, i found that new release of apache calcite was released (1.31)
>> [1]. This release contains great improvement [2] which makes possible to
>> resolve [3], but also contains a bug [4] with natural join validation
>> (possibly not one, but apache ignite sql test suite highlight only this
>> one). I tried to override such a validation in IgniteSqlValidator but seems
>> there are lot of custom private stuff, so i failed here.
>> I don`t have my own opinion here, so we can:
>> * update calcite version, mute test under calcite issue and wait new
>> calcite release.
>> * do nothing and just wait new calcite version.
>> What do you think ?
>> Thanks !
>>
>> [1] https://calcite.apache.org/docs/history.html#v1-31-0
>> [2] https://issues.apache.org/jira/browse/CALCITE-4913
>> [3] https://issues.apache.org/jira/browse/IGNITE-16040
>> [4] https://issues.apache.org/jira/browse/CALCITE-5253
>>
>>
>>
>
>
Re: Apache calcite dependency update issue.
Posted by Ivan Daschinsky <iv...@gmail.com>.
I suppose that we are not in rush, because we have just cut off a release
branch for 2.14. Let us wait for a new release of Calcite. By the way, has
that bug been already reported?
вт, 30 авг. 2022 г., 20:35 Zhenya Stanilovsky <ar...@mail.ru.invalid>:
>
> Igniters, i found that new release of apache calcite was released (1.31)
> [1]. This release contains great improvement [2] which makes possible to
> resolve [3], but also contains a bug [4] with natural join validation
> (possibly not one, but apache ignite sql test suite highlight only this
> one). I tried to override such a validation in IgniteSqlValidator but seems
> there are lot of custom private stuff, so i failed here.
> I don`t have my own opinion here, so we can:
> * update calcite version, mute test under calcite issue and wait new
> calcite release.
> * do nothing and just wait new calcite version.
> What do you think ?
> Thanks !
>
> [1] https://calcite.apache.org/docs/history.html#v1-31-0
> [2] https://issues.apache.org/jira/browse/CALCITE-4913
> [3] https://issues.apache.org/jira/browse/IGNITE-16040
> [4] https://issues.apache.org/jira/browse/CALCITE-5253
>
>
>