You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by ginobiliwang <gi...@git.apache.org> on 2018/08/28 01:25:56 UTC
[GitHub] incubator-hawq pull request #1395: fix issue HAWQ-1656 by hardcode installat...
GitHub user ginobiliwang opened a pull request:
https://github.com/apache/incubator-hawq/pull/1395
fix issue HAWQ-1656 by hardcode installation procedure for bison
This PR is to fix issue
https://issues.apache.org/jira/browse/HAWQ-1656
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ginobiliwang/incubator-hawq HAWQ-1656
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1395.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1395
----
commit 79671709a323a3c09e194958c61a3795bbfddb11
Author: Fenggang <gi...@...>
Date: 2018-08-28T00:56:52Z
fix issue HAWQ-1656 by hardcode installation procedure for bison
----
---
[GitHub] incubator-hawq issue #1395: fix issue HAWQ-1656 by hardcode installation pro...
Posted by eschizoid <gi...@git.apache.org>.
Github user eschizoid commented on the issue:
https://github.com/apache/incubator-hawq/pull/1395
any idea when this will be merged down?
---
[GitHub] incubator-hawq issue #1395: fix issue HAWQ-1656 by hardcode installation pro...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the issue:
https://github.com/apache/incubator-hawq/pull/1395
@eschizoid This already been merged to master, please check.
---
[GitHub] incubator-hawq issue #1395: fix issue HAWQ-1656 by hardcode installation pro...
Posted by benchristel <gi...@git.apache.org>.
Github user benchristel commented on the issue:
https://github.com/apache/incubator-hawq/pull/1395
Since this has already been merged, can someone with commit access close this PR please? @lavjain?
---
[GitHub] incubator-hawq pull request #1395: fix issue HAWQ-1656 by hardcode installat...
Posted by ginobiliwang <gi...@git.apache.org>.
Github user ginobiliwang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1395#discussion_r213283137
--- Diff: configure ---
@@ -7435,14 +7435,14 @@ if test "$BISON"; then
pgac_bison_version=`$BISON --version 2>/dev/null | sed q`
{ $as_echo "$as_me:${as_lineno-$LINENO}: using $pgac_bison_version" >&5
$as_echo "$as_me: using $pgac_bison_version" >&6;}
- if echo "$pgac_bison_version" | $AWK '{ if ($4 < 1.875) exit 0; else exit 1;}'
+ if echo "$pgac_bison_version" | $AWK '{ if ($4 < 1.875 && $4 > 2.9) exit 0; else exit 1;}'
--- End diff --
fixed in the new commit
---
[GitHub] incubator-hawq pull request #1395: fix issue HAWQ-1656 by hardcode installat...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1395#discussion_r213173453
--- Diff: configure ---
@@ -7435,14 +7435,14 @@ if test "$BISON"; then
pgac_bison_version=`$BISON --version 2>/dev/null | sed q`
{ $as_echo "$as_me:${as_lineno-$LINENO}: using $pgac_bison_version" >&5
$as_echo "$as_me: using $pgac_bison_version" >&6;}
- if echo "$pgac_bison_version" | $AWK '{ if ($4 < 1.875) exit 0; else exit 1;}'
+ if echo "$pgac_bison_version" | $AWK '{ if ($4 < 1.875 && $4 > 2.9) exit 0; else exit 1;}'
--- End diff --
We should modify configure.in instead of configure, then generate new configure with configure.in.
---
[GitHub] incubator-hawq issue #1395: fix issue HAWQ-1656 by hardcode installation pro...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the issue:
https://github.com/apache/incubator-hawq/pull/1395
+1
---
[GitHub] incubator-hawq issue #1395: fix issue HAWQ-1656 by hardcode installation pro...
Posted by lavjain <gi...@git.apache.org>.
Github user lavjain commented on the issue:
https://github.com/apache/incubator-hawq/pull/1395
@ginobiliwang Please close this PR as only the person who opened the request can close it.
---
[GitHub] incubator-hawq issue #1395: fix issue HAWQ-1656 by hardcode installation pro...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the issue:
https://github.com/apache/incubator-hawq/pull/1395
LGTM +1
---