You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@vxquery.apache.org by Menaka Madushanka <me...@gmail.com> on 2016/05/12 11:45:32 UTC

XQTS file sorter implementation. https://issues.apache.org/jira/browse/VXQUERY-191

Hello,

I implemented the file sorter for xqts.
I followed the Option 1 stated in the issue description.
The output file is attached herewith.

Thank you very muh
Menaka

-- 
*Menaka Madushanka Jayawardena*
Faculty of Engineering, <http://www.pdn.ac.lk/eng>
University of Peradeniyaya.
LinkedIn <http://lk.linkedin.com/in/menakajayawardena>
TP:- 071 885 1183/ 071 350 5470

Re: XQTS file sorter implementation. https://issues.apache.org/jira/browse/VXQUERY-191

Posted by Menaka Madushanka <me...@gmail.com>.

Thank you very much.
:-)

Menaka

On 19 May 2016 at 02:35, Steven Jacobs <sj...@ucr.edu> wrote:

> We merged this into master.
> We gave you credit in the commit message :)
> Steven
>
> On Wed, May 18, 2016 at 12:47 AM, Menaka Madushanka <menaka12350@gmail.com
> >
> wrote:
>
> > File sorter moved to LineFileReporterImpl
> >
> > On 18 May 2016 at 04:53, Steven Jacobs <sj...@ucr.edu> wrote:
> >
> > > Hi Menaka,
> > > looks great! We added two last comments.
> > > Steven
> > >
> > > On Tue, May 17, 2016 at 2:17 PM, Menaka Madushanka <
> > menaka12350@gmail.com>
> > > wrote:
> > >
> > > > Hello Preston,
> > > >
> > > > I modified the code according to the comments.
> > > > 1. Removed System.outs and replaced with Logger
> > > > 2. Modified the erasefile method to delete the file.
> > > > 3. Removed unnecessary instances of PrintWriter,
> > > >
> > > > Please review.
> > > >
> > > > Thank you very much
> > > > Menaka
> > > >
> > > > On 17 May 2016 at 03:49, Menaka Madushanka <me...@gmail.com>
> > > wrote:
> > > >
> > > > > Thank you very much Preston.
> > > > > I'll look on to it.
> > > > >
> > > > > Menaka
> > > > >
> > > > > On 17 May 2016 at 03:37, Preston Carman <pr...@apache.org>
> wrote:
> > > > >
> > > > >> Hi Menaka,
> > > > >>
> > > > >> We have added a few comments to your code review. It looks good
> and
> > we
> > > > >> only have a few comments.
> > > > >>
> > > > >> Preston
> > > > >>
> > > > >> On Thu, May 12, 2016 at 4:47 AM, Menaka Madushanka
> > > > >> <me...@gmail.com> wrote:
> > > > >> > And I have sent a pull request
> > > > >> https://github.com/apache/vxquery/pull/34
> > > > >> >
> > > > >> > On 12 May 2016 at 17:15, Menaka Madushanka <
> menaka12350@gmail.com
> > >
> > > > >> wrote:
> > > > >> >>
> > > > >> >> Hello,
> > > > >> >>
> > > > >> >> I implemented the file sorter for xqts.
> > > > >> >> I followed the Option 1 stated in the issue description.
> > > > >> >> The output file is attached herewith.
> > > > >> >>
> > > > >> >> Thank you very muh
> > > > >> >> Menaka
> > > > >> >>
> > > > >> >> --
> > > > >> >> Menaka Madushanka Jayawardena
> > > > >> >> Faculty of Engineering,
> > > > >> >> University of Peradeniyaya.
> > > > >> >> LinkedIn
> > > > >> >> TP:- 071 885 1183/ 071 350 5470
> > > > >> >
> > > > >> >
> > > > >> >
> > > > >> >
> > > > >> > --
> > > > >> > Menaka Madushanka Jayawardena
> > > > >> > Faculty of Engineering,
> > > > >> > University of Peradeniyaya.
> > > > >> > LinkedIn
> > > > >> > TP:- 071 885 1183/ 071 350 5470
> > > > >>
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > *Menaka Madushanka Jayawardena*
> > > > > Faculty of Engineering, <http://www.pdn.ac.lk/eng>
> > > > > University of Peradeniyaya.
> > > > > LinkedIn <http://lk.linkedin.com/in/menakajayawardena>
> > > > > TP:- 071 885 1183/ 071 350 5470
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > *Menaka Madushanka Jayawardena*
> > > > Faculty of Engineering, <http://www.pdn.ac.lk/eng>
> > > > University of Peradeniyaya.
> > > > LinkedIn <http://lk.linkedin.com/in/menakajayawardena>
> > > > TP:- 071 885 1183/ 071 350 5470
> > > >
> > >
> >
> >
> >
> > --
> > *Menaka Madushanka Jayawardena*
> > Faculty of Engineering, <http://www.pdn.ac.lk/eng>
> > University of Peradeniyaya.
> > LinkedIn <http://lk.linkedin.com/in/menakajayawardena>
> > TP:- 071 885 1183/ 071 350 5470
> >
>



-- 
*Menaka Madushanka Jayawardena*
Faculty of Engineering, <http://www.pdn.ac.lk/eng>
University of Peradeniyaya.
LinkedIn <http://lk.linkedin.com/in/menakajayawardena>
TP:- 071 885 1183/ 071 350 5470

Re: XQTS file sorter implementation. https://issues.apache.org/jira/browse/VXQUERY-191

Posted by Steven Jacobs <sj...@ucr.edu>.

We merged this into master.
We gave you credit in the commit message :)
Steven

On Wed, May 18, 2016 at 12:47 AM, Menaka Madushanka <me...@gmail.com>
wrote:

> File sorter moved to LineFileReporterImpl
>
> On 18 May 2016 at 04:53, Steven Jacobs <sj...@ucr.edu> wrote:
>
> > Hi Menaka,
> > looks great! We added two last comments.
> > Steven
> >
> > On Tue, May 17, 2016 at 2:17 PM, Menaka Madushanka <
> menaka12350@gmail.com>
> > wrote:
> >
> > > Hello Preston,
> > >
> > > I modified the code according to the comments.
> > > 1. Removed System.outs and replaced with Logger
> > > 2. Modified the erasefile method to delete the file.
> > > 3. Removed unnecessary instances of PrintWriter,
> > >
> > > Please review.
> > >
> > > Thank you very much
> > > Menaka
> > >
> > > On 17 May 2016 at 03:49, Menaka Madushanka <me...@gmail.com>
> > wrote:
> > >
> > > > Thank you very much Preston.
> > > > I'll look on to it.
> > > >
> > > > Menaka
> > > >
> > > > On 17 May 2016 at 03:37, Preston Carman <pr...@apache.org> wrote:
> > > >
> > > >> Hi Menaka,
> > > >>
> > > >> We have added a few comments to your code review. It looks good and
> we
> > > >> only have a few comments.
> > > >>
> > > >> Preston
> > > >>
> > > >> On Thu, May 12, 2016 at 4:47 AM, Menaka Madushanka
> > > >> <me...@gmail.com> wrote:
> > > >> > And I have sent a pull request
> > > >> https://github.com/apache/vxquery/pull/34
> > > >> >
> > > >> > On 12 May 2016 at 17:15, Menaka Madushanka <menaka12350@gmail.com
> >
> > > >> wrote:
> > > >> >>
> > > >> >> Hello,
> > > >> >>
> > > >> >> I implemented the file sorter for xqts.
> > > >> >> I followed the Option 1 stated in the issue description.
> > > >> >> The output file is attached herewith.
> > > >> >>
> > > >> >> Thank you very muh
> > > >> >> Menaka
> > > >> >>
> > > >> >> --
> > > >> >> Menaka Madushanka Jayawardena
> > > >> >> Faculty of Engineering,
> > > >> >> University of Peradeniyaya.
> > > >> >> LinkedIn
> > > >> >> TP:- 071 885 1183/ 071 350 5470
> > > >> >
> > > >> >
> > > >> >
> > > >> >
> > > >> > --
> > > >> > Menaka Madushanka Jayawardena
> > > >> > Faculty of Engineering,
> > > >> > University of Peradeniyaya.
> > > >> > LinkedIn
> > > >> > TP:- 071 885 1183/ 071 350 5470
> > > >>
> > > >
> > > >
> > > >
> > > > --
> > > > *Menaka Madushanka Jayawardena*
> > > > Faculty of Engineering, <http://www.pdn.ac.lk/eng>
> > > > University of Peradeniyaya.
> > > > LinkedIn <http://lk.linkedin.com/in/menakajayawardena>
> > > > TP:- 071 885 1183/ 071 350 5470
> > > >
> > >
> > >
> > >
> > > --
> > > *Menaka Madushanka Jayawardena*
> > > Faculty of Engineering, <http://www.pdn.ac.lk/eng>
> > > University of Peradeniyaya.
> > > LinkedIn <http://lk.linkedin.com/in/menakajayawardena>
> > > TP:- 071 885 1183/ 071 350 5470
> > >
> >
>
>
>
> --
> *Menaka Madushanka Jayawardena*
> Faculty of Engineering, <http://www.pdn.ac.lk/eng>
> University of Peradeniyaya.
> LinkedIn <http://lk.linkedin.com/in/menakajayawardena>
> TP:- 071 885 1183/ 071 350 5470
>

Re: XQTS file sorter implementation. https://issues.apache.org/jira/browse/VXQUERY-191

Posted by Menaka Madushanka <me...@gmail.com>.

File sorter moved to LineFileReporterImpl

On 18 May 2016 at 04:53, Steven Jacobs <sj...@ucr.edu> wrote:

> Hi Menaka,
> looks great! We added two last comments.
> Steven
>
> On Tue, May 17, 2016 at 2:17 PM, Menaka Madushanka <me...@gmail.com>
> wrote:
>
> > Hello Preston,
> >
> > I modified the code according to the comments.
> > 1. Removed System.outs and replaced with Logger
> > 2. Modified the erasefile method to delete the file.
> > 3. Removed unnecessary instances of PrintWriter,
> >
> > Please review.
> >
> > Thank you very much
> > Menaka
> >
> > On 17 May 2016 at 03:49, Menaka Madushanka <me...@gmail.com>
> wrote:
> >
> > > Thank you very much Preston.
> > > I'll look on to it.
> > >
> > > Menaka
> > >
> > > On 17 May 2016 at 03:37, Preston Carman <pr...@apache.org> wrote:
> > >
> > >> Hi Menaka,
> > >>
> > >> We have added a few comments to your code review. It looks good and we
> > >> only have a few comments.
> > >>
> > >> Preston
> > >>
> > >> On Thu, May 12, 2016 at 4:47 AM, Menaka Madushanka
> > >> <me...@gmail.com> wrote:
> > >> > And I have sent a pull request
> > >> https://github.com/apache/vxquery/pull/34
> > >> >
> > >> > On 12 May 2016 at 17:15, Menaka Madushanka <me...@gmail.com>
> > >> wrote:
> > >> >>
> > >> >> Hello,
> > >> >>
> > >> >> I implemented the file sorter for xqts.
> > >> >> I followed the Option 1 stated in the issue description.
> > >> >> The output file is attached herewith.
> > >> >>
> > >> >> Thank you very muh
> > >> >> Menaka
> > >> >>
> > >> >> --
> > >> >> Menaka Madushanka Jayawardena
> > >> >> Faculty of Engineering,
> > >> >> University of Peradeniyaya.
> > >> >> LinkedIn
> > >> >> TP:- 071 885 1183/ 071 350 5470
> > >> >
> > >> >
> > >> >
> > >> >
> > >> > --
> > >> > Menaka Madushanka Jayawardena
> > >> > Faculty of Engineering,
> > >> > University of Peradeniyaya.
> > >> > LinkedIn
> > >> > TP:- 071 885 1183/ 071 350 5470
> > >>
> > >
> > >
> > >
> > > --
> > > *Menaka Madushanka Jayawardena*
> > > Faculty of Engineering, <http://www.pdn.ac.lk/eng>
> > > University of Peradeniyaya.
> > > LinkedIn <http://lk.linkedin.com/in/menakajayawardena>
> > > TP:- 071 885 1183/ 071 350 5470
> > >
> >
> >
> >
> > --
> > *Menaka Madushanka Jayawardena*
> > Faculty of Engineering, <http://www.pdn.ac.lk/eng>
> > University of Peradeniyaya.
> > LinkedIn <http://lk.linkedin.com/in/menakajayawardena>
> > TP:- 071 885 1183/ 071 350 5470
> >
>



-- 
*Menaka Madushanka Jayawardena*
Faculty of Engineering, <http://www.pdn.ac.lk/eng>
University of Peradeniyaya.
LinkedIn <http://lk.linkedin.com/in/menakajayawardena>
TP:- 071 885 1183/ 071 350 5470

Re: XQTS file sorter implementation. https://issues.apache.org/jira/browse/VXQUERY-191

Posted by Steven Jacobs <sj...@ucr.edu>.

Hi Menaka,
looks great! We added two last comments.
Steven

On Tue, May 17, 2016 at 2:17 PM, Menaka Madushanka <me...@gmail.com>
wrote:

> Hello Preston,
>
> I modified the code according to the comments.
> 1. Removed System.outs and replaced with Logger
> 2. Modified the erasefile method to delete the file.
> 3. Removed unnecessary instances of PrintWriter,
>
> Please review.
>
> Thank you very much
> Menaka
>
> On 17 May 2016 at 03:49, Menaka Madushanka <me...@gmail.com> wrote:
>
> > Thank you very much Preston.
> > I'll look on to it.
> >
> > Menaka
> >
> > On 17 May 2016 at 03:37, Preston Carman <pr...@apache.org> wrote:
> >
> >> Hi Menaka,
> >>
> >> We have added a few comments to your code review. It looks good and we
> >> only have a few comments.
> >>
> >> Preston
> >>
> >> On Thu, May 12, 2016 at 4:47 AM, Menaka Madushanka
> >> <me...@gmail.com> wrote:
> >> > And I have sent a pull request
> >> https://github.com/apache/vxquery/pull/34
> >> >
> >> > On 12 May 2016 at 17:15, Menaka Madushanka <me...@gmail.com>
> >> wrote:
> >> >>
> >> >> Hello,
> >> >>
> >> >> I implemented the file sorter for xqts.
> >> >> I followed the Option 1 stated in the issue description.
> >> >> The output file is attached herewith.
> >> >>
> >> >> Thank you very muh
> >> >> Menaka
> >> >>
> >> >> --
> >> >> Menaka Madushanka Jayawardena
> >> >> Faculty of Engineering,
> >> >> University of Peradeniyaya.
> >> >> LinkedIn
> >> >> TP:- 071 885 1183/ 071 350 5470
> >> >
> >> >
> >> >
> >> >
> >> > --
> >> > Menaka Madushanka Jayawardena
> >> > Faculty of Engineering,
> >> > University of Peradeniyaya.
> >> > LinkedIn
> >> > TP:- 071 885 1183/ 071 350 5470
> >>
> >
> >
> >
> > --
> > *Menaka Madushanka Jayawardena*
> > Faculty of Engineering, <http://www.pdn.ac.lk/eng>
> > University of Peradeniyaya.
> > LinkedIn <http://lk.linkedin.com/in/menakajayawardena>
> > TP:- 071 885 1183/ 071 350 5470
> >
>
>
>
> --
> *Menaka Madushanka Jayawardena*
> Faculty of Engineering, <http://www.pdn.ac.lk/eng>
> University of Peradeniyaya.
> LinkedIn <http://lk.linkedin.com/in/menakajayawardena>
> TP:- 071 885 1183/ 071 350 5470
>

Re: XQTS file sorter implementation. https://issues.apache.org/jira/browse/VXQUERY-191

Posted by Menaka Madushanka <me...@gmail.com>.

Hello Preston,

I modified the code according to the comments.
1. Removed System.outs and replaced with Logger
2. Modified the erasefile method to delete the file.
3. Removed unnecessary instances of PrintWriter,

Please review.

Thank you very much
Menaka

On 17 May 2016 at 03:49, Menaka Madushanka <me...@gmail.com> wrote:

> Thank you very much Preston.
> I'll look on to it.
>
> Menaka
>
> On 17 May 2016 at 03:37, Preston Carman <pr...@apache.org> wrote:
>
>> Hi Menaka,
>>
>> We have added a few comments to your code review. It looks good and we
>> only have a few comments.
>>
>> Preston
>>
>> On Thu, May 12, 2016 at 4:47 AM, Menaka Madushanka
>> <me...@gmail.com> wrote:
>> > And I have sent a pull request
>> https://github.com/apache/vxquery/pull/34
>> >
>> > On 12 May 2016 at 17:15, Menaka Madushanka <me...@gmail.com>
>> wrote:
>> >>
>> >> Hello,
>> >>
>> >> I implemented the file sorter for xqts.
>> >> I followed the Option 1 stated in the issue description.
>> >> The output file is attached herewith.
>> >>
>> >> Thank you very muh
>> >> Menaka
>> >>
>> >> --
>> >> Menaka Madushanka Jayawardena
>> >> Faculty of Engineering,
>> >> University of Peradeniyaya.
>> >> LinkedIn
>> >> TP:- 071 885 1183/ 071 350 5470
>> >
>> >
>> >
>> >
>> > --
>> > Menaka Madushanka Jayawardena
>> > Faculty of Engineering,
>> > University of Peradeniyaya.
>> > LinkedIn
>> > TP:- 071 885 1183/ 071 350 5470
>>
>
>
>
> --
> *Menaka Madushanka Jayawardena*
> Faculty of Engineering, <http://www.pdn.ac.lk/eng>
> University of Peradeniyaya.
> LinkedIn <http://lk.linkedin.com/in/menakajayawardena>
> TP:- 071 885 1183/ 071 350 5470
>



-- 
*Menaka Madushanka Jayawardena*
Faculty of Engineering, <http://www.pdn.ac.lk/eng>
University of Peradeniyaya.
LinkedIn <http://lk.linkedin.com/in/menakajayawardena>
TP:- 071 885 1183/ 071 350 5470

Re: XQTS file sorter implementation. https://issues.apache.org/jira/browse/VXQUERY-191

Posted by Menaka Madushanka <me...@gmail.com>.

Thank you very much Preston.
I'll look on to it.

Menaka

On 17 May 2016 at 03:37, Preston Carman <pr...@apache.org> wrote:

> Hi Menaka,
>
> We have added a few comments to your code review. It looks good and we
> only have a few comments.
>
> Preston
>
> On Thu, May 12, 2016 at 4:47 AM, Menaka Madushanka
> <me...@gmail.com> wrote:
> > And I have sent a pull request https://github.com/apache/vxquery/pull/34
> >
> > On 12 May 2016 at 17:15, Menaka Madushanka <me...@gmail.com>
> wrote:
> >>
> >> Hello,
> >>
> >> I implemented the file sorter for xqts.
> >> I followed the Option 1 stated in the issue description.
> >> The output file is attached herewith.
> >>
> >> Thank you very muh
> >> Menaka
> >>
> >> --
> >> Menaka Madushanka Jayawardena
> >> Faculty of Engineering,
> >> University of Peradeniyaya.
> >> LinkedIn
> >> TP:- 071 885 1183/ 071 350 5470
> >
> >
> >
> >
> > --
> > Menaka Madushanka Jayawardena
> > Faculty of Engineering,
> > University of Peradeniyaya.
> > LinkedIn
> > TP:- 071 885 1183/ 071 350 5470
>



-- 
*Menaka Madushanka Jayawardena*
Faculty of Engineering, <http://www.pdn.ac.lk/eng>
University of Peradeniyaya.
LinkedIn <http://lk.linkedin.com/in/menakajayawardena>
TP:- 071 885 1183/ 071 350 5470

Re: XQTS file sorter implementation. https://issues.apache.org/jira/browse/VXQUERY-191

Posted by Preston Carman <pr...@apache.org>.

Hi Menaka,

We have added a few comments to your code review. It looks good and we
only have a few comments.

Preston

On Thu, May 12, 2016 at 4:47 AM, Menaka Madushanka
<me...@gmail.com> wrote:
> And I have sent a pull request https://github.com/apache/vxquery/pull/34
>
> On 12 May 2016 at 17:15, Menaka Madushanka <me...@gmail.com> wrote:
>>
>> Hello,
>>
>> I implemented the file sorter for xqts.
>> I followed the Option 1 stated in the issue description.
>> The output file is attached herewith.
>>
>> Thank you very muh
>> Menaka
>>
>> --
>> Menaka Madushanka Jayawardena
>> Faculty of Engineering,
>> University of Peradeniyaya.
>> LinkedIn
>> TP:- 071 885 1183/ 071 350 5470
>
>
>
>
> --
> Menaka Madushanka Jayawardena
> Faculty of Engineering,
> University of Peradeniyaya.
> LinkedIn
> TP:- 071 885 1183/ 071 350 5470

Re: XQTS file sorter implementation. https://issues.apache.org/jira/browse/VXQUERY-191

Posted by Menaka Madushanka <me...@gmail.com>.

And I have sent a pull request https://github.com/apache/vxquery/pull/34

On 12 May 2016 at 17:15, Menaka Madushanka <me...@gmail.com> wrote:

> Hello,
>
> I implemented the file sorter for xqts.
> I followed the Option 1 stated in the issue description.
> The output file is attached herewith.
>
> Thank you very muh
> Menaka
>
> --
> *Menaka Madushanka Jayawardena*
> Faculty of Engineering, <http://www.pdn.ac.lk/eng>
> University of Peradeniyaya.
> LinkedIn <http://lk.linkedin.com/in/menakajayawardena>
> TP:- 071 885 1183/ 071 350 5470
>



-- 
*Menaka Madushanka Jayawardena*
Faculty of Engineering, <http://www.pdn.ac.lk/eng>
University of Peradeniyaya.
LinkedIn <http://lk.linkedin.com/in/menakajayawardena>
TP:- 071 885 1183/ 071 350 5470