You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/24 14:46:20 UTC
[GitHub] [lucene-solr] jpountz opened a new pull request #1919: Compute RAM usage ByteBuffersDataOutput on the fly.
jpountz opened a new pull request #1919:
URL: https://github.com/apache/lucene-solr/pull/1919
This helps remove the assumption that all blocks have the same size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] uschindler commented on pull request #1919: Compute RAM usage ByteBuffersDataOutput on the fly.
Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #1919:
URL: https://github.com/apache/lucene-solr/pull/1919#issuecomment-698416370
I like this approach more to just sum up the size when new blocks are allocated and added to Deque.
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jpountz commented on pull request #1919: Compute RAM usage ByteBuffersDataOutput on the fly.
Posted by GitBox <gi...@apache.org>.
jpountz commented on pull request #1919:
URL: https://github.com/apache/lucene-solr/pull/1919#issuecomment-698392573
@dweiss FYI I could not find a way to have blocks of different capacities as we have an assertion that the allocator creates blocks of the expected capacity, not larger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jpountz commented on pull request #1919: Compute RAM usage ByteBuffersDataOutput on the fly.
Posted by GitBox <gi...@apache.org>.
jpountz commented on pull request #1919:
URL: https://github.com/apache/lucene-solr/pull/1919#issuecomment-698392573
@dweiss FYI I could not find a way to have blocks of different capacities as we have an assertion that the allocator creates blocks of the expected capacity, not larger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] uschindler commented on pull request #1919: Compute RAM usage ByteBuffersDataOutput on the fly.
Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #1919:
URL: https://github.com/apache/lucene-solr/pull/1919#issuecomment-698416370
I like this approach more to just sum up the size when new blocks are allocated and added to Deque.
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jpountz merged pull request #1919: Compute RAM usage ByteBuffersDataOutput on the fly.
Posted by GitBox <gi...@apache.org>.
jpountz merged pull request #1919:
URL: https://github.com/apache/lucene-solr/pull/1919
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on pull request #1919: Compute RAM usage ByteBuffersDataOutput on the fly.
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #1919:
URL: https://github.com/apache/lucene-solr/pull/1919#issuecomment-698412271
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on pull request #1919: Compute RAM usage ByteBuffersDataOutput on the fly.
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #1919:
URL: https://github.com/apache/lucene-solr/pull/1919#issuecomment-698564766
I like the explicit field too, actually - even if you're right about capacity of internal blocks, Adrien. - this assertion there may actually be my mistake and the capacity of a new block should actually be its limit (remaining free space)... Or maybe I did have capacity in mind (can't remember, to be honest).
```
currentBlock = blockAllocate.apply(requiredBlockSize);
assert currentBlock.capacity() == requiredBlockSize;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on pull request #1919: Compute RAM usage ByteBuffersDataOutput on the fly.
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #1919:
URL: https://github.com/apache/lucene-solr/pull/1919#issuecomment-698412271
I will take another look. I can't remember forcing block capacity but it's been a while!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org