[GitHub] [spark] HeartSaVioR commented on issue #24996: [SPARK-28199][SS] Remove usage of deprecated ProcessingTime in Spark codebase

[GitBox <gi...@apache.org>]

HeartSaVioR commented on issue #24996: [SPARK-28199][SS] Remove usage of deprecated ProcessingTime in Spark codebase
URL: https://github.com/apache/spark/pull/24996#issuecomment-507290031
 
 
   When we decide to discontinue supporting `ProcessingTime`, looks like we have two choices:
   
   1) Just change the scope to restrict users' access. Existing queries may fail but it is what we expected.  Least change required, but this way someone may try to hack and continue using it. Not sure we are concerning that hacky approach, though.
   
   2) Remove the old implementation and only use the new one. Pretty clear to represent we don't support it anymore since no one could try to hack, as I'd rather not think someone applies hack to new class. More change required but simpler than current diff, maybe.
   
   Which option do you feel better?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org