You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org> on 2021/02/21 21:11:22 UTC
[Impala-ASF-CR] [Do not merge] This patch reproduces the issue in IMPALA-9767
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17103
Change subject: [Do not merge] This patch reproduces the issue in IMPALA-9767
......................................................................
[Do not merge] This patch reproduces the issue in IMPALA-9767
Thanks to Joe's and Riza's analysis, I am able to reproduce the issue
reported in IMPALA-9767.
To reproduce the issue, it suffices to execute the following steps.
1. ${IMPALA_HOME}/buildall.sh -notests -ninja -asan
2. ${IMPALA_HOME}/bin/start-impala-cluster.py --impalad_args="--debug_actions=PUBLISH_FILTER_DELAY:SLEEP@1000"
3. ${IMPALA_HOME}/bin/impala-shell.sh -d tpcds_parquet -f ~/tpcds-q1.sql -Q RUNTIME_FILTER_WAIT_TIME_MS=30000 -Q RUNTIME_FILTER_MAX_SIZE=32MB -Q RUNTIME_FILTER_MIN_SIZE=32MB
Change-Id: I1753503a7e604a2e5752825650baa4f69cc8975b
---
M be/src/runtime/coordinator.cc
1 file changed, 23 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/17103/1
--
To view, visit http://gerrit.cloudera.org:8080/17103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1753503a7e604a2e5752825650baa4f69cc8975b
Gerrit-Change-Number: 17103
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
[Impala-ASF-CR] [Do not merge] This patch reproduces the issue in IMPALA-9767
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17103 )
Change subject: [Do not merge] This patch reproduces the issue in IMPALA-9767
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17103/2/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:
http://gerrit.cloudera.org:8080/#/c/17103/2/be/src/runtime/coordinator.cc@1504
PS2, Line 1504: VLOG_QUERY << "To clear and shrink bloom_filter_directory() in Coordinator::UpdateFilter()";
line too long (98 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1753503a7e604a2e5752825650baa4f69cc8975b
Gerrit-Change-Number: 17103
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Feb 2021 22:27:23 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [Do not merge] This patch reproduces the issue in IMPALA-9767
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17103 )
Change subject: [Do not merge] This patch reproduces the issue in IMPALA-9767
......................................................................
[Do not merge] This patch reproduces the issue in IMPALA-9767
Thanks to Joe's and Riza's analysis, I am able to reproduce the issue
reported in IMPALA-9767.
To reproduce the issue, it suffices to execute the following steps.
1. ${IMPALA_HOME}/buildall.sh -notests -ninja -asan
2. ${IMPALA_HOME}/bin/start-impala-cluster.py --impalad_args="--debug_actions=PUBLISH_FILTER_DELAY:SLEEP@1000"
3. ${IMPALA_HOME}/bin/impala-shell.sh -d tpcds_parquet -f ~/tpcds-q1.sql -Q RUNTIME_FILTER_WAIT_TIME_MS=30000 -Q RUNTIME_FILTER_MAX_SIZE=32MB -Q RUNTIME_FILTER_MIN_SIZE=32MB
The TPC-DS Q1 (in the file tpcds-q1.sql above) is provided in the
following for easy reference.
with customer_total_return as
(select sr_customer_sk as ctr_customer_sk,
sr_store_sk as ctr_store_sk,
sum(SR_RETURN_AMT) as ctr_total_return
from store_returns,
date_dim
where sr_returned_date_sk = d_date_sk
and d_year = 2000
group by sr_customer_sk,
sr_store_sk)
select c_customer_id
from customer_total_return ctr1,
store,
customer
where ctr1.ctr_total_return >
(select avg(ctr_total_return)*1.2
from customer_total_return ctr2
where ctr1.ctr_store_sk = ctr2.ctr_store_sk)
and s_store_sk = ctr1.ctr_store_sk
and s_state = 'TN'
and ctr1.ctr_customer_sk = c_customer_sk
order by c_customer_id
limit 100;
Change-Id: I1753503a7e604a2e5752825650baa4f69cc8975b
---
M be/src/runtime/coordinator.cc
1 file changed, 23 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/17103/2
--
To view, visit http://gerrit.cloudera.org:8080/17103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1753503a7e604a2e5752825650baa4f69cc8975b
Gerrit-Change-Number: 17103
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] [Do not merge] This patch reproduces the issue in IMPALA-9767
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has abandoned this change. ( http://gerrit.cloudera.org:8080/17103 )
Change subject: [Do not merge] This patch reproduces the issue in IMPALA-9767
......................................................................
Abandoned
Abandon this since the fix has been merged.
--
To view, visit http://gerrit.cloudera.org:8080/17103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I1753503a7e604a2e5752825650baa4f69cc8975b
Gerrit-Change-Number: 17103
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] [Do not merge] This patch reproduces the issue in IMPALA-9767
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17103 )
Change subject: [Do not merge] This patch reproduces the issue in IMPALA-9767
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8187/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1753503a7e604a2e5752825650baa4f69cc8975b
Gerrit-Change-Number: 17103
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Feb 2021 22:46:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [Do not merge] This patch reproduces the issue in IMPALA-9767
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17103 )
Change subject: [Do not merge] This patch reproduces the issue in IMPALA-9767
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17103/1/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:
http://gerrit.cloudera.org:8080/#/c/17103/1/be/src/runtime/coordinator.cc@1504
PS1, Line 1504: VLOG_QUERY << "To clear and shrink bloom_filter_directory() in Coordinator::UpdateFilter()";
line too long (98 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1753503a7e604a2e5752825650baa4f69cc8975b
Gerrit-Change-Number: 17103
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Feb 2021 21:12:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [Do not merge] This patch reproduces the issue in IMPALA-9767
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17103 )
Change subject: [Do not merge] This patch reproduces the issue in IMPALA-9767
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8184/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1753503a7e604a2e5752825650baa4f69cc8975b
Gerrit-Change-Number: 17103
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Feb 2021 21:28:39 +0000
Gerrit-HasComments: No