You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by al...@apache.org on 2019/09/04 19:34:22 UTC

[incubator-datasketches-cpp] branch 1.0.x-incubating updated: update setup.py to work with WITH_PYTHON cmake option

This is an automated email from the ASF dual-hosted git repository.

alsay pushed a commit to branch 1.0.x-incubating
in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-cpp.git


The following commit(s) were added to refs/heads/1.0.x-incubating by this push:
     new 7e15ded  update setup.py to work with WITH_PYTHON cmake option
7e15ded is described below

commit 7e15dedabbed36e93e2d26f90e6c06300bc603a4
Author: jmalkin <jm...@users.noreply.github.com>
AuthorDate: Wed Aug 28 15:27:30 2019 -0700

    update setup.py to work with WITH_PYTHON cmake option
---
 CMakeLists.txt | 5 ++++-
 setup.py       | 3 ++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index a851cab..820bb55 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -80,7 +80,10 @@ add_subdirectory(cpc)
 add_subdirectory(kll)
 add_subdirectory(fi)
 add_subdirectory(theta)
-add_subdirectory(python)
+
+if (WITH_PYTHON)
+  add_subdirectory(python)
+endif()
 
 target_link_libraries(datasketches PUBLIC hll cpc kll fi theta)
 
diff --git a/setup.py b/setup.py
index b913176..9f8befa 100644
--- a/setup.py
+++ b/setup.py
@@ -53,7 +53,8 @@ class CMakeBuild(build_ext):
     def build_extension(self, ext):
         extdir = os.path.abspath(
             os.path.dirname(self.get_ext_fullpath(ext.name)))
-        cmake_args = ['-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=' + extdir]
+        cmake_args =  ['-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=' + extdir]
+        cmake_args += ['-DWITH_PYTHON=True']
         cfg = 'Debug' if self.debug else 'Release'
         build_args = ['--config', cfg]
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org