You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/03/13 09:49:09 UTC

Review Request 66035: Updated mesos-tidy setup to be based on upstream 6.0 release.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66035/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

Updated mesos-tidy setup to be based on upstream 6.0 release.


Diffs
-----

  support/mesos-tidy/Dockerfile f046a1410a3012509babb0558998f33b9e241c43 


Diff: https://reviews.apache.org/r/66035/diff/1/


Testing
-------

* LLVM unit test suite passes
* new image does not produce false positives


Thanks,

Benjamin Bannier


Re: Review Request 66035: Updated mesos-tidy setup to be based on upstream 6.0 release.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66035/#review199079
-----------------------------------------------------------



PASS: Mesos patch 66035 was successfully built and tested.

Reviews applied: `['66035']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66035

- Mesos Reviewbot Windows


On March 13, 2018, 2:49 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66035/
> -----------------------------------------------------------
> 
> (Updated March 13, 2018, 2:49 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated mesos-tidy setup to be based on upstream 6.0 release.
> 
> 
> Diffs
> -----
> 
>   support/mesos-tidy/Dockerfile f046a1410a3012509babb0558998f33b9e241c43 
> 
> 
> Diff: https://reviews.apache.org/r/66035/diff/1/
> 
> 
> Testing
> -------
> 
> * LLVM unit test suite passes
> * new image does not produce false positives
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 66035: Updated mesos-tidy setup to be based on upstream 6.0 release.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66035/#review199081
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66035]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 13, 2018, 9:49 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66035/
> -----------------------------------------------------------
> 
> (Updated March 13, 2018, 9:49 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated mesos-tidy setup to be based on upstream 6.0 release.
> 
> 
> Diffs
> -----
> 
>   support/mesos-tidy/Dockerfile f046a1410a3012509babb0558998f33b9e241c43 
> 
> 
> Diff: https://reviews.apache.org/r/66035/diff/1/
> 
> 
> Testing
> -------
> 
> * LLVM unit test suite passes
> * new image does not produce false positives
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 66035: Updated mesos-tidy setup to be based on upstream 6.0 release.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66035/#review204252
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On March 13, 2018, 9:49 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66035/
> -----------------------------------------------------------
> 
> (Updated March 13, 2018, 9:49 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated mesos-tidy setup to be based on upstream 6.0 release.
> 
> 
> Diffs
> -----
> 
>   support/mesos-tidy/Dockerfile f046a1410a3012509babb0558998f33b9e241c43 
> 
> 
> Diff: https://reviews.apache.org/r/66035/diff/1/
> 
> 
> Testing
> -------
> 
> * LLVM unit test suite passes
> * new image does not produce false positives
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>