You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "BewareMyPower (via GitHub)" <gi...@apache.org> on 2023/06/13 09:53:14 UTC

[GitHub] [pulsar-client-cpp] BewareMyPower opened a new pull request, #283: Remove log4cxx dependency and its specified configuration

BewareMyPower opened a new pull request, #283:
URL: https://github.com/apache/pulsar-client-cpp/pull/283

   ### Motivation
   
   See https://github.com/apache/pulsar/pull/1827, which also marked the log4cxx configurations as deprecated.
   
   ### Modifications
   
   Remove all log4cxx related stuff. log4cxx users can implement their own `LoggerFactory` like the built-in implementation before this PR.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [ ] `doc-not-needed` 
   (Please explain why)
   
   - [x] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-cpp] shibd merged pull request #283: Remove log4cxx dependency and its specified configuration

Posted by "shibd (via GitHub)" <gi...@apache.org>.
shibd merged PR #283:
URL: https://github.com/apache/pulsar-client-cpp/pull/283


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-cpp] RobertIndie commented on pull request #283: Remove log4cxx dependency and its specified configuration

Posted by "RobertIndie (via GitHub)" <gi...@apache.org>.
RobertIndie commented on PR #283:
URL: https://github.com/apache/pulsar-client-cpp/pull/283#issuecomment-1599972728

   This is a breaking change, and it fails the Python client build. I think we need to discuss it on the mailing list.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-cpp] BewareMyPower commented on pull request #283: Remove log4cxx dependency and its specified configuration

Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower commented on PR #283:
URL: https://github.com/apache/pulsar-client-cpp/pull/283#issuecomment-1600071890

   Yes, we should also remove the configs from Python as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org