You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/20 16:06:49 UTC

[GitHub] [flink] StephanEwen opened a new pull request #11163: [FLINK-16191][state backends] Improve error message on Windows when RocksDB is give a too long path.

StephanEwen opened a new pull request #11163: [FLINK-16191][state backends] Improve error message on Windows when RocksDB is give a too long path.
URL: https://github.com/apache/flink/pull/11163
 
 
   ## What is the purpose of the change
   
   Improves the error message from RocksDB from
   `Failed to create directory: C:\some\path: The system cannot find the path specified.
   `
    to
   `The directory path length (248) is longer than the directory path length limit for Windows (247): C:\some\path`.
   
   ## Verifying this change
   
   This adds a unit test exclusively executed on Windows.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11163: [FLINK-16191][state backends] Improve error message on Windows when RocksDB is give a too long path.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11163: [FLINK-16191][state backends] Improve error message on Windows when RocksDB is give a too long path.
URL: https://github.com/apache/flink/pull/11163#issuecomment-589179697
 
 
   <!--
   Meta data
   Hash:e2f83f873149ac4f3fe511ec24e2a2836cc3ac52 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149851424 TriggerType:PUSH TriggerID:e2f83f873149ac4f3fe511ec24e2a2836cc3ac52
   Hash:e2f83f873149ac4f3fe511ec24e2a2836cc3ac52 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5384 TriggerType:PUSH TriggerID:e2f83f873149ac4f3fe511ec24e2a2836cc3ac52
   -->
   ## CI report:
   
   * e2f83f873149ac4f3fe511ec24e2a2836cc3ac52 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149851424) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5384) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11163: [FLINK-16191][state backends] Improve error message on Windows when RocksDB is give a too long path.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11163: [FLINK-16191][state backends] Improve error message on Windows when RocksDB is give a too long path.
URL: https://github.com/apache/flink/pull/11163#issuecomment-589179697
 
 
   <!--
   Meta data
   Hash:e2f83f873149ac4f3fe511ec24e2a2836cc3ac52 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:e2f83f873149ac4f3fe511ec24e2a2836cc3ac52
   -->
   ## CI report:
   
   * e2f83f873149ac4f3fe511ec24e2a2836cc3ac52 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11163: [FLINK-16191][state backends] Improve error message on Windows when RocksDB is give a too long path.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11163: [FLINK-16191][state backends] Improve error message on Windows when RocksDB is give a too long path.
URL: https://github.com/apache/flink/pull/11163#issuecomment-589158426
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 83cc3a741cbb3fcb63aceb5daaac05c195933793 (Thu Feb 20 16:09:37 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol closed pull request #11163: [FLINK-16191][state backends] Improve error message on Windows when RocksDB is give a too long path.

Posted by GitBox <gi...@apache.org>.
zentol closed pull request #11163: [FLINK-16191][state backends] Improve error message on Windows when RocksDB is give a too long path.
URL: https://github.com/apache/flink/pull/11163
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11163: [FLINK-16191][state backends] Improve error message on Windows when RocksDB is give a too long path.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11163: [FLINK-16191][state backends] Improve error message on Windows when RocksDB is give a too long path.
URL: https://github.com/apache/flink/pull/11163#issuecomment-589179697
 
 
   <!--
   Meta data
   Hash:e2f83f873149ac4f3fe511ec24e2a2836cc3ac52 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149851424 TriggerType:PUSH TriggerID:e2f83f873149ac4f3fe511ec24e2a2836cc3ac52
   -->
   ## CI report:
   
   * e2f83f873149ac4f3fe511ec24e2a2836cc3ac52 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149851424) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services