You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Prasanth Jayachandran (JIRA)" <ji...@apache.org> on 2016/05/14 02:18:13 UTC
[jira] [Comment Edited] (HIVE-9756) LLAP: use log4j 2 for llap (log
to separate files, etc.)
[ https://issues.apache.org/jira/browse/HIVE-9756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283378#comment-15283378 ]
Prasanth Jayachandran edited comment on HIVE-9756 at 5/14/16 2:17 AM:
----------------------------------------------------------------------
[~sershe] Attaching rebased patch. Also updated the properties to use the new configuration format. I haven't tested this patch extensively yet. This patch creates new file per dag id. The file name format will be
{code}
<application_id_string>_dag_id_<dag_identifier>.log
{code}
There might be one more change required for this. Since MDC contexts are not inheritable for the threads created using thread pools, in TaskRunnerCallable we might need to pass a custom executor service that clones the MDC in beforeExecute() hook of thread pool. Alternatively, we can change CallableWithNdc so that it clones the MDC as well.
was (Author: prasanth_j):
[~sershe] Attaching rebased patch. Also updated the properties to use the new configuration format. I haven't tested this patch extensively yet. This patch creates new file per dag id. The file name format will be
<application_id_string>_dag_id_<dag_identifier>.log
There might be one more change required for this. Since MDC contexts are not inheritable for the threads created using thread pools, in TaskRunnerCallable we might need to pass a custom executor service that clones the MDC in beforeExecute() hook of thread pool. Alternatively, we can change CallableWithNdc so that it clones the MDC as well.
> LLAP: use log4j 2 for llap (log to separate files, etc.)
> --------------------------------------------------------
>
> Key: HIVE-9756
> URL: https://issues.apache.org/jira/browse/HIVE-9756
> Project: Hive
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Gunther Hagleitner
> Assignee: Prasanth Jayachandran
> Attachments: HIVE-9756.1.patch, HIVE-9756.2.patch, HIVE-9756.3.patch
>
>
> For the INFO logging, we'll need to use the log4j-jcl 2.x upgrade-path to get throughput friendly logging.
> http://logging.apache.org/log4j/2.0/manual/async.html#Performance
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)