[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #256: Improve the C APIs for batch receive policy and fix the wrong documents

["BewareMyPower (via GitHub)" <gi...@apache.org>]

BewareMyPower commented on code in PR #256:
URL: https://github.com/apache/pulsar-client-cpp/pull/256#discussion_r1172747443


##########
include/pulsar/c/consumer_configuration.h:
##########
@@ -89,12 +89,14 @@ typedef enum
     pulsar_consumer_regex_sub_mode_AllTopics = 2
 } pulsar_consumer_regex_subscription_mode;
 
+// Though any field could be non-positive, if all of them are non-positive, this policy will be treated as
+// invalid
 typedef struct {
-    // Max num message, if less than 0, it means no limit.
-    int maxNumMessage;
-    // Max num bytes, if less than 0, it means no limit.
+    // Max num messages, a non-positive value means no limit.
+    int maxNumMessages;

Review Comment:
   Yes, see my additional explanations here:
   - https://github.com/apache/pulsar-client-cpp/pull/237#discussion_r1172743122
   - https://github.com/apache/pulsar-client-cpp/pull/237#discussion_r1172745690



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org