You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/13 08:42:30 UTC
[GitHub] [flink] zhijiangW opened a new pull request #10840:
[FLINK-15444][runtime] Make the component AbstractInvokable in
CheckpointBarrierHandler NonNull
zhijiangW opened a new pull request #10840: [FLINK-15444][runtime] Make the component AbstractInvokable in CheckpointBarrierHandler NonNull
URL: https://github.com/apache/flink/pull/10840
## What is the purpose of the change
*The current component `AbstractInvokable` in `CheckpointBarrierHandler` is annotated as `@Nullable`. Actually in real code path it is passed via the constructor and never be null. The nullable annotation is only used for unit test purpose. But this way would mislead the real usage in practice and bring extra troubles, because you have to alway check whether it is null before usage in related processes.*
*We can refactor the related unit tests to implement a dummy `AbstractInvokable` for tests and remove the @Nullable annotation from the related class constructors.*
## Brief change log
- *Remove `Nullable` annotation from `CheckpointedInputGate`*
- *Remove `Nullable` annotation from `CheckpointBarrierHandler`*
- *Introduce `DummyCheckpointInvokable` for tests*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10840:
[FLINK-15444][runtime] Make the component AbstractInvokable in
CheckpointBarrierHandler NonNull
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10840: [FLINK-15444][runtime] Make the component AbstractInvokable in CheckpointBarrierHandler NonNull
URL: https://github.com/apache/flink/pull/10840#issuecomment-573563119
<!--
Meta data
Hash:61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144113694 TriggerType:PUSH TriggerID:61e9e675667e05e44e9c4b5ffd7565f60aec6d62
Hash:61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4286 TriggerType:PUSH TriggerID:61e9e675667e05e44e9c4b5ffd7565f60aec6d62
Hash:cc0483f73b604cdfededba0ed4e12c193f72fbcc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4495 TriggerType:PUSH TriggerID:cc0483f73b604cdfededba0ed4e12c193f72fbcc
Hash:cc0483f73b604cdfededba0ed4e12c193f72fbcc Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145165620 TriggerType:PUSH TriggerID:cc0483f73b604cdfededba0ed4e12c193f72fbcc
-->
## CI report:
* 61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144113694) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4286)
* cc0483f73b604cdfededba0ed4e12c193f72fbcc Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145165620) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4495)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10840: [FLINK-15444][runtime]
Make the component AbstractInvokable in CheckpointBarrierHandler NonNull
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10840: [FLINK-15444][runtime] Make the component AbstractInvokable in CheckpointBarrierHandler NonNull
URL: https://github.com/apache/flink/pull/10840#issuecomment-573561483
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 61e9e675667e05e44e9c4b5ffd7565f60aec6d62 (Mon Jan 13 08:48:18 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10840:
[FLINK-15444][runtime] Make the component AbstractInvokable in
CheckpointBarrierHandler NonNull
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10840: [FLINK-15444][runtime] Make the component AbstractInvokable in CheckpointBarrierHandler NonNull
URL: https://github.com/apache/flink/pull/10840#issuecomment-573563119
<!--
Meta data
Hash:61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144113694 TriggerType:PUSH TriggerID:61e9e675667e05e44e9c4b5ffd7565f60aec6d62
Hash:61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4286 TriggerType:PUSH TriggerID:61e9e675667e05e44e9c4b5ffd7565f60aec6d62
Hash:cc0483f73b604cdfededba0ed4e12c193f72fbcc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4495 TriggerType:PUSH TriggerID:cc0483f73b604cdfededba0ed4e12c193f72fbcc
Hash:cc0483f73b604cdfededba0ed4e12c193f72fbcc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145165620 TriggerType:PUSH TriggerID:cc0483f73b604cdfededba0ed4e12c193f72fbcc
Hash:580cc871894563a825ddfa8026afed0a649a94f2 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145174837 TriggerType:PUSH TriggerID:580cc871894563a825ddfa8026afed0a649a94f2
Hash:580cc871894563a825ddfa8026afed0a649a94f2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4501 TriggerType:PUSH TriggerID:580cc871894563a825ddfa8026afed0a649a94f2
-->
## CI report:
* 61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144113694) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4286)
* cc0483f73b604cdfededba0ed4e12c193f72fbcc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145165620) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4495)
* 580cc871894563a825ddfa8026afed0a649a94f2 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145174837) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4501)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10840:
[FLINK-15444][runtime] Make the component AbstractInvokable in
CheckpointBarrierHandler NonNull
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10840: [FLINK-15444][runtime] Make the component AbstractInvokable in CheckpointBarrierHandler NonNull
URL: https://github.com/apache/flink/pull/10840#issuecomment-573563119
<!--
Meta data
Hash:61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144113694 TriggerType:PUSH TriggerID:61e9e675667e05e44e9c4b5ffd7565f60aec6d62
Hash:61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4286 TriggerType:PUSH TriggerID:61e9e675667e05e44e9c4b5ffd7565f60aec6d62
Hash:cc0483f73b604cdfededba0ed4e12c193f72fbcc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4495 TriggerType:PUSH TriggerID:cc0483f73b604cdfededba0ed4e12c193f72fbcc
Hash:cc0483f73b604cdfededba0ed4e12c193f72fbcc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145165620 TriggerType:PUSH TriggerID:cc0483f73b604cdfededba0ed4e12c193f72fbcc
-->
## CI report:
* 61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144113694) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4286)
* cc0483f73b604cdfededba0ed4e12c193f72fbcc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145165620) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4495)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10840:
[FLINK-15444][runtime] Make the component AbstractInvokable in
CheckpointBarrierHandler NonNull
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10840: [FLINK-15444][runtime] Make the component AbstractInvokable in CheckpointBarrierHandler NonNull
URL: https://github.com/apache/flink/pull/10840#issuecomment-573563119
<!--
Meta data
Hash:61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144113694 TriggerType:PUSH TriggerID:61e9e675667e05e44e9c4b5ffd7565f60aec6d62
Hash:61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4286 TriggerType:PUSH TriggerID:61e9e675667e05e44e9c4b5ffd7565f60aec6d62
-->
## CI report:
* 61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144113694) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4286)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10840:
[FLINK-15444][runtime] Make the component AbstractInvokable in
CheckpointBarrierHandler NonNull
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10840: [FLINK-15444][runtime] Make the component AbstractInvokable in CheckpointBarrierHandler NonNull
URL: https://github.com/apache/flink/pull/10840#issuecomment-573563119
<!--
Meta data
Hash:61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144113694 TriggerType:PUSH TriggerID:61e9e675667e05e44e9c4b5ffd7565f60aec6d62
Hash:61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4286 TriggerType:PUSH TriggerID:61e9e675667e05e44e9c4b5ffd7565f60aec6d62
Hash:cc0483f73b604cdfededba0ed4e12c193f72fbcc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4495 TriggerType:PUSH TriggerID:cc0483f73b604cdfededba0ed4e12c193f72fbcc
Hash:cc0483f73b604cdfededba0ed4e12c193f72fbcc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145165620 TriggerType:PUSH TriggerID:cc0483f73b604cdfededba0ed4e12c193f72fbcc
Hash:580cc871894563a825ddfa8026afed0a649a94f2 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145174837 TriggerType:PUSH TriggerID:580cc871894563a825ddfa8026afed0a649a94f2
Hash:580cc871894563a825ddfa8026afed0a649a94f2 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4501 TriggerType:PUSH TriggerID:580cc871894563a825ddfa8026afed0a649a94f2
-->
## CI report:
* 61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144113694) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4286)
* cc0483f73b604cdfededba0ed4e12c193f72fbcc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145165620) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4495)
* 580cc871894563a825ddfa8026afed0a649a94f2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145174837) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4501)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10840:
[FLINK-15444][runtime] Make the component AbstractInvokable in
CheckpointBarrierHandler NonNull
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10840: [FLINK-15444][runtime] Make the component AbstractInvokable in CheckpointBarrierHandler NonNull
URL: https://github.com/apache/flink/pull/10840#issuecomment-573563119
<!--
Meta data
Hash:61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144113694 TriggerType:PUSH TriggerID:61e9e675667e05e44e9c4b5ffd7565f60aec6d62
Hash:61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4286 TriggerType:PUSH TriggerID:61e9e675667e05e44e9c4b5ffd7565f60aec6d62
Hash:cc0483f73b604cdfededba0ed4e12c193f72fbcc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4495 TriggerType:PUSH TriggerID:cc0483f73b604cdfededba0ed4e12c193f72fbcc
Hash:cc0483f73b604cdfededba0ed4e12c193f72fbcc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145165620 TriggerType:PUSH TriggerID:cc0483f73b604cdfededba0ed4e12c193f72fbcc
Hash:580cc871894563a825ddfa8026afed0a649a94f2 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:580cc871894563a825ddfa8026afed0a649a94f2
-->
## CI report:
* 61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144113694) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4286)
* cc0483f73b604cdfededba0ed4e12c193f72fbcc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145165620) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4495)
* 580cc871894563a825ddfa8026afed0a649a94f2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10840:
[FLINK-15444][runtime] Make the component AbstractInvokable in
CheckpointBarrierHandler NonNull
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10840: [FLINK-15444][runtime] Make the component AbstractInvokable in CheckpointBarrierHandler NonNull
URL: https://github.com/apache/flink/pull/10840#issuecomment-573563119
<!--
Meta data
Hash:61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144113694 TriggerType:PUSH TriggerID:61e9e675667e05e44e9c4b5ffd7565f60aec6d62
Hash:61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4286 TriggerType:PUSH TriggerID:61e9e675667e05e44e9c4b5ffd7565f60aec6d62
Hash:cc0483f73b604cdfededba0ed4e12c193f72fbcc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4495 TriggerType:PUSH TriggerID:cc0483f73b604cdfededba0ed4e12c193f72fbcc
Hash:cc0483f73b604cdfededba0ed4e12c193f72fbcc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145165620 TriggerType:PUSH TriggerID:cc0483f73b604cdfededba0ed4e12c193f72fbcc
Hash:580cc871894563a825ddfa8026afed0a649a94f2 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145174837 TriggerType:PUSH TriggerID:580cc871894563a825ddfa8026afed0a649a94f2
Hash:580cc871894563a825ddfa8026afed0a649a94f2 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4501 TriggerType:PUSH TriggerID:580cc871894563a825ddfa8026afed0a649a94f2
-->
## CI report:
* 61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144113694) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4286)
* cc0483f73b604cdfededba0ed4e12c193f72fbcc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145165620) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4495)
* 580cc871894563a825ddfa8026afed0a649a94f2 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145174837) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4501)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10840: [FLINK-15444][runtime]
Make the component AbstractInvokable in CheckpointBarrierHandler NonNull
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10840: [FLINK-15444][runtime] Make the component AbstractInvokable in CheckpointBarrierHandler NonNull
URL: https://github.com/apache/flink/pull/10840#issuecomment-573563119
<!--
Meta data
Hash:61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:61e9e675667e05e44e9c4b5ffd7565f60aec6d62
-->
## CI report:
* 61e9e675667e05e44e9c4b5ffd7565f60aec6d62 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10840:
[FLINK-15444][runtime] Make the component AbstractInvokable in
CheckpointBarrierHandler NonNull
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10840: [FLINK-15444][runtime] Make the component AbstractInvokable in CheckpointBarrierHandler NonNull
URL: https://github.com/apache/flink/pull/10840#issuecomment-573563119
<!--
Meta data
Hash:61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144113694 TriggerType:PUSH TriggerID:61e9e675667e05e44e9c4b5ffd7565f60aec6d62
Hash:61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4286 TriggerType:PUSH TriggerID:61e9e675667e05e44e9c4b5ffd7565f60aec6d62
Hash:cc0483f73b604cdfededba0ed4e12c193f72fbcc Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:cc0483f73b604cdfededba0ed4e12c193f72fbcc
-->
## CI report:
* 61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144113694) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4286)
* cc0483f73b604cdfededba0ed4e12c193f72fbcc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on issue #10840: [FLINK-15444][runtime]
Make the component AbstractInvokable in CheckpointBarrierHandler NonNull
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on issue #10840: [FLINK-15444][runtime] Make the component AbstractInvokable in CheckpointBarrierHandler NonNull
URL: https://github.com/apache/flink/pull/10840#issuecomment-576490005
Thanks for the review @pnowojski !
I have fixed the failure tests and the travis already green. Do you want to take a look before merging?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10840:
[FLINK-15444][runtime] Make the component AbstractInvokable in
CheckpointBarrierHandler NonNull
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10840: [FLINK-15444][runtime] Make the component AbstractInvokable in CheckpointBarrierHandler NonNull
URL: https://github.com/apache/flink/pull/10840#issuecomment-573563119
<!--
Meta data
Hash:61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144113694 TriggerType:PUSH TriggerID:61e9e675667e05e44e9c4b5ffd7565f60aec6d62
Hash:61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4286 TriggerType:PUSH TriggerID:61e9e675667e05e44e9c4b5ffd7565f60aec6d62
-->
## CI report:
* 61e9e675667e05e44e9c4b5ffd7565f60aec6d62 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144113694) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4286)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW merged pull request #10840:
[FLINK-15444][runtime] Make the component AbstractInvokable in
CheckpointBarrierHandler NonNull
Posted by GitBox <gi...@apache.org>.
zhijiangW merged pull request #10840: [FLINK-15444][runtime] Make the component AbstractInvokable in CheckpointBarrierHandler NonNull
URL: https://github.com/apache/flink/pull/10840
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services