You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/21 11:26:42 UTC
[GitHub] [dubbo] owen200008 opened a new pull request #8331: support byte[] PojoUtils
owen200008 opened a new pull request #8331:
URL: https://github.com/apache/dubbo/pull/8331
## What is the purpose of the change
support byte[] PojoUtils
## Brief changelog
## Verifying this change
<!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] horizonzy commented on pull request #8331: support byte[] PojoUtils
Posted by GitBox <gi...@apache.org>.
horizonzy commented on pull request #8331:
URL: https://github.com/apache/dubbo/pull/8331#issuecomment-884379680
Hi, could you add unit test for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] horizonzy commented on pull request #8331: support byte[] PojoUtils
Posted by GitBox <gi...@apache.org>.
horizonzy commented on pull request #8331:
URL: https://github.com/apache/dubbo/pull/8331#issuecomment-886060638
Hi, could you explain it detaily. I can't fully understand your intentions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] owen200008 commented on pull request #8331: support byte[] PojoUtils
Posted by GitBox <gi...@apache.org>.
owen200008 commented on pull request #8331:
URL: https://github.com/apache/dubbo/pull/8331#issuecomment-886395444
when A call B
when we use the generic B interface，the req param must be error when use fastjson and req have byte[]
because use fastjson byte[] will encode by base64 to string
the generic B don't know, so the req param map(bytep] is base64 string)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] owen200008 commented on pull request #8331: support byte[] PojoUtils
Posted by GitBox <gi...@apache.org>.
owen200008 commented on pull request #8331:
URL: https://github.com/apache/dubbo/pull/8331#issuecomment-886391699
close
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] owen200008 commented on pull request #8331: support byte[] PojoUtils
Posted by GitBox <gi...@apache.org>.
owen200008 commented on pull request #8331:
URL: https://github.com/apache/dubbo/pull/8331#issuecomment-885491201
it is no good idea to support byte[] in fastjson
it is no way to cover all case.
when A -> B use proxy mode A->proxy->B
the proxy not know the class, so it no way to deal with byte[] in fastjson.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] owen200008 commented on pull request #8331: support byte[] PojoUtils
Posted by GitBox <gi...@apache.org>.
owen200008 commented on pull request #8331:
URL: https://github.com/apache/dubbo/pull/8331#issuecomment-884137076
fastjson no support， it use the base64
later i will try to fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] owen200008 closed pull request #8331: support byte[] PojoUtils
Posted by GitBox <gi...@apache.org>.
owen200008 closed pull request #8331:
URL: https://github.com/apache/dubbo/pull/8331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] owen200008 commented on pull request #8331: support byte[] PojoUtils
Posted by GitBox <gi...@apache.org>.
owen200008 commented on pull request #8331:
URL: https://github.com/apache/dubbo/pull/8331#issuecomment-884116919
transfer the protocalbuffer data to the provider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org