You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ConeyLiu <gi...@git.apache.org> on 2017/05/07 15:22:30 UTC
[GitHub] spark pull request #17889: [MINOR][BUILD] Fix lint-java breaks.
GitHub user ConeyLiu opened a pull request:
https://github.com/apache/spark/pull/17889
[MINOR][BUILD] Fix lint-java breaks.
## What changes were proposed in this pull request?
This PR proposes to fix the lint-breaks as below:
```
[ERROR] src/main/java/org/apache/spark/unsafe/Platform.java:[51] (regexp) RegexpSingleline: No trailing whitespace allowed.
[ERROR] src/main/scala/org/apache/spark/sql/streaming/Trigger.java:[45,25] (naming) MethodName: Method name 'ProcessingTime' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'.
[ERROR] src/main/scala/org/apache/spark/sql/streaming/Trigger.java:[62,25] (naming) MethodName: Method name 'ProcessingTime' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'.
[ERROR] src/main/scala/org/apache/spark/sql/streaming/Trigger.java:[78,25] (naming) MethodName: Method name 'ProcessingTime' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'.
[ERROR] src/main/scala/org/apache/spark/sql/streaming/Trigger.java:[92,25] (naming) MethodName: Method name 'ProcessingTime' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'.
[ERROR] src/main/scala/org/apache/spark/sql/streaming/Trigger.java:[102,25] (naming) MethodName: Method name 'Once' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'.
[ERROR] src/test/java/org/apache/spark/streaming/kinesis/JavaKinesisInputDStreamBuilderSuite.java:[28,8] (imports) UnusedImports: Unused import - org.apache.spark.streaming.api.java.JavaDStream.
```
after:
```
dev/lint-java
Checkstyle checks passed.
```
[Test Result][https://travis-ci.org/ConeyLiu/spark/jobs/229666169]
## How was this patch tested?
Travis CI.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ConeyLiu/spark spark
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17889.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17889
----
commit 0ff20467d6874a7e39b6b89cc9a4212602d76ebf
Author: Xianyang Liu <xi...@intel.com>
Date: 2017-04-17T15:15:32Z
Optimize RDD.cartesian
commit 14d0e951b2ee3bc6a0ec8f227d417572e0371c6b
Author: Xianyang Liu <xi...@intel.com>
Date: 2017-04-25T05:54:07Z
cache the block fetched from remote
commit 5b2318472a0b0f051d350c024fc4288148c172be
Author: Xianyang Liu <xi...@intel.com>
Date: 2017-04-26T06:08:04Z
add some log
commit 96708b3933c38600d60bd21d656f915ee62944e3
Author: Xianyang Liu <xi...@intel.com>
Date: 2017-04-26T06:12:37Z
fix the compile error
commit 0cc4d655fe25701683c6cebecb485c065c9f8dba
Author: Xianyang Liu <xi...@intel.com>
Date: 2017-04-26T06:54:51Z
Add log
commit 74d8a5e70a51bdf4fd9c4e730c392b0c9e06b668
Author: Xianyang Liu <xi...@intel.com>
Date: 2017-04-26T07:14:45Z
Add log
commit 359469943e3c2bfd25fb2f67c56dc78ce1039e3e
Author: Xianyang Liu <xi...@intel.com>
Date: 2017-04-26T07:56:40Z
add log
commit 9bc7a77486c4a42369dbf3c5f5362a2fd7a5daa5
Author: Xianyang Liu <xi...@intel.com>
Date: 2017-04-28T02:54:23Z
fix the dead lock error
commit 80d359677984445e216000bfd6b84b7465013c80
Author: Xianyang Liu <xi...@intel.com>
Date: 2017-05-02T15:15:58Z
remove log, and using completionIterator to remote cached block
commit f5eae9b5ada704c0354a95092ef3c166a75cb688
Author: Xianyang Liu <xi...@intel.com>
Date: 2017-05-03T13:25:46Z
remove the blocking parameter from 'removeBlock'
commit 3c61141b9fc4b9cf4cfcdf6c2e9f45c5a97ff754
Author: Xianyang Liu <xi...@intel.com>
Date: 2017-05-03T14:05:53Z
Add some comments
commit cc3c733ff98863401d19ceae411198be3da06eeb
Author: Xianyang Liu <xi...@intel.com>
Date: 2017-05-03T16:15:12Z
remove block without blocking
commit 85cee23172fe280c8609e12ee30bfcc21f025355
Author: Xianyang Liu <xi...@intel.com>
Date: 2017-05-05T07:50:27Z
remove the block only when the task complete
commit ceb547a37ab4a5880e72e3e7a0d00752ab37350b
Author: Xianyang Liu <xi...@intel.com>
Date: 2017-05-07T15:13:36Z
add test case and add some comments
commit 4cc444509b3fe8aa954d8c3d9f6bfe8b10eeec6e
Author: Xianyang Liu <xi...@intel.com>
Date: 2017-05-07T15:14:32Z
Merge remote-tracking branch 'origin/spark' into spark
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17889: [MINOR][BUILD] Fix lint-java breaks.
Posted by ConeyLiu <gi...@git.apache.org>.
Github user ConeyLiu closed the pull request at:
https://github.com/apache/spark/pull/17889
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org