You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by nickwallen <gi...@git.apache.org> on 2018/11/29 15:53:47 UTC
[GitHub] metron pull request #1284: METRON-1867 Remove `/api/v1/update/replace` endpo...
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1284
METRON-1867 Remove `/api/v1/update/replace` endpoint
The `/api/v1/update/replace` endpoint is no longer used. This is dead code and should be removed.
I have tried to isolate the changes from #1259 on to master to help reviewers. This replaces #1259.
## Testing
1. Spin-up Full Dev.
1. Open the Alerts UI.
* View alerts.
* Escalate an alert.
* Comment on an alert.
* Create a meta-alert.
* Escalate a meta-alert.
1. Run the UI e2e tests.
## Pull Request Checklist
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1867-v2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1284.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1284
----
commit 89d1d5742005d7869728ae7a67c96acc26ce651b
Author: Nick Allen <ni...@...>
Date: 2018-11-12T17:24:40Z
METRON-1867 Remove `/api/v1/update/replace` endpoint
commit 428a12f5ad883c0aa19e1c9040dee2070a97a6a4
Author: Nick Allen <ni...@...>
Date: 2018-11-29T15:51:12Z
Trying to keep the changes as focused on remove the ReplaceRequest as possible
----
---
[GitHub] metron issue #1284: METRON-1867 Remove `/api/v1/update/replace` endpoint
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1284
> Is this endpoint superseded by another implementation, or just removed altogether?
The endpoint has been removed completely. It is not being used by anything in Metron currently.
> Any users of the REST API using this directly for any reason? Not sure if we have to deprecate this - i.e. I'm unclear of whether or not we consider the REST API client facing or not, or if it's just middleware to us for the UI.
I just sent out a notice to the dev list to see if anyone has a strong opinion.
---
[GitHub] metron issue #1284: METRON-1867 Remove `/api/v1/update/replace` endpoint
Posted by mmiklavc <gi...@git.apache.org>.
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1284
+1 by inspection pending details on the following:
- Is this endpoint superseded by another implementation, or just removed altogether?
- Any users of the REST API using this directly for any reason? Not sure if we have to deprecate this - i.e. I'm unclear of whether or not we consider the REST API client facing or not, or if it's just middleware to us for the UI.
---
[GitHub] metron pull request #1284: METRON-1867 Remove `/api/v1/update/replace` endpo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/1284
---
[GitHub] metron issue #1284: METRON-1867 Remove `/api/v1/update/replace` endpoint
Posted by sardell <gi...@git.apache.org>.
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/1284
Though I cannot vouch for the Java changes, the UI builds and runs fine. It looks like the only change needed there is the removal of the replace request model since, as you pointed out, there were no calls being made to the replace endpoint.
---