You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/10/17 04:28:11 UTC

[GitHub] [couchdb] jaydoane commented on a diff in pull request #4210: Make test prometheus port explicit

jaydoane commented on code in PR #4210:
URL: https://github.com/apache/couchdb/pull/4210#discussion_r996602540


##########
src/couch_prometheus/test/eunit/couch_prometheus_e2e_tests.erl:
##########
@@ -81,6 +81,7 @@ setup_prometheus(WithAdditionalPort) ->
         WithAdditionalPort,
         Persist
     ),
+    ok = config:set("prometheus", "port", ?PROM_PORT),

Review Comment:
   Ah yes of course. Thanks for catching that!  Fixed in https://github.com/apache/couchdb/commit/ef2fcbc1f22d8e98ed76595efc155e4eca3f9467



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org