[GitHub] spark pull request: [SPARK-15087][MINOR][DOC] Follow Up: Fix the C...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12953#discussion_r62328925
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
    @@ -389,11 +389,10 @@ private[spark] class TaskSchedulerImpl(
         // (taskId, stageId, stageAttemptId, accumUpdates)
         val accumUpdatesWithTaskIds: Array[(Long, Int, Int, Seq[AccumulableInfo])] = synchronized {
           accumUpdates.flatMap { case (id, updates) =>
    -        // We should call `acc.value` here as we are at driver side now.  However, the RPC framework
    +        // We call `acc.value` here as we are at driver side now.  However, the RPC framework
    --- End diff --
    
    The "However..." bit also sounds out of date. Is this problem actually no longer an issue? then this whole comment can be removed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org