You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "DadaVinqi (via GitHub)" <gi...@apache.org> on 2026/08/19 07:43:29 UTC
[PR] fix: preserve XA retry state and connection ownership [incubator-seata-go]
DadaVinqi opened a new pull request, #1148:
URL: https://github.com/apache/incubator-seata-go/pull/1148
- [x] I have registered the PR [changes](https://github.com/apache/incubator-seata-go/tree/master/changes).
**What this PR does**:
This PR fixes XA failure-path correctness, retry semantics, idempotency, and physical connection ownership.
## Problem and Root Cause
### 1. Incorrect phase-two status and terminal cache
When XA phase two fails, the current implementation can return or record an incorrect terminal result:
- `BranchCommit` returns a rollback-failure status when resource or connection acquisition fails.
- Commit failure writes `PhasetwoCommitted` to `branchStatusCache`.
- Rollback failure writes `PhasetwoRollbacked` to the cache.
- Temporary database and connection failures are returned as unretryable.
- A repeated callback does not consume the cached terminal state and accesses the database again.
The root cause is that phase-two error handling does not distinguish commit and rollback directions, retryable and unretryable errors, confirmed terminal outcomes and ambiguous errors, or first execution and repeated callbacks. The cache is also updated from failure branches instead of only after a confirmed terminal result.
### 2. Phase-one errors can be lost
When `XA END` or `XA PREPARE` fails, `commitErrorHandle` performs a compensating rollback. If that rollback succeeds, the previous implementation returns `nil`, because the local error variable only receives the rollback result. The original END/PREPARE error is therefore lost, and the caller can subsequently treat phase one as successful.
### 3. Retryable failures lose their owner connection
`XAConn.XaCommit` and `XAConn.XaRollback` release the keeper entry regardless of the database result. For databases or configurations that still require the original physical connection, a temporary error therefore removes the only usable owner before the TC retries.
The root cause is that database execution and connection ownership completion are handled independently. The code does not model whether phase two actually reached a terminal state.
### 4. Held connections can still be reused by `database/sql`
Keeping an `XAConn` in `DBResource.keeper` does not automatically remove its physical connection from the `database/sql` pool. `ResetSession` previously returned `nil`, so the pool could reuse a prepared connection while the same `XAConn` was still referenced by the keeper.
At the same time, pool discard, phase-two completion, and timeout close could operate on the same physical connection without a shared ownership guard. This can cause prepared connection reuse, overwritten branch state, phase-two/timeout races, duplicate closes, and keeper entries pointing to unusable connections.
### 5. Forced close can leak keeper state
`XAConn.CloseForce` returns immediately when the underlying physical close returns an error. As a result, the keeper entry and local branch state are not cleaned up.
### 6. Cached terminal states are ignored
`XAConn.termination` reads `branchStatusCache`, but only checks whether the cache lookup itself returned an error. A successfully retrieved `PhasetwoCommitted` or `PhasetwoRollbacked` value is ignored.
### 7. MySQL detach capability is determined incompletely
MySQL 8.0.29 introduced cross-connection phase two, but it also depends on the effective session variable `@@session.xa_detach_on_prepare`. The previous implementation only checked the server version. Because this is a session variable, checking it once on an initialization connection is also insufficient: the actual XA physical connection may have a different value.
### 8. The existing error classifier is not sufficient for phase two
`XAErrorClassifier.IsAlreadyEnded` only helps the XA END path. It cannot distinguish already committed, already rollbacked, deterministic protocol errors, ambiguous `XAER_NOTA`, or temporary connection and RM failures.
## Solution
### 1. Make terminal-state publication directional and idempotent
Phase-two handling now:
- returns commit-failure status for commit-path failures;
- returns rollback-failure status for rollback-path failures;
- treats unknown connection and RM errors as retryable;
- writes terminal cache entries only after confirmed success;
- checks the terminal cache before accessing the database;
- returns cached same-direction outcomes as idempotent success;
- returns cached opposite-direction outcomes as unretryable conflicts.
The terminal cache is published before releasing the keeper, so a concurrent retry cannot observe neither the owner nor the terminal result.
### 2. Preserve the original phase-one error
`commitErrorHandle` now receives the original failure explicitly. If compensating rollback succeeds, the original END/PREPARE error is returned. If rollback also fails, both errors are retained with `errors.Join`.
### 3. Release keeper ownership only after confirmed completion
`XaCommit` and `XaRollback` release the keeper only when the database operation succeeds or the database-specific classifier proves the exact same terminal direction. Retryable errors keep the owner connection available for TC retry. Opposite terminal outcomes are recorded with their actual status and returned as unretryable conflicts.
### 4. Transfer pending connections out of the pool safely
Held XA connections now have explicit synchronized ownership state:
- `ResetSession` returns `driver.ErrBadConn` for a pending keeper-owned branch;
- `database/sql` discards the wrapper instead of reusing it;
- `XAConn.Close` does not close the physical connection while keeper owns it;
- phase two or timeout cleanup becomes the physical owner;
- a mutex serializes pool discard, phase two, and forced close;
- a `physicalClosed` guard prevents duplicate closes.
If phase two finishes before pool discard, the connection can remain reusable. If the pool already discarded it, phase-two completion closes it exactly once.
### 5. Always clean up after forced close
`CloseForce` now performs keeper and branch-state cleanup regardless of the physical close result. The original close error is still returned.
### 6. Handle cached terminal states explicitly
`termination` now rejects branches cached as `PhasetwoCommitted` or `PhasetwoRollbacked` and releases any remaining keeper ownership.
### 7. Probe MySQL detach capability on the actual XA connection
For MySQL 8.0.29 and later:
1. The initialization probe marks the resource as requiring per-connection capability detection.
2. Every actual XA physical connection reads `@@session.xa_detach_on_prepare`.
3. When enabled, phase two may use a new connection.
4. When disabled, the original physical connection is retained.
5. If the probe fails, the implementation conservatively retains the owner.
### 8. Add optional phase-two error classification
This PR introduces the optional `XAPhaseTwoErrorClassifier`:
```go
type XAPhaseTwoErrorClassifier interface {
IsAlreadyCommitted(err error) bool
IsAlreadyRollbacked(err error) bool
IsUnretryable(err error) bool
}
```
The MySQL implementation keeps `XAER_NOTA` ambiguous and retryable, recognizes XA rollback terminal codes, treats `XAER_INVAL` and `XAER_OUTSIDE` as unretryable, and leaves unknown RM and connection failures retryable.
## Implementation Details
### `pkg/datasource/sql/xa_resource_manager.go`
- Correct commit/rollback failure direction.
- Consume cached terminal status before database access.
- Publish terminal status before releasing keeper ownership.
- Handle same-direction retries as idempotent success.
- Handle opposite terminal states as unretryable conflicts.
- Apply database-specific phase-two classification.
- Force cleanup for deterministic unretryable errors.
- Preserve wrapped connection acquisition errors.
### `pkg/datasource/sql/conn_xa.go`
- Preserve END/PREPARE errors through `commitErrorHandle`.
- Use `errors.Join` when compensating rollback also fails.
- Retain keeper entries on retryable phase-two errors.
- Add synchronized keeper and physical connection ownership.
- Return `driver.ErrBadConn` for pool reuse of held branches.
- Prevent duplicate physical closes.
- Serialize phase two and timeout cleanup.
- Release keeper on XA START failure.
- Always clean keeper state in `CloseForce`.
- Handle cached terminal states in `termination`.
### `pkg/datasource/sql/db.go`
- Keep MySQL owner connections conservatively by default.
- Detect MySQL 8.0.29+ detach capability.
- Mark applicable resources for per-connection session probing.
- Parse `xa_detach_on_prepare` from driver-native result types.
- Fall back to owner retention on probe failure.
### `pkg/datasource/sql/xa/xa_resource.go`
- Add the optional `XAPhaseTwoErrorClassifier`.
- Keep the existing `XAResource` and `XAResourceFactory` contracts unchanged.
### `pkg/datasource/sql/xa/mysql_xa_connection.go`
- Implement MySQL phase-two terminal and protocol-error classification.
- Keep `XAER_NOTA` unclassified because it does not prove a terminal direction.
### `pkg/datasource/sql/types/const.go`
Correct and extend MySQL/MariaDB XA error constants for `XAER_NOTA`, `XAER_INVAL`, `XAER_RMFAIL`, `XAER_OUTSIDE`, `XAER_RMERR`, `XA_RBROLLBACK`, `XA_RBTIMEOUT`, and `XA_RBDEADLOCK`.
### Regression Tests
Added coverage for:
- correct commit/rollback status direction;
- terminal cache publication;
- repeated same-direction callbacks;
- opposite-direction callbacks;
- retryable and unretryable errors;
- confirmed committed/rollbacked outcomes;
- original Prepare error preservation;
- forced-close cleanup;
- XA START cleanup;
- pool-to-keeper ownership transfer;
- phase-two/timeout close concurrency;
- single physical close ownership;
- MySQL version and detach combinations;
- per-session detach changes;
- conservative fallback on capability probe failure;
- MySQL phase-two error classification.
**Which issue(s) this PR fixes**:
Fixes #1147
**Special notes for your reviewer**:
- `branchStatusCache` remains a process-local idempotency optimization and is not used as durable recovery storage.
- `XAER_NOTA` remains retryable because it cannot prove whether a branch committed, rolled back, or never existed.
- The existing `XAResource` interface is unchanged.
- Connection retention is conservative whenever detach capability cannot be proven.
- Most added lines are regression and concurrency tests for previously uncovered failure paths.
## Test Plan
```bash
go test ./pkg/datasource/sql/...
# 1652 passed in 23 packages
go test -race ./pkg/datasource/sql \
-run 'TestXA(ResourceManager|Conn)_|TestDBResource_CheckDBVersion' \
-count=1
# 62 passed in 1 package
go test ./pkg/datasource/sql/xa ./pkg/datasource/sql/types -count=1
# 590 passed in 2 packages
go vet ./pkg/datasource/sql/...
git diff --check
```
On Go 1.26.5 / macOS arm64, the repository-wide test command reaches an unrelated pre-existing SIGBUS in a gomonkey-based gRPC test. The modified SQL datasource packages and focused race suites pass.
**Does this PR introduce a user-facing change?**:
```release-note
Fix XA failure handling so retryable phase-two operations preserve their connection ownership, repeated callbacks remain idempotent, and failed branches are no longer reported or cached as successful.
```
Made with [Cursor](https://cursor.com)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: preserve XA retry state and connection ownership [incubator-seata-go]
Posted by "DadaVinqi (via GitHub)" <gi...@apache.org>.
DadaVinqi commented on code in PR #1148:
URL: https://github.com/apache/incubator-seata-go/pull/1148#discussion_r3877661512
##########
pkg/datasource/sql/xa_resource_manager.go:
##########
@@ -91,15 +92,14 @@ func (xaManager *XAResourceManager) xaTwoPhaseTimeoutChecker() {
if !ok {
return true
}
- if source.IsShouldBeHeld() {
- return true
- }
-
source.GetKeeper().Range(func(key, value any) bool {
connectionXA, isConnectionXA := value.(*XAConn)
if !isConnectionXA {
return true
}
+ if connectionXA.ShouldBeHeld() {
+ return true
+ }
if time.Now().Sub(connectionXA.prepareTime) > xaManager.config.TwoPhaseHoldTime {
Review Comment:
Thanks for catching this. The previous change conflated two different concepts: temporarily caching a connection in the keeper and requiring the original connection until phase two.
I updated the implementation to separate them:
- `keepInKeeper` controls whether the connection is temporarily cached.
- `shouldBeHeld` controls whether timeout-based detach is allowed.
- `preparedForPhaseTwo` explicitly records that XA PREPARE has completed.
- `preparedForPhaseTwo`, `prepareTime`, and the hold policy are snapshotted under `keeperMu`.
- The timeout sweep now only closes entries that are prepared, detachable, and older than `TwoPhaseHoldTime`.
- Connections that must retain their original owner are still skipped intentionally.
This makes the timeout sweep effective for detachable branches without closing owner-bound branches that cannot complete phase two on another connection.
I also added regression coverage for unprepared entries, mandatory owner retention, recent detachable branches, and expired detachable branches.
Addressed in a0c4b23.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: preserve XA retry state and connection ownership [incubator-seata-go]
Posted by "XiaoFeiASK (via GitHub) via notifications" <no...@seata.apache.org>.
XiaoFeiASK commented on PR #1148:
URL: https://github.com/apache/incubator-seata-go/pull/1148#issuecomment-6705139186
Thanks for the detailed work here, @DadaVinqi. The direction is right: phase-two status is now directional, the terminal cache is published only after a confirmed outcome, retryable failures retain the owner connection, and MySQL detach capability is checked on the actual XA session. Build, vet, and the existing SQL datasource tests pass locally on `07038ab` with the same commands CI uses.
I have to request changes because of one blocking correctness issue in the pooled-connection rollback path.
### Blocking (P1): `rollBacked` survives pool reuse and suppresses later `XA ROLLBACK`
`XAConn.Rollback` sets `rollBacked = true` after a successful rollback (`pkg/datasource/sql/conn_xa.go:583`). `XaRollback` then completes phase two and releases the keeper entry. When the caller returns the connection to `database/sql`, `XAConn.ResetSession` (`pkg/datasource/sql/conn_xa.go:424`) clears `xaActive` but does not reset `rollBacked`.
On the next XA branch using that pooled wrapper, `Rollback` reaches:
```go
if !c.rollBacked {
// XA END(TMFAIL) + XA ROLLBACK
}
```
Because `rollBacked` is still true, both database operations are skipped, `Rollback` returns `nil`, and `XATx.Rollback` reports success to the TC while the database branch remains ACTIVE. This can retain locks and cause later `XA START` failures on the same physical connection.
| Step | Expected | Actual |
| --- | --- | --- |
| First rollback completes, connection returns to pool | `rollBacked == false` before next branch | `rollBacked == true` |
| Next branch is rolled back | `XA END(TMFAIL)` + `XA ROLLBACK` | Both skipped, `nil` returned |
The flag leak predates this PR, but this PR explicitly introduces the pool/keeper ownership model and the reuse path, so I would close it here.
Please:
1. Reset `rollBacked` when a new XA branch starts and defensively in `ResetSession`, under `keeperMu`.
2. Add a regression test covering `rollback -> return to pool/ResetSession -> new branch -> rollback`.
3. Assert that the second rollback actually issues both `XA END(TMFAIL)` and `XA ROLLBACK`; checking only the returned error is not sufficient.
### Should fix (P2): `DBTypeUnknown` is no longer retained conservatively
`keepIfNecessary` now gates retention only on `keepInKeeper` (`pkg/datasource/sql/conn_xa.go:460`). `keepInKeeper` is set only for MySQL and MariaDB in `checkDbVersion` (`pkg/datasource/sql/db.go:251`, `pkg/datasource/sql/db.go:275`).
`ShouldBeHeld` still returns true for `DBTypeUnknown` (`pkg/datasource/sql/conn_xa.go:643`), but that value no longer affects whether the connection enters the keeper. This regresses the conservative fallback added by #1150 for custom XA resource factories.
Suggested change:
```go
if c.keepInKeeper || c.ShouldBeHeld() {
// retain the connection
}
```
The existing `TestXAConn_ShouldBeHeld` only verifies the predicate. Please add a test that verifies the keeper entry exists, otherwise this regression remains invisible.
### Should fix (P2): terminal cache is checked outside the ownership lock
`BranchCommit` and `BranchRollback` check `branchStatus` before acquiring `keeperMu` (`pkg/datasource/sql/xa_resource_manager.go:177`, `pkg/datasource/sql/xa_resource_manager.go:230`). A concurrent duplicate callback can miss the cache and enter phase two twice.
For same-direction duplicates this can execute the database operation twice; for concurrent opposite-direction callbacks, the later callback can overwrite the terminal cache. The TC normally serializes phase-two calls for one branch, so this is not the merge blocker, but rechecking the terminal cache after acquiring `keeperMu` would make the idempotency claim much stronger.
### Nits
- The PR description lists `IsAlreadyCommitted` / `IsAlreadyRollbacked`, but the implementation exposes `ClassifyPhaseTwoError`. Please align the description with the actual interface.
- Please add end-to-end evidence for MySQL 8.0.29+ with both `xa_detach_on_prepare=ON` and `OFF`, ideally including a rollback-then-pool-reuse sequence. The existing unit tests do not exercise `database/sql` checkout/reset behavior.
Happy to re-review once the P1 rollback-state issue is fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: preserve XA retry state and connection ownership [incubator-seata-go]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1148:
URL: https://github.com/apache/incubator-seata-go/pull/1148#issuecomment-5466797102
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1148?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `74.91409%` with `73 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.63%. Comparing base ([`6bd31c7`](https://app.codecov.io/gh/apache/incubator-seata-go/commit/6bd31c77a01de46421f6d4369108b8661f3960ee?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3a2cfa4`](https://app.codecov.io/gh/apache/incubator-seata-go/commit/3a2cfa42c4c70c9f5da8f0219d6f293c169035a5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1148?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [pkg/datasource/sql/xa\_resource\_manager.go](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1148?src=pr&el=tree&filepath=pkg%2Fdatasource%2Fsql%2Fxa_resource_manager.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2RhdGFzb3VyY2Uvc3FsL3hhX3Jlc291cmNlX21hbmFnZXIuZ28=) | 66.66% | [26 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pkg/datasource/sql/conn\_xa.go](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1148?src=pr&el=tree&filepath=pkg%2Fdatasource%2Fsql%2Fconn_xa.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2RhdGFzb3VyY2Uvc3FsL2Nvbm5feGEuZ28=) | 82.64% | [13 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pkg/datasource/sql/db.go](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1148?src=pr&el=tree&filepath=pkg%2Fdatasource%2Fsql%2Fdb.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2RhdGFzb3VyY2Uvc3FsL2RiLmdv) | 70.37% | [12 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pkg/datasource/sql/xa/mysql\_xa\_connection.go](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1148?src=pr&el=tree&filepath=pkg%2Fdatasource%2Fsql%2Fxa%2Fmysql_xa_connection.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2RhdGFzb3VyY2Uvc3FsL3hhL215c3FsX3hhX2Nvbm5lY3Rpb24uZ28=) | 80.00% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1148?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1148 +/- ##
==========================================
+ Coverage 61.15% 61.63% +0.47%
==========================================
Files 309 309
Lines 22626 22852 +226
==========================================
+ Hits 13838 14085 +247
+ Misses 7508 7472 -36
- Partials 1280 1295 +15
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1148?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: preserve XA retry state and connection ownership [incubator-seata-go]
Posted by "DadaVinqi (via GitHub)" <gi...@apache.org>.
DadaVinqi commented on PR #1148:
URL: https://github.com/apache/incubator-seata-go/pull/1148#issuecomment-5506962862
Conflicts are resolved in 62cde06 by merging the latest `master`.
The resolution keeps both sides of the XA hold behavior:
- preserve the per-connection `shouldBeHeld` decision from #1148;
- retain unknown database types conservatively, as introduced by #1150;
- keep both the upstream `TestXAConn_ShouldBeHeld` coverage and the existing ownership/timeout tests.
Validation after the merge:
- `go test ./pkg/datasource/sql/...` — 1879 passed
- focused race tests — 91 passed
- `go vet ./pkg/datasource/sql/...` — passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: preserve XA retry state and connection ownership [incubator-seata-go]
Posted by "Ethan-Xingyue (via GitHub)" <gi...@apache.org>.
Ethan-Xingyue commented on PR #1148:
URL: https://github.com/apache/incubator-seata-go/pull/1148#issuecomment-5506811575
plz fix conflicts~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: preserve XA retry state and connection ownership [incubator-seata-go]
Posted by "DadaVinqi (via GitHub)" <gi...@apache.org>.
DadaVinqi commented on PR #1148:
URL: https://github.com/apache/incubator-seata-go/pull/1148#issuecomment-5748653520
Conflicts resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: preserve XA retry state and connection ownership [incubator-seata-go]
Posted by "DadaVinqi (via GitHub)" <gi...@apache.org>.
DadaVinqi commented on PR #1148:
URL: https://github.com/apache/incubator-seata-go/pull/1148#issuecomment-5791464433
I found that `IsAlreadyRollbacked` was used by both `BranchCommit` and `BranchRollback`, so adding `XAER_NOTA` directly to it would incorrectly make commit-side `XAER_NOTA` terminal.
I have updated the phase-two classifier to consider the requested operation:
- `XAER_NOTA` on rollback is treated as an idempotent success;
- `XAER_NOTA` on commit remains ambiguous and retryable.
I also removed the duplicate local rollback in the timeout path and added regression coverage for the timeout → local rollback → TC rollback → `XAER_NOTA` sequence described in #676.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: preserve XA retry state and connection ownership [incubator-seata-go]
Posted by "AlexStocks (via GitHub) via notifications" <no...@seata.apache.org>.
AlexStocks commented on code in PR #1148:
URL: https://github.com/apache/incubator-seata-go/pull/1148#discussion_r4578016772
##########
pkg/datasource/sql/conn_xa_test.go:
##########
@@ -296,12 +771,29 @@ func TestXAConn_ShouldBeHeld(t *testing.T) {
shouldBeHeld: tt.resourceHold,
}
conn := &XAConn{Conn: &Conn{res: resource}}
+ conn.configureConnectionHold(context.Background())
assert.Equal(t, tt.want, conn.ShouldBeHeld())
})
}
}
+func TestXAConn_KeepIfNecessaryRetainsUnknownDatabaseOwner(t *testing.T) {
+ resource := &DBResource{dbType: types.DBTypeUnknown}
+ xaID := XaIdBuild("xid", 1)
+ conn := &XAConn{
+ Conn: &Conn{res: resource},
+ xaBranchXid: xaID,
+ }
+
+ conn.configureConnectionHold(context.Background())
+ assert.True(t, conn.ShouldBeHeld(), "unknown XA resources must conservatively retain their owner")
+ conn.keepIfNecessary()
+
+ kept, ok := resource.Lookup(xaID.String())
+ assert.True(t, ok, "unknown XA resources must enter the keeper")
+ assert.Same(t, conn, kept)
+ assert.True(t, conn.isKept())
Review Comment:
在当前 head `51f8d8ce28c286d9f008729144b0fa115c6b34f6` 上该问题仍存在,P1 未消除。
**复现(零执行,仅解析)**:
```
$ gofmt -e -l pkg/datasource/sql/*.go
pkg/datasource/sql/conn_xa_test.go:802:43: expected ';', found error
```
**定位**:`TestXAConn_KeepIfNecessaryRetainsUnknownDatabaseOwner`(第 781 行开始)在第 796 行 `assert.True(t, conn.isKept())` 之后缺少函数闭合 `}`,第 797 行直接开始 `type closeTrackingDriverConn struct {`,因此函数体未闭合、类型声明出现在函数内部,解析在 802 行失败。
**影响**:`pkg/datasource/sql` 的测试包整体不可编译,同包内其余新增用例(`TestXAConn_Close_ClosesPhysicalConnWhenNotHeld` 等)同样无法执行;对应 `go test ./pkg/datasource/sql/...` 门禁必然失败,不是用例断言失败而是包级语法错误。
**修复方向**:在第 796 行后补一个 `}` 结束该测试函数,再声明 `closeTrackingDriverConn`;补完后建议本地跑一次 `gofmt -e -l pkg/datasource/sql/*.go` 与 `go vet ./pkg/datasource/sql/` 确认包级可编译。
同一 head 上另外两处非阻塞格式差异(`conn_xa.go`、`xa_resource_manager_test.go` 未通过 gofmt 格式检查)不影响编译,可与本修复一并处理。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: preserve XA retry state and connection ownership [incubator-seata-go]
Posted by "AlexStocks (via GitHub) via notifications" <no...@seata.apache.org>.
AlexStocks commented on code in PR #1148:
URL: https://github.com/apache/incubator-seata-go/pull/1148#discussion_r4521781488
##########
pkg/datasource/sql/conn_xa.go:
##########
@@ -175,9 +183,11 @@ func (c *XAConn) BeginTx(ctx context.Context, opts driver.TxOptions) (driver.Tx,
}
c.xaBranchXid = XaIdBuild(c.txCtx.XID, c.txCtx.BranchID)
+ c.configureConnectionHold(ctx)
Review Comment:
[P2] 每个 XA 分支 Begin 都多一次 `SELECT @@session.xa_detach_on_prepare` 往返
触发条件:MySQL >= 8.0.29(`checkDbVersion` 把 `probeXADetachOnPrepare` 置为 true)且使用 XA 模式的每个本地事务。
实际影响:`BeginTx` 无条件调用 `configureConnectionHold`,后者在 `probeXADetachOnPrepare` 为真时执行一次 `selectMySQLXADetachOnPrepare`。`xa_detach_on_prepare` 是 session 级变量,同一物理连接在一次会话内取值稳定,但这里每个分支重新查询一次,于是每个 XA 分支多出一次 RTT:n = XA 分支数,内网单次 RTT 约 0.1–1 ms(跨可用区更高),1000 次 Begin 即增加约 0.1–1 s 的串行等待,且随链路 RTT 线性放大。同函数中 `shouldBeHeld` 的其它分支都是内存操作,该次往返是唯一新增的同步 I/O。
证据:`BeginTx` 中的调用点与 `configureConnectionHold` 的 probe 实现;`checkDbVersion` 在 8.0.29+ 置位 `probeXADetachOnPrepare`。
修复方向:把 probe 结果缓存到连接级字段(首次 Begin 查询、连接 ResetSession/归还时失效),或直接复用 `DBResource` 已有的探测结果,避免每分支一次往返。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: preserve XA retry state and connection ownership [incubator-seata-go]
Posted by "DadaVinqi (via GitHub) via notifications" <no...@seata.apache.org>.
DadaVinqi commented on PR #1148:
URL: https://github.com/apache/incubator-seata-go/pull/1148#issuecomment-6785321594
Thanks for the detailed review. I addressed the reported XA lifecycle and concurrency issues:
- Reset `rollBacked` under `keeperMu` when a new XA branch starts and in `ResetSession`. Added regression coverage for rollback → pool reuse/`ResetSession` → new branch → rollback, asserting that both `XA END(TMFAIL)` and `XA ROLLBACK` are issued.
- Cache `@@session.xa_detach_on_prepare` per physical `XAConn` so repeated branches on the same session do not probe it repeatedly. The cache is invalidated by `ResetSession`.
- Preserve the conservative keeper fallback for `DBTypeUnknown`.
- Recheck the terminal branch status while holding `keeperMu` before executing phase two, preventing duplicate commit/rollback operations and opposite-direction races.
- Added regression coverage for concurrent same-direction and opposite-direction phase-two callbacks.
The implementation and regression coverage are ready for re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: preserve XA retry state and connection ownership [incubator-seata-go]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #1148:
URL: https://github.com/apache/incubator-seata-go/pull/1148#discussion_r3869367137
##########
pkg/datasource/sql/xa_resource_manager.go:
##########
@@ -91,15 +92,14 @@ func (xaManager *XAResourceManager) xaTwoPhaseTimeoutChecker() {
if !ok {
return true
}
- if source.IsShouldBeHeld() {
- return true
- }
-
source.GetKeeper().Range(func(key, value any) bool {
connectionXA, isConnectionXA := value.(*XAConn)
if !isConnectionXA {
return true
}
+ if connectionXA.ShouldBeHeld() {
+ return true
+ }
if time.Now().Sub(connectionXA.prepareTime) > xaManager.config.TwoPhaseHoldTime {
Review Comment:
xaTwoPhaseTimeoutChecker currently returns early when connectionXA.ShouldBeHeld() is true. Since keeper entries are only created for held branches, this prevents the timeout sweep from ever force-closing leaked/stuck phase-2 owner connections. Also, reading prepareTime without synchronization can race with phase-1 setting it (and if it’s still zero, the timeout computation is nonsensical). Consider snapshotting xaActive/prepareTime under keeperMu and only applying the timeout after the branch has actually been prepared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: preserve XA retry state and connection ownership [incubator-seata-go]
Posted by "DadaVinqi (via GitHub) via notifications" <no...@seata.apache.org>.
DadaVinqi commented on PR #1148:
URL: https://github.com/apache/incubator-seata-go/pull/1148#issuecomment-6687373556
Thanks for flagging this! I merged the latest `master`, resolved the changelog conflicts, and removed the unused import that caused the CI failures. The fix is in `07038ab`. GitHub now reports no merge conflicts, and the new CI runs are awaiting maintainer approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: preserve XA retry state and connection ownership [incubator-seata-go]
Posted by "Ethan-Xingyue (via GitHub)" <gi...@apache.org>.
Ethan-Xingyue commented on PR #1148:
URL: https://github.com/apache/incubator-seata-go/pull/1148#issuecomment-5748144724
plz fix conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: preserve XA retry state and connection ownership [incubator-seata-go]
Posted by "AlexStocks (via GitHub) via notifications" <no...@seata.apache.org>.
AlexStocks commented on code in PR #1148:
URL: https://github.com/apache/incubator-seata-go/pull/1148#discussion_r4534951697
##########
pkg/datasource/sql/conn_xa_test.go:
##########
@@ -296,12 +771,29 @@ func TestXAConn_ShouldBeHeld(t *testing.T) {
shouldBeHeld: tt.resourceHold,
}
conn := &XAConn{Conn: &Conn{res: resource}}
+ conn.configureConnectionHold(context.Background())
assert.Equal(t, tt.want, conn.ShouldBeHeld())
})
}
}
+func TestXAConn_KeepIfNecessaryRetainsUnknownDatabaseOwner(t *testing.T) {
+ resource := &DBResource{dbType: types.DBTypeUnknown}
+ xaID := XaIdBuild("xid", 1)
+ conn := &XAConn{
+ Conn: &Conn{res: resource},
+ xaBranchXid: xaID,
+ }
+
+ conn.configureConnectionHold(context.Background())
+ assert.True(t, conn.ShouldBeHeld(), "unknown XA resources must conservatively retain their owner")
+ conn.keepIfNecessary()
+
+ kept, ok := resource.Lookup(xaID.String())
+ assert.True(t, ok, "unknown XA resources must enter the keeper")
+ assert.Same(t, conn, kept)
+ assert.True(t, conn.isKept())
Review Comment:
[P1] 新增测试缺少函数闭合花括号,`pkg/datasource/sql` 的测试包无法编译
触发条件:对当前 head 直接编译 `pkg/datasource/sql` 测试包,不涉及任何用例执行。
实际影响:`TestXAConn_KeepIfNecessaryRetainsUnknownDatabaseOwner`(第 781 行开始)在 `assert.True(t, conn.isKept())`(第 796 行)之后没有 `}`,第 797 行的 `type closeTrackingDriverConn struct {...}` 与第 802 行的 `func (c *closeTrackingDriverConn) Close() error` 因此落进该函数体。方法声明不能出现在函数体内,解析阶段即失败,整个包的测试(含本 PR 新增的 7 个 XA 用例)都无法运行。
证据:对 head=51f8d8ce 的 `pkg/datasource/sql/conn_xa_test.go` 执行 gofmt 解析(Go 1.25.0,仅解析不执行):
`gofmt -e -l conn_xa_test.go` → `conn_xa_test.go:802:43: expected ';', found error`
同批解析本 PR 其余 9 个改动 `.go` 文件(conn_xa.go、db.go、types/const.go、xa/mysql_xa_connection.go、xa/xa_resource.go、xa_resource_manager.go 及对应测试)均无解析错误,问题仅此一处。旧 head 07038ab3 的同名文件无该错误,是本轮增量引入。
修复方向:在第 796 行后补一个 `}` 闭合该测试函数。建议同时把 `go vet ./...`(或 `go build ./...` + `go test -run XXX -count=1 ./...` 的编译阶段)前移到本地提交前,避免测试文件语法错误只由 CI 兜底。
##########
pkg/datasource/sql/conn_xa.go:
##########
@@ -558,79 +651,105 @@ func (c *XAConn) Commit(ctx context.Context) error {
now := time.Now()
- if c.end(ctx, xa.TMSuccess) != nil {
- return c.commitErrorHandle(ctx)
+ if err := c.end(ctx, xa.TMSuccess); err != nil {
+ return c.commitErrorHandle(ctx, err)
}
- if c.checkTimeout(ctx, now) != nil {
- return c.commitErrorHandle(ctx)
+ if err := c.checkTimeout(now); err != nil {
+ return c.commitErrorHandle(ctx, err)
}
- if c.xaResource.XAPrepare(ctx, c.xaBranchXid.String()) != nil {
- return c.commitErrorHandle(ctx)
+ if err := c.xaResource.XAPrepare(ctx, c.xaBranchXid.String()); err != nil {
+ return c.commitErrorHandle(ctx, err)
}
+ c.keeperMu.Lock()
c.prepareTime = time.Now()
+ c.preparedForPhaseTwo = true
// Phase-1 is done: this session no longer has an in-flight XA branch. Clear
- // only the session-active flag so a subsequent autoCommit statement on the
- // same (possibly pooled/reused) connection can open a fresh branch instead of
- // tripping the "xa branch is active" guard in BeginTx. The branch itself is
- // still prepared and, when held, retrievable for phase-2 via xaBranchXid, so
- // we must NOT call cleanXABranchContext here (that would reset prepareTime and
- // drop xaBranchXid). Phase-2 XaCommit/XaRollback do not depend on xaActive.
+ // only the session-active flag so a subsequent autoCommit statement on a
+ // connection that was not transferred to the keeper can open a fresh branch.
+ // Held and temporarily cached branches remain addressable for phase two.
c.xaActive = false
+ c.keeperMu.Unlock()
return nil
}
-func (c *XAConn) commitErrorHandle(ctx context.Context) error {
- var err error
- if err = c.XaRollback(ctx, c.xaBranchXid); err != nil {
- err = fmt.Errorf("failed to report XA branch commit-failure xid:%s, err:%w", c.txCtx.XID, err)
+func (c *XAConn) commitErrorHandle(ctx context.Context, cause error) error {
+ err := cause
+ if rollbackErr := c.XaRollback(ctx, c.xaBranchXid); rollbackErr != nil {
+ err = errors.Join(
+ cause,
+ fmt.Errorf("failed to rollback XA branch after commit failure xid:%s, err:%w", c.txCtx.XID, rollbackErr),
+ )
}
c.cleanXABranchContext()
return err
}
func (c *XAConn) ShouldBeHeld() bool {
- return c.res.IsShouldBeHeld() || c.res.GetDbType() == types.DBTypeUnknown
+ return c.shouldBeHeld || c.res.GetDbType() == types.DBTypeUnknown
+}
+
+func (c *XAConn) phaseTwoTimeoutSnapshot() (prepared bool, holdUntilPhaseTwo bool, preparedAt time.Time) {
+ c.keeperMu.Lock()
+ defer c.keeperMu.Unlock()
+ return c.preparedForPhaseTwo, c.shouldBeHeld, c.prepareTime
}
-func (c *XAConn) checkTimeout(ctx context.Context, now time.Time) error {
+// checkTimeout only reports expiration. Commit routes the error through
+// commitErrorHandle, which rolls the branch back once and preserves this cause.
+func (c *XAConn) checkTimeout(now time.Time) error {
if now.Sub(c.branchRegisterTime) > xaConnTimeout {
- c.XaRollback(ctx, c.xaBranchXid)
return fmt.Errorf("XA branch timeout error xid:%s", c.txCtx.XID)
}
return nil
}
func (c *XAConn) Close() error {
+ c.keeperMu.Lock()
+ defer c.keeperMu.Unlock()
+
c.rollBacked = false
- if c.isConnKept && c.ShouldBeHeld() {
- return nil
- }
- c.cleanXABranchContext()
- // Check if Conn is nil before calling Close
- if c.Conn == nil {
+ if c.isConnKept {
+ c.poolDiscarded = true
return nil
}
- return c.Conn.Close()
+ c.cleanXABranchContextLocked()
+ return c.closePhysicalLocked()
}
func (c *XAConn) CloseForce() error {
- if err := c.Conn.Close(); err != nil {
- return err
- }
+ c.keeperMu.Lock()
+ defer c.keeperMu.Unlock()
+
+ err := c.closePhysicalLocked()
c.rollBacked = false
- c.cleanXABranchContext()
- c.releaseIfNecessary()
- return nil
+ c.releaseIfNecessaryLocked()
+ c.cleanXABranchContextLocked()
+ return err
}
func (c *XAConn) XaCommit(ctx context.Context, xaXid XAXid) error {
+ return c.xaCommit(ctx, xaXid, nil)
+}
+
+func (c *XAConn) xaCommit(ctx context.Context, xaXid XAXid, beforeRelease func()) error {
+ c.keeperMu.Lock()
Review Comment:
[P2] `keeperMu` 覆盖整个 XA 二阶段网络调用,会让单 goroutine 的过期回收循环停摆
触发条件(可复现时序):
1. goroutine A 处理分支 X 的二阶段提交 → `xaCommit` 取得 `c.keeperMu`(第 740 行)→ 阻塞在 `c.xaResource.Commit`(第 746 行)的数据库响应上;
2. `xaTwoPhaseTimeoutChecker` 是单个 goroutine 的 ticker 循环,本轮 `closeTimedOutPhaseTwoConnections` 遍历到分支 X,调用 `connectionXA.CloseForce()`;
3. `CloseForce` 需要同一把 `keeperMu`(第 786 行),于是整个 ticker 循环停在这里。
实际影响:停摆期间,所有 DBResource 的 keeper 条目都不再比较 `TwoPhaseHoldTime`、也不再 `CloseForce`。持有连接的条目数按 `分支速率 × 停摆时长` 增长且无上界;停摆时长等于那次 `XA COMMIT` 的实际耗时(TCP 重传默认数分钟,若 RPC ctx 未设 deadline 则直到连接断开)。`xaRollback`(第 765-771 行)同样是锁内 I/O,`ResetSession`、`Close`、`isKept` 也在同一把锁上排队。
证据:`conn_xa.go:739-746`(持锁调用 `Commit`)、`:764-771`(持锁调用 `Rollback`)、`:786`(`CloseForce` 取同一锁)、`xa_resource_manager.go` 的 `xaTwoPhaseTimeoutChecker` 为单 goroutine `for { select { case <-ticker.C: ... } }`。本 PR 新增的 `TestXAConn_PhaseTwoAndTimeoutCloseHaveSinglePhysicalOwner` 用 blocking XA resource 断言"commit 未完成时 CloseForce 不返回",说明这个排队是当前实现的既有行为,不是推测。
修复方向:不要在锁内做 I/O。在锁内只做状态迁移(例如置 `phaseTwoInFlight`),把 `Commit`/`Rollback` 调用挪到锁外,完成后重新取锁收尾;`CloseForce` 遇到 in-flight 时跳过并交由调用方在完成后关闭。若必须保留串行化,至少给回收器对单个连接的等待设置上限,避免一个连接阻塞整个循环。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: preserve XA retry state and connection ownership [incubator-seata-go]
Posted by "XiaoFeiASK (via GitHub) via notifications" <no...@seata.apache.org>.
XiaoFeiASK commented on PR #1148:
URL: https://github.com/apache/incubator-seata-go/pull/1148#issuecomment-6686695774
plz fix CI and Conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org