You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Thomas Mueller (JIRA)" <ji...@apache.org> on 2018/07/12 13:23:00 UTC
[jira] [Commented] (OAK-7629) Lucene index: hide the settings COR
and COW
[ https://issues.apache.org/jira/browse/OAK-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541628#comment-16541628 ]
Thomas Mueller commented on OAK-7629:
-------------------------------------
Proposed patch to make them private:
{noformat}
Index: src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexProviderService.java
===================================================================
--- src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexProviderService.java (revision 1835714)
+++ src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexProviderService.java (working copy)
@@ -138,7 +138,8 @@
@Property(
boolValue = true,
label = "Enable CopyOnRead",
- description = "Enable copying of Lucene index to local file system to improve query performance"
+ description = "Enable copying of Lucene index to local file system to improve query performance",
+ propertyPrivate = true
)
private static final String PROP_COPY_ON_READ = "enableCopyOnReadSupport";
@@ -154,7 +155,8 @@
@Property(
boolValue = PROP_COPY_ON_WRITE_DEFAULT,
label = "Enable CopyOnWrite",
- description = "Enable copying of Lucene index to local file system to improve index writer performance"
+ description = "Enable copying of Lucene index to local file system to improve index writer performance",
+ propertyPrivate = true
)
{noformat}
[~catholicon] or [~chetanm] could you review this please? According to my test, the settings are then hidden in the UI.
> Lucene index: hide the settings COR and COW
> --------------------------------------------
>
> Key: OAK-7629
> URL: https://issues.apache.org/jira/browse/OAK-7629
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: lucene
> Reporter: Thomas Mueller
> Priority: Major
> Fix For: 1.10
>
>
> I have seen people disabling copy-on-read or copy-on-write hoping to improve performance or save space. We know about problems if those are disabled, for example it can result in many open file handles, OAK-7460.
> So best if we hide these features, so that people don't change them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)