[GitHub] [incubator-echarts] 100pah commented on a change in pull request #10602: #10595

[GitBox <gi...@apache.org>]

100pah commented on a change in pull request #10602: #10595
URL: https://github.com/apache/incubator-echarts/pull/10602#discussion_r292129614
 
 

 ##########
 File path: src/data/List.js
 ##########
 @@ -1176,7 +1176,7 @@ function getRawIndexWithoutIndices(idx) {
 }
 
 function getRawIndexWithIndices(idx) {
-    if (idx < this._count && idx >= 0) {
 
 Review comment:
   I think we should use `idx < this._count` here, otherwise it will get incorrect result.
   The #10595 is probably a bug of axisPointer itself.
   I am debugging it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org