You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2016/01/02 14:00:18 UTC
Re: Review Request 40379: MESOS-3930: Set resource type as
USAGE_SLACK for Oversubscription
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/
-----------------------------------------------------------
(Updated Jan. 2, 2016, 9 p.m.)
Review request for mesos, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Changes
-------
Update code diff
Bugs: MESOS-3930
https://issues.apache.org/jira/browse/MESOS-3930
Repository: mesos
Description
-------
In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps to update `RevocableInfo::type` for Oversubscription.
Diffs (updated)
-----
include/mesos/slave/resource_estimator.hpp 27612ca
src/slave/slave.cpp 9d80c96
Diff: https://reviews.apache.org/r/40379/diff/
Testing
-------
make (make check is on-going)
Thanks,
Klaus Ma
Re: Review Request 40379: MESOS-3930: Set resource type as
USAGE_SLACK for Oversubscription
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review112507
-----------------------------------------------------------
src/slave/slave.cpp (lines 4631 - 4632)
<https://reviews.apache.org/r/40379/#comment172967>
I think it should be:
// Exclude oversubscription for reservation.
oversubscribed -= oversubscribed.allocationSlack();
oversubscribed += oversubscribable.get();
Seems you lost the new reported oversubscribed resources here.
To be more clear, what about update 4627 as:
oversubscribed += executor->resources.revocable().allocationSlack();
- Guangya Liu
On Jan. 2, 2016, 1 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2016, 1 p.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3930
> https://issues.apache.org/jira/browse/MESOS-3930
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps to update `RevocableInfo::type` for Oversubscription.
>
>
> Diffs
> -----
>
> include/mesos/slave/resource_estimator.hpp 27612ca
> src/slave/slave.cpp 9d80c96
>
> Diff: https://reviews.apache.org/r/40379/diff/
>
>
> Testing
> -------
>
> make (make check is on-going)
>
>
> Thanks,
>
> Klaus Ma
>
>