[GitHub] [arrow-datafusion] thinkharderdev commented on a change in pull request #1929: Fix JIT configs for aarch64

[GitBox <gi...@apache.org>]

thinkharderdev commented on a change in pull request #1929:
URL: https://github.com/apache/arrow-datafusion/pull/1929#discussion_r820151234



##########
File path: datafusion-jit/src/jit.rs
##########
@@ -51,6 +52,28 @@ impl Default for JIT {
             module,
         }
     }
+
+    #[cfg(target_arch = "aarch64")]
+    fn default() -> Self {
+        let mut flag_builder = settings::builder();
+        // On at least AArch64, "colocated" calls use shorter-range relocations,
+        // which might not reach all definitions; we can't handle that here, so
+        // we require long-range relocation types.
+        flag_builder.set("use_colocated_libcalls", "false").unwrap();
+        flag_builder.set("is_pic", "false").unwrap();

Review comment:
       Good call




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org