[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6651: Spark 3.3 write to branch snapshot

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on code in PR #6651:
URL: https://github.com/apache/iceberg/pull/6651#discussion_r1103834258


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkUtil.java:
##########
@@ -295,4 +296,19 @@ public static List<Expression> partitionMapToExpression(
   public static String toColumnName(NamedReference ref) {
     return DOT.join(ref.fieldNames());
   }
+
+  /**
+   * fetch latest snapshot based on the branch tip

Review Comment:
   should add in javadoc about why we want to do thisi nstead of always use `table.snapshot(branch);`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org