You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by sc...@apache.org on 2014/03/20 22:03:20 UTC

svn commit: r1579735 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: schultz
Date: Thu Mar 20 21:03:19 2014
New Revision: 1579735

URL: http://svn.apache.org/r1579735
Log:
Votes

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1579735&r1=1579734&r2=1579735&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Mar 20 21:03:19 2014
@@ -34,11 +34,18 @@ PATCHES PROPOSED TO BACKPORT:
   entities.
   http://people.apache.org/~markt/patches/2014-03-17-globalXsltFile-tc6-v1.patch
   +1: markt
+  -1: schultz: The idea of the patch is fine: I'm actually +1.
+               I have some small nits:
+               1. DocumentBuilderFactory is not thread-safe, and shouldn't
+               be shared. 2. Two instances of swallowing IOException
+               when closing File streams. We should at least log a warning.
+               It looks like there is an opportinity to use StringBuilder
+               instead of StringBuffer, there, too, if you want.
   -1:
 
 * Fix possible overflow when parsing long values from a byte array.
   http://people.apache.org/~markt/patches/2014-03-18-ascii-tc6.patch
-  +1: markt, kkolinko
+  +1: markt, kkolinko, schultz
   -1:
 
 * Add Java 8 support to Jasper's default configuration
@@ -63,20 +70,20 @@ PATCHES PROPOSED TO BACKPORT:
 
 * Update tc-native to 1.1.29
   http://people.apache.org/~markt/patches/2014-03-19-tc-native-tc6-v1.patch
-  +1: markt, kkolinko
+  +1: markt, kkolinko, schultz
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56275
   Fix memory leak if a Filter throws an exception during its destroy() method
   http://people.apache.org/~markt/patches/2014-03-19-bug56275-tc6-v1.patch
-  +1: markt
+  +1: markt, schultz
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54475
   Add Java 8 support to SMAP generation for JSPs.
   Patch by Robbie Gibson.
   http://people.apache.org/~markt/patches/2014-03-20-smap-java8-tc6-v1.patch
-  +1: markt, kkolinko
+  +1: markt, kkolinko, schultz
   -1:
 
 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org