You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/07 07:44:37 UTC
[GitHub] [flink] xintongsong opened a new pull request #10785:
[FLINK-15375][core] Improve MemorySize to print / parse with better
readability.
xintongsong opened a new pull request #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785
## What is the purpose of the change
This PR improves readability and usability of `MemorySize`.
## Brief change log
- `MemorySize#toString` prints memory size with both accurate bytes and coarse value with proper unit.
- `MemorySize#parse` supports parsing string followed by coarse value, which is generated by `MemorySize#toString`.
- Add factory method for constructing `MemorySize` from mebibytes.
## Verifying this change
- Add cases in `MemorySizeTest`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10785:
[FLINK-15375][core] Improve MemorySize to print / parse with better
readability.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#issuecomment-571482425
<!--
Meta data
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143356049 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144898098 TriggerType:PUSH TriggerID:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d
Hash:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4424 TriggerType:PUSH TriggerID:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d
Hash:9ac1d96d3592069c274833f5b2ef03c02cda2316 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145031962 TriggerType:PUSH TriggerID:9ac1d96d3592069c274833f5b2ef03c02cda2316
Hash:9ac1d96d3592069c274833f5b2ef03c02cda2316 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4453 TriggerType:PUSH TriggerID:9ac1d96d3592069c274833f5b2ef03c02cda2316
Hash:53d6a43440ed40bfd2d64d387a5640cf57bae29d Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:53d6a43440ed40bfd2d64d387a5640cf57bae29d
-->
## CI report:
* bfb11ff827395ce52de3c19567ec5fb60334e4d5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143356049) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153)
* 65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144898098) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4424)
* 9ac1d96d3592069c274833f5b2ef03c02cda2316 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145031962) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4453)
* 53d6a43440ed40bfd2d64d387a5640cf57bae29d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10785:
[FLINK-15375][core] Improve MemorySize to print / parse with better
readability.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#issuecomment-571482425
<!--
Meta data
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143356049 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
-->
## CI report:
* bfb11ff827395ce52de3c19567ec5fb60334e4d5 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143356049) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10785:
[FLINK-15375][core] Improve MemorySize to print / parse with better
readability.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#issuecomment-571482425
<!--
Meta data
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143356049 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144898098 TriggerType:PUSH TriggerID:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d
Hash:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4424 TriggerType:PUSH TriggerID:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d
-->
## CI report:
* bfb11ff827395ce52de3c19567ec5fb60334e4d5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143356049) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153)
* 65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144898098) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4424)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on issue #10785: [FLINK-15375][core]
Improve MemorySize to print / parse with better readability.
Posted by GitBox <gi...@apache.org>.
xintongsong commented on issue #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#issuecomment-575856631
@tillrohrmann, thanks for the review. I've addressed your comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10785:
[FLINK-15375][core] Improve MemorySize to print / parse with better
readability.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#issuecomment-571482425
<!--
Meta data
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143356049 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d
-->
## CI report:
* bfb11ff827395ce52de3c19567ec5fb60334e4d5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143356049) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153)
* 65aaf3db7340f912c5fe9e54cb065c38b7c88c0d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10785: [FLINK-15375][core]
Improve MemorySize to print / parse with better readability.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#issuecomment-571482425
<!--
Meta data
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
-->
## CI report:
* bfb11ff827395ce52de3c19567ec5fb60334e4d5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10785:
[FLINK-15375][core] Improve MemorySize to print / parse with better
readability.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#issuecomment-571482425
<!--
Meta data
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143356049 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144898098 TriggerType:PUSH TriggerID:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d
Hash:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4424 TriggerType:PUSH TriggerID:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d
Hash:9ac1d96d3592069c274833f5b2ef03c02cda2316 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145031962 TriggerType:PUSH TriggerID:9ac1d96d3592069c274833f5b2ef03c02cda2316
Hash:9ac1d96d3592069c274833f5b2ef03c02cda2316 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4453 TriggerType:PUSH TriggerID:9ac1d96d3592069c274833f5b2ef03c02cda2316
-->
## CI report:
* bfb11ff827395ce52de3c19567ec5fb60334e4d5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143356049) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153)
* 65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144898098) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4424)
* 9ac1d96d3592069c274833f5b2ef03c02cda2316 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145031962) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4453)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #10785: [FLINK-15375][core]
Improve MemorySize to print / parse with better readability.
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#issuecomment-576670593
Thanks for addressing my comments @xintongsong. Merging this PR now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10785:
[FLINK-15375][core] Improve MemorySize to print / parse with better
readability.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#issuecomment-571482425
<!--
Meta data
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143356049 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144898098 TriggerType:PUSH TriggerID:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d
Hash:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4424 TriggerType:PUSH TriggerID:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d
Hash:9ac1d96d3592069c274833f5b2ef03c02cda2316 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145031962 TriggerType:PUSH TriggerID:9ac1d96d3592069c274833f5b2ef03c02cda2316
Hash:9ac1d96d3592069c274833f5b2ef03c02cda2316 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4453 TriggerType:PUSH TriggerID:9ac1d96d3592069c274833f5b2ef03c02cda2316
-->
## CI report:
* bfb11ff827395ce52de3c19567ec5fb60334e4d5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143356049) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153)
* 65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144898098) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4424)
* 9ac1d96d3592069c274833f5b2ef03c02cda2316 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145031962) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4453)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on issue #10785: [FLINK-15375][core]
Improve MemorySize to print / parse with better readability.
Posted by GitBox <gi...@apache.org>.
xintongsong commented on issue #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#issuecomment-571474313
cc @azagrebin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10785:
[FLINK-15375][core] Improve MemorySize to print / parse with better
readability.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#issuecomment-571482425
<!--
Meta data
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143356049 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144898098 TriggerType:PUSH TriggerID:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d
Hash:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4424 TriggerType:PUSH TriggerID:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d
Hash:9ac1d96d3592069c274833f5b2ef03c02cda2316 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145031962 TriggerType:PUSH TriggerID:9ac1d96d3592069c274833f5b2ef03c02cda2316
Hash:9ac1d96d3592069c274833f5b2ef03c02cda2316 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4453 TriggerType:PUSH TriggerID:9ac1d96d3592069c274833f5b2ef03c02cda2316
Hash:53d6a43440ed40bfd2d64d387a5640cf57bae29d Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145366453 TriggerType:PUSH TriggerID:53d6a43440ed40bfd2d64d387a5640cf57bae29d
Hash:53d6a43440ed40bfd2d64d387a5640cf57bae29d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4537 TriggerType:PUSH TriggerID:53d6a43440ed40bfd2d64d387a5640cf57bae29d
-->
## CI report:
* bfb11ff827395ce52de3c19567ec5fb60334e4d5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143356049) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153)
* 65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144898098) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4424)
* 9ac1d96d3592069c274833f5b2ef03c02cda2316 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145031962) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4453)
* 53d6a43440ed40bfd2d64d387a5640cf57bae29d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145366453) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4537)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10785:
[FLINK-15375][core] Improve MemorySize to print / parse with better
readability.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#issuecomment-571482425
<!--
Meta data
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143356049 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144898098 TriggerType:PUSH TriggerID:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d
Hash:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4424 TriggerType:PUSH TriggerID:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d
Hash:9ac1d96d3592069c274833f5b2ef03c02cda2316 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145031962 TriggerType:PUSH TriggerID:9ac1d96d3592069c274833f5b2ef03c02cda2316
Hash:9ac1d96d3592069c274833f5b2ef03c02cda2316 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4453 TriggerType:PUSH TriggerID:9ac1d96d3592069c274833f5b2ef03c02cda2316
-->
## CI report:
* bfb11ff827395ce52de3c19567ec5fb60334e4d5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143356049) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153)
* 65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144898098) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4424)
* 9ac1d96d3592069c274833f5b2ef03c02cda2316 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145031962) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4453)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10785:
[FLINK-15375][core] Improve MemorySize to print / parse with better
readability.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#issuecomment-571482425
<!--
Meta data
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143356049 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144898098 TriggerType:PUSH TriggerID:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d
Hash:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4424 TriggerType:PUSH TriggerID:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d
-->
## CI report:
* bfb11ff827395ce52de3c19567ec5fb60334e4d5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143356049) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153)
* 65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144898098) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4424)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10785:
[FLINK-15375][core] Improve MemorySize to print / parse with better
readability.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#issuecomment-571482425
<!--
Meta data
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143356049 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144898098 TriggerType:PUSH TriggerID:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d
Hash:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4424 TriggerType:PUSH TriggerID:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d
-->
## CI report:
* bfb11ff827395ce52de3c19567ec5fb60334e4d5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143356049) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153)
* 65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144898098) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4424)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann closed pull request #10785:
[FLINK-15375][core] Improve MemorySize to print / parse with better
readability.
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on issue #10785: [FLINK-15375][core]
Improve MemorySize to print / parse with better readability.
Posted by GitBox <gi...@apache.org>.
xintongsong commented on issue #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#issuecomment-575520947
@tillrohrmann The PR is ready for review. Could you take a look at your convenience?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10785:
[FLINK-15375][core] Improve MemorySize to print / parse with better
readability.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#issuecomment-571482425
<!--
Meta data
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143356049 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144898098 TriggerType:PUSH TriggerID:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d
Hash:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4424 TriggerType:PUSH TriggerID:65aaf3db7340f912c5fe9e54cb065c38b7c88c0d
Hash:9ac1d96d3592069c274833f5b2ef03c02cda2316 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:9ac1d96d3592069c274833f5b2ef03c02cda2316
-->
## CI report:
* bfb11ff827395ce52de3c19567ec5fb60334e4d5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143356049) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153)
* 65aaf3db7340f912c5fe9e54cb065c38b7c88c0d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144898098) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4424)
* 9ac1d96d3592069c274833f5b2ef03c02cda2316 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10785:
[FLINK-15375][core] Improve MemorySize to print / parse with better
readability.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#issuecomment-571482425
<!--
Meta data
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143356049 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
-->
## CI report:
* bfb11ff827395ce52de3c19567ec5fb60334e4d5 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143356049) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10785:
[FLINK-15375][core] Improve MemorySize to print / parse with better
readability.
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#discussion_r367991584
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/MemorySize.java
##########
@@ -158,6 +162,38 @@ private String formatToString() {
highestIntegerUnit.getUnits()[1]);
}
+ public String toHumanReadableString() {
+ if (humanReadableStr == null) {
+ humanReadableStr = formatToHumanReadableString();
+ }
+
+ return humanReadableStr;
+ }
+
+ private String formatToHumanReadableString() {
+ MemoryUnit highestUnit = IntStream.range(0, ORDERED_UNITS.size())
+ .sequential()
+ .filter(idx -> bytes > ORDERED_UNITS.get(idx).getMultiplier())
+ .boxed()
+ .max(Comparator.naturalOrder())
+ .map(idx -> ORDERED_UNITS.get(idx))
Review comment:
nit: could be replaced with lambda method reference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on a change in pull request #10785:
[FLINK-15375][core] Improve MemorySize to print / parse with better
readability.
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#discussion_r368198923
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/MemorySize.java
##########
@@ -158,6 +162,38 @@ private String formatToString() {
highestIntegerUnit.getUnits()[1]);
}
+ public String toHumanReadableString() {
+ if (humanReadableStr == null) {
+ humanReadableStr = formatToHumanReadableString();
+ }
+
+ return humanReadableStr;
+ }
+
+ private String formatToHumanReadableString() {
+ MemoryUnit highestUnit = IntStream.range(0, ORDERED_UNITS.size())
+ .sequential()
+ .filter(idx -> bytes > ORDERED_UNITS.get(idx).getMultiplier())
+ .boxed()
+ .max(Comparator.naturalOrder())
+ .map(idx -> ORDERED_UNITS.get(idx))
+ .orElse(BYTES);
+
+ if (highestUnit == BYTES) {
+ return String.format(
+ "%d %s",
+ bytes,
+ BYTES.getUnits()[1]);
+ } else {
+ double approximate = 1.0 * bytes / highestUnit.getMultiplier();
+ return String.format(
+ "%.3f%s (%d)",
Review comment:
I thought people could easily understand that the value in the parentheses are they exact bytes. But true, it would be better to explicitly add the unit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10785:
[FLINK-15375][core] Improve MemorySize to print / parse with better
readability.
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#discussion_r367995904
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/MemorySize.java
##########
@@ -158,6 +162,38 @@ private String formatToString() {
highestIntegerUnit.getUnits()[1]);
}
+ public String toHumanReadableString() {
+ if (humanReadableStr == null) {
+ humanReadableStr = formatToHumanReadableString();
+ }
+
+ return humanReadableStr;
+ }
+
+ private String formatToHumanReadableString() {
+ MemoryUnit highestUnit = IntStream.range(0, ORDERED_UNITS.size())
+ .sequential()
+ .filter(idx -> bytes > ORDERED_UNITS.get(idx).getMultiplier())
+ .boxed()
+ .max(Comparator.naturalOrder())
+ .map(idx -> ORDERED_UNITS.get(idx))
+ .orElse(BYTES);
+
+ if (highestUnit == BYTES) {
+ return String.format(
+ "%d %s",
+ bytes,
+ BYTES.getUnits()[1]);
+ } else {
+ double approximate = 1.0 * bytes / highestUnit.getMultiplier();
+ return String.format(
+ "%.3f%s (%d)",
Review comment:
Should we add `%.3f%s (%d bytes)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10785: [FLINK-15375][core]
Improve MemorySize to print / parse with better readability.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#issuecomment-571474821
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit bfb11ff827395ce52de3c19567ec5fb60334e4d5 (Tue Jan 07 07:46:39 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10785:
[FLINK-15375][core] Improve MemorySize to print / parse with better
readability.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10785: [FLINK-15375][core] Improve MemorySize to print / parse with better readability.
URL: https://github.com/apache/flink/pull/10785#issuecomment-571482425
<!--
Meta data
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
Hash:bfb11ff827395ce52de3c19567ec5fb60334e4d5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143356049 TriggerType:PUSH TriggerID:bfb11ff827395ce52de3c19567ec5fb60334e4d5
-->
## CI report:
* bfb11ff827395ce52de3c19567ec5fb60334e4d5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143356049) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4153)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services