You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/04 14:14:37 UTC

[GitHub] [flink] wangxlong opened a new pull request #11016: [FLINK-15677][TABLE-COMMON]Use physical field names for the default implementation of Tablesource#explainSource

wangxlong opened a new pull request #11016: [FLINK-15677][TABLE-COMMON]Use physical field names for the default implementation of Tablesource#explainSource
URL: https://github.com/apache/flink/pull/11016
 
 
   ## What is the purpose of the change
   The default implementation of Tablesource#explainSource uses getTableSchema.getFieldNames which is logical fields. So, this pr replace it with physical fields.
   
   ## Brief change log
   1. Tablesource#explainSource
      - If produced DataType is composite type, we extract physical schema from it.
      - If produced DataType is simple, we use the default field name 'f0'.
   2. Delete file TableSourceValidationTest in legacy planer, For
      - TableSourceValidationTest#testPushProjectTableSourceWithoutExplainSource would throw error when without explainSource, the logcial schema and physical schema is different.
     - TableSourceValidationTest#testPushFilterableTableSourceWithoutExplainSource would throw error no matter whether with explainSource or not. the logcial schema and physical schema is the same.
   3. Fix some test fail
   
   ## Verifying this change
   This change is already covered by existing tests, such as
   1. TableSourceTest#testProcTimeTableSourceOverWindow
   2. TableSourceITCase#testRowtimeLongTableSource
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11016: [FLINK-15677][TABLE-COMMON]Use physical field names for the default implementation of Tablesource#explainSource

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11016: [FLINK-15677][TABLE-COMMON]Use physical field names for the default implementation of Tablesource#explainSource
URL: https://github.com/apache/flink/pull/11016#issuecomment-581929780
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 21fd4c9abd35d33e6e14e0b637e1cf9b4185b338 (Tue Feb 04 14:17:11 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15677).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11016: [FLINK-15677][TABLE-COMMON]Use physical field names for the default implementation of Tablesource#explainSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11016: [FLINK-15677][TABLE-COMMON]Use physical field names for the default implementation of Tablesource#explainSource
URL: https://github.com/apache/flink/pull/11016#issuecomment-581946583
 
 
   <!--
   Meta data
   Hash:21fd4c9abd35d33e6e14e0b637e1cf9b4185b338 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147395260 TriggerType:PUSH TriggerID:21fd4c9abd35d33e6e14e0b637e1cf9b4185b338
   Hash:21fd4c9abd35d33e6e14e0b637e1cf9b4185b338 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4835 TriggerType:PUSH TriggerID:21fd4c9abd35d33e6e14e0b637e1cf9b4185b338
   -->
   ## CI report:
   
   * 21fd4c9abd35d33e6e14e0b637e1cf9b4185b338 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147395260) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4835) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11016: [FLINK-15677][TABLE-COMMON]Use physical field names for the default implementation of Tablesource#explainSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11016: [FLINK-15677][TABLE-COMMON]Use physical field names for the default implementation of Tablesource#explainSource
URL: https://github.com/apache/flink/pull/11016#issuecomment-581946583
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "21fd4c9abd35d33e6e14e0b637e1cf9b4185b338",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/147395260",
       "triggerID" : "21fd4c9abd35d33e6e14e0b637e1cf9b4185b338",
       "triggerType" : "PUSH"
     }, {
       "hash" : "21fd4c9abd35d33e6e14e0b637e1cf9b4185b338",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4835",
       "triggerID" : "21fd4c9abd35d33e6e14e0b637e1cf9b4185b338",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 21fd4c9abd35d33e6e14e0b637e1cf9b4185b338 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147395260) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4835) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11016: [FLINK-15677][TABLE-COMMON]Use physical field names for the default implementation of Tablesource#explainSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11016: [FLINK-15677][TABLE-COMMON]Use physical field names for the default implementation of Tablesource#explainSource
URL: https://github.com/apache/flink/pull/11016#issuecomment-581946583
 
 
   <!--
   Meta data
   Hash:21fd4c9abd35d33e6e14e0b637e1cf9b4185b338 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147395260 TriggerType:PUSH TriggerID:21fd4c9abd35d33e6e14e0b637e1cf9b4185b338
   Hash:21fd4c9abd35d33e6e14e0b637e1cf9b4185b338 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4835 TriggerType:PUSH TriggerID:21fd4c9abd35d33e6e14e0b637e1cf9b4185b338
   -->
   ## CI report:
   
   * 21fd4c9abd35d33e6e14e0b637e1cf9b4185b338 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147395260) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4835) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11016: [FLINK-15677][TABLE-COMMON]Use physical field names for the default implementation of Tablesource#explainSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11016: [FLINK-15677][TABLE-COMMON]Use physical field names for the default implementation of Tablesource#explainSource
URL: https://github.com/apache/flink/pull/11016#issuecomment-581946583
 
 
   <!--
   Meta data
   Hash:21fd4c9abd35d33e6e14e0b637e1cf9b4185b338 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147395260 TriggerType:PUSH TriggerID:21fd4c9abd35d33e6e14e0b637e1cf9b4185b338
   Hash:21fd4c9abd35d33e6e14e0b637e1cf9b4185b338 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4835 TriggerType:PUSH TriggerID:21fd4c9abd35d33e6e14e0b637e1cf9b4185b338
   -->
   ## CI report:
   
   * 21fd4c9abd35d33e6e14e0b637e1cf9b4185b338 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147395260) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4835) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11016: [FLINK-15677][TABLE-COMMON]Use physical field names for the default implementation of Tablesource#explainSource

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11016: [FLINK-15677][TABLE-COMMON]Use physical field names for the default implementation of Tablesource#explainSource
URL: https://github.com/apache/flink/pull/11016#issuecomment-581946583
 
 
   <!--
   Meta data
   Hash:21fd4c9abd35d33e6e14e0b637e1cf9b4185b338 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:21fd4c9abd35d33e6e14e0b637e1cf9b4185b338
   -->
   ## CI report:
   
   * 21fd4c9abd35d33e6e14e0b637e1cf9b4185b338 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services