You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/03 05:25:48 UTC
[GitHub] [spark] sarutak opened a new pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
sarutak opened a new pull request #28585:
URL: https://github.com/apache/spark/pull/28585
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR upgrades HtmlUnit.
Selenium and Jetty also upgraded because of dependency.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Recently, a security issue which affects HtmlUnit is reported.
https://nvd.nist.gov/vuln/detail/CVE-2020-5529
According to the report, arbitrary code can be run by malicious users.
HtmlUnit is used for test so the impact might not be large but it's better to upgrade it just in case.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Existing testcases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637958862
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637960955
Thanks @dongjoon-hyun , @HyukjinKwon .
I don't know why sbt passes the tests but I'll investigate the reason anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638014260
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638660123
**[Test build #123522 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123522/testReport)** for PR 28585 at commit [`955a147`](https://github.com/apache/spark/commit/955a14714daced032fa23f54997c15745e11214f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638660888
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637962309
**[Test build #123462 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123462/testReport)** for PR 28585 at commit [`d950b42`](https://github.com/apache/spark/commit/d950b421fa807ddb32b84c5c081f244a6e53bda1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632441264
**[Test build #122950 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122950/testReport)** for PR 28585 at commit [`f53735e`](https://github.com/apache/spark/commit/f53735e2e52a8cf3d70f162c3317c10383ae1aff).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638432813
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632905794
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632388650
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637960955
Thanks @dongjoon-hyun , @HyukjinKwon .
I don't know why sbt passes the tests but I'll investigate it the reason anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638660888
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-631248730
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122866/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637953772
Hi, All.
This seems to break all Maven tests. Could you take a look at them? The followings are the first failure after merging this PR.
- https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-maven-hadoop-2.7-hive-2.3-jdk-11/531/
- https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-maven-hadoop-3.2-hive-2.3/541/
- https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-maven-hadoop-3.2-hive-2.3-jdk-11/522/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-636910538
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-636909842
**[Test build #123380 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123380/testReport)** for PR 28585 at commit [`d950b42`](https://github.com/apache/spark/commit/d950b421fa807ddb32b84c5c081f244a6e53bda1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638285856
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-631248727
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #28585:
URL: https://github.com/apache/spark/pull/28585
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-642980128
Trying again - merged to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-640153448
The errors were reproduced in PR builder and they are fixed by excluding the old `bytebuddy` so I believe it's safe to merge.
What do you think, @dongjoon-hyun, @HyukjinKwon ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637011234
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638647688
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123518/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637960955
Thanks @dongjoon-hyun , @HyukjinKwon .
I don't know why sbt pass the tests but I'll investigate it the reason anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638595741
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638647674
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632275960
merging to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632390619
**[Test build #122950 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122950/testReport)** for PR 28585 at commit [`f53735e`](https://github.com/apache/spark/commit/f53735e2e52a8cf3d70f162c3317c10383ae1aff).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637009768
**[Test build #123380 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123380/testReport)** for PR 28585 at commit [`d950b42`](https://github.com/apache/spark/commit/d950b421fa807ddb32b84c5c081f244a6e53bda1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638431462
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #28585:
URL: https://github.com/apache/spark/pull/28585#discussion_r428578312
##########
File path: core/src/test/scala/org/apache/spark/ui/UISeleniumSuite.scala
##########
@@ -784,6 +784,7 @@ class UISeleniumSuite extends SparkFunSuite with WebBrowser with Matchers with B
eventually(timeout(10.seconds), interval(50.milliseconds)) {
goToUi(sc, "/jobs")
+
Review comment:
This extra empty line is wrong change but after #28578 is merged, this testcase will be moved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-631503589
Looks OK pending tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-631248727
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-639096552
By excluding old version of `bytebuddy` , Maven tests seem to pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638660123
**[Test build #123522 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123522/testReport)** for PR 28585 at commit [`955a147`](https://github.com/apache/spark/commit/955a14714daced032fa23f54997c15745e11214f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637984501
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638647578
**[Test build #123518 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123518/testReport)** for PR 28585 at commit [`955a147`](https://github.com/apache/spark/commit/955a14714daced032fa23f54997c15745e11214f).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632905440
**[Test build #123015 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123015/testReport)** for PR 28585 at commit [`d950b42`](https://github.com/apache/spark/commit/d950b421fa807ddb32b84c5c081f244a6e53bda1).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638014904
@dongjoon-hyun @HyukjinKwon The reason of the failure seems that `bytebuddy` which upgraded-selenium depends on is much older than `mockito` depends on.
I've excluded the older one.
Let's wait the result of CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637962754
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632441755
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632390619
**[Test build #122950 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122950/testReport)** for PR 28585 at commit [`f53735e`](https://github.com/apache/spark/commit/f53735e2e52a8cf3d70f162c3317c10383ae1aff).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632843140
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #28585:
URL: https://github.com/apache/spark/pull/28585
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637958875
+1 for that. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-631255845
Ah, I remember that some tests will fail because the latest HtmlUnit can't properly interpret JavaScript code used in those tests.
So PR should follow #28578 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-640153448
The errors were reproduced in PR builder and they are fixed by excluding the old `bytebuddy` so I believe it's safe to merge.
What do you think, @dongjoon-hyun ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638432151
**[Test build #123501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123501/testReport)** for PR 28585 at commit [`955a147`](https://github.com/apache/spark/commit/955a14714daced032fa23f54997c15745e11214f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-631205985
**[Test build #122866 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122866/testReport)** for PR 28585 at commit [`f53735e`](https://github.com/apache/spark/commit/f53735e2e52a8cf3d70f162c3317c10383ae1aff).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638594427
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-631205985
**[Test build #122866 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122866/testReport)** for PR 28585 at commit [`f53735e`](https://github.com/apache/spark/commit/f53735e2e52a8cf3d70f162c3317c10383ae1aff).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637011234
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632842700
**[Test build #123015 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123015/testReport)** for PR 28585 at commit [`d950b42`](https://github.com/apache/spark/commit/d950b421fa807ddb32b84c5c081f244a6e53bda1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-631248382
**[Test build #122866 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122866/testReport)** for PR 28585 at commit [`f53735e`](https://github.com/apache/spark/commit/f53735e2e52a8cf3d70f162c3317c10383ae1aff).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-631206283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-640067780
Heh, do we think it's safe to merge again?
An exclusion is probably fine, but now it depends on something it needs only transitively. We could also manage the version explicitly. But, this maybe fine now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638595499
**[Test build #123518 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123518/testReport)** for PR 28585 at commit [`955a147`](https://github.com/apache/spark/commit/955a14714daced032fa23f54997c15745e11214f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637953772
Hi, All.
This seems to break all Maven test. Could you take a look at them? The followings are the first failure after merging this PR.
- https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-maven-hadoop-2.7-hive-2.3-jdk-11/531/
- https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-maven-hadoop-3.2-hive-2.3/541/
- https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-maven-hadoop-3.2-hive-2.3-jdk-11/522/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #28585:
URL: https://github.com/apache/spark/pull/28585
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638595741
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-636908869
Jenkins retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632905794
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638877000
**[Test build #123522 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123522/testReport)** for PR 28585 at commit [`955a147`](https://github.com/apache/spark/commit/955a14714daced032fa23f54997c15745e11214f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-633005360
According to the last failure, I noticed that real headless browser support is needed for HistoryServer tests too.
I've open a PR for that.
#28622
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638285856
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-697711108
Shoot. If this is non-essential, I think we can just revert it.
Or .. just lose this test? let me comment on the other PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632388650
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #28585:
URL: https://github.com/apache/spark/pull/28585#discussion_r428578312
##########
File path: core/src/test/scala/org/apache/spark/ui/UISeleniumSuite.scala
##########
@@ -784,6 +784,7 @@ class UISeleniumSuite extends SparkFunSuite with WebBrowser with Matchers with B
eventually(timeout(10.seconds), interval(50.milliseconds)) {
goToUi(sc, "/jobs")
+
Review comment:
I'll remove this extra empty line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #28585:
URL: https://github.com/apache/spark/pull/28585#discussion_r427716093
##########
File path: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala
##########
@@ -500,7 +501,11 @@ private[spark] case class ServerInfo(
threadPool match {
case pool: QueuedThreadPool =>
// Workaround for SPARK-30385 to avoid Jetty's acceptor thread shrink.
- pool.setIdleTimeout(0)
+ // As of Jetty 9.4.21, the implementation of
+ // QueuedThreadPoolExecutor#setIdleTimeout is changed and IllegalStateException
+ // will be thrown if we try to set idle timeout after the server has started.
+ // But this workaround works for Jetty 9.4.28 by ignoring the exception.
+ Try(pool.setIdleTimeout(0))
Review comment:
I noticed that as of Jetty 9.4.21, the implementation of `QueuedThreadPool`.
When `QueuedThreadPool#setIdleTimeout` is called, `QueuedThreadPool#_idleTimeout` is set to the new timeout as well as [`ReservedThreadExecutor#_idleTimeout`](https://github.com/eclipse/jetty.project/blob/jetty-9.4.28.v20200408/jetty-util/src/main/java/org/eclipse/jetty/util/thread/QueuedThreadPool.java#L312).
If `ReservedThreadExecutor#_idleTImeout` is tried to be set after Jetty has started, [`IllegalStateException` will be thrown](https://github.com/eclipse/jetty.project/blob/jetty-9.4.28.v20200408/jetty-util/src/main/java/org/eclipse/jetty/util/thread/ReservedThreadExecutor.java#L149).
But `QueuedThreadPool#_idleTimeout` will be set so this workaround will still work by ignoring the exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-631996492
cc @gengliangwang too FYI. seems okay to me too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638647674
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637962309
**[Test build #123462 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123462/testReport)** for PR 28585 at commit [`d950b42`](https://github.com/apache/spark/commit/d950b421fa807ddb32b84c5c081f244a6e53bda1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637962754
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637953772
Hi, All.
This seems to break all Maven test. Could you take a look at them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632843140
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638285869
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123469/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638595499
**[Test build #123518 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123518/testReport)** for PR 28585 at commit [`955a147`](https://github.com/apache/spark/commit/955a14714daced032fa23f54997c15745e11214f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632386519
@gengliangwang This PR doesn't pass test.
As I mentioned [here](https://github.com/apache/spark/pull/28585#issuecomment-631255845), #28578 should be merged first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-697700651
According to @sarutak , this broke `org.apache.spark.deploy.history.ChromeUIHistoryServerSuite` due to Guava dependency.
- https://github.com/apache/spark/pull/29827#discussion_r492654755
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637958205
Let's revert for now since it broke the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632842700
**[Test build #123015 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123015/testReport)** for PR 28585 at commit [`d950b42`](https://github.com/apache/spark/commit/d950b421fa807ddb32b84c5c081f244a6e53bda1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638014260
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637984501
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638878302
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638432813
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638594386
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638014904
@dongjoon-hyun @HyukjinKwon The reason of the failure seems that `bytebuddy` which upgraded-selenium depends on is much older than `mockito` depends on.
Let's wait the result of CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-697728071
Thanks, @srowen ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638878302
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632905801
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123015/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638594386
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-636909842
**[Test build #123380 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123380/testReport)** for PR 28585 at commit [`d950b42`](https://github.com/apache/spark/commit/d950b421fa807ddb32b84c5c081f244a6e53bda1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632441755
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-636910538
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-642729656
I'll merge today if there are no objections
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637542917
Merged to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632441762
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122950/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638015764
Sounds reasonable. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-638657246
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632387056
@sarutak sorry about that, let me do the revert
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-632689314
I merged https://github.com/apache/spark/pull/28578 ; this may need a rebase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637984475
**[Test build #123462 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123462/testReport)** for PR 28585 at commit [`d950b42`](https://github.com/apache/spark/commit/d950b421fa807ddb32b84c5c081f244a6e53bda1).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-631206283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28585: [SPARK-31765][WEBUI] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637961404
Thanks, @sarutak .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-637984508
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123462/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org