[GitHub] [incubator-doris] imay commented on a change in pull request #2969: Improve implementation of Status

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #2969: Improve implementation of Status
URL: https://github.com/apache/incubator-doris/pull/2969#discussion_r382639919
 
 

 ##########
 File path: be/src/common/status.cpp
 ##########
 @@ -50,18 +51,20 @@ Status::Status(const PStatus& s) : _state(nullptr) {
     TStatusCode::type code = (TStatusCode::type)s.status_code();
     if (code != TStatusCode::OK) {
         if (s.error_msgs_size() == 0) {
-            _state = assemble_state(code, Slice(), 1, Slice());
+            _state = assemble_state(code, Slice(), -1, Slice());
 
 Review comment:
   keep 1 as default code? Because minus number is not good for serialization.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org