You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "tonytanger (via GitHub)" <gi...@apache.org> on 2023/02/14 21:26:35 UTC

[GitHub] [beam] tonytanger opened a new pull request, #25474: Not including support for end time in Bigtable Change Stream connector

tonytanger opened a new pull request, #25474:
URL: https://github.com/apache/beam/pull/25474

   Not including support for end time in Bigtable Change Stream connector
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] pabloem commented on pull request #25474: Not including support for end time in Bigtable Change Stream connector

Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem commented on PR #25474:
URL: https://github.com/apache/beam/pull/25474#issuecomment-1431671279

   it's a little hard to find, but precommit is failing on `pullLicenses` task, which was broken on master when the branch was started:
   
   ![image](https://user-images.githubusercontent.com/1301740/219096200-689795c9-e39c-4623-af2c-6c4b5b56025f.png)
   
   Nothing for you to worry about. If you want, you could rebase with master /merge master into your branch to avoid that issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] tonytanger commented on pull request #25474: Not including support for end time in Bigtable Change Stream connector

Posted by "tonytanger (via GitHub)" <gi...@apache.org>.
tonytanger commented on PR #25474:
URL: https://github.com/apache/beam/pull/25474#issuecomment-1431646888

   Java PreCommit shows no issues. Not sure why it says the build failed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] pabloem merged pull request #25474: Not including support for end time in Bigtable Change Stream connector

Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem merged PR #25474:
URL: https://github.com/apache/beam/pull/25474


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] pabloem commented on pull request #25474: Not including support for end time in Bigtable Change Stream connector

Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem commented on PR #25474:
URL: https://github.com/apache/beam/pull/25474#issuecomment-1430403144

   lgtm I'll merge once tests are passing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] tonytanger commented on pull request #25474: Not including support for end time in Bigtable Change Stream connector

Posted by "tonytanger (via GitHub)" <gi...@apache.org>.
tonytanger commented on PR #25474:
URL: https://github.com/apache/beam/pull/25474#issuecomment-1430401662

   R: @pabloem 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] pabloem commented on pull request #25474: Not including support for end time in Bigtable Change Stream connector

Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem commented on PR #25474:
URL: https://github.com/apache/beam/pull/25474#issuecomment-1430744900

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] tonytanger commented on pull request #25474: Not including support for end time in Bigtable Change Stream connector

Posted by "tonytanger (via GitHub)" <gi...@apache.org>.
tonytanger commented on PR #25474:
URL: https://github.com/apache/beam/pull/25474#issuecomment-1431622510

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] pabloem commented on pull request #25474: Not including support for end time in Bigtable Change Stream connector

Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem commented on PR #25474:
URL: https://github.com/apache/beam/pull/25474#issuecomment-1430431652

   lgtm I'll merge once tests are passing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] pabloem commented on pull request #25474: Not including support for end time in Bigtable Change Stream connector

Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem commented on PR #25474:
URL: https://github.com/apache/beam/pull/25474#issuecomment-1431671470

   mmerging for now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org