You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/22 20:50:31 UTC

[GitHub] [arrow] zagto commented on a change in pull request #12678: ARROW-15984: [C++] Change RecordBatchReader API to use Result<>

zagto commented on a change in pull request #12678:
URL: https://github.com/apache/arrow/pull/12678#discussion_r832614423



##########
File path: cpp/src/arrow/testing/gtest_util.h
##########
@@ -120,6 +120,11 @@
   ASSIGN_OR_HANDLE_ERROR_IMPL(           \
       ASSERT_OK, ARROW_ASSIGN_OR_RAISE_NAME(_error_or_value, __COUNTER__), lhs, rexpr);
 
+#define ASSERT_OK_NO_THROW_AND_ASSIGN(lhs, rexpr)                                       \
+  ASSIGN_OR_HANDLE_ERROR_IMPL(ASSERT_OK_NO_THROW,                                       \

Review comment:
       I'm not sure. I was changing `arrow_reader_writer_test.cc`, and in many but not all places `ASSERT_OK_NO_THROW` is used there, while in others `ASSERT_OK`, so I assumed there must be a point




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org