You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by zhuoliu <gi...@git.apache.org> on 2015/09/22 23:39:56 UTC
[GitHub] storm pull request: [STORM-1058] create CLI kill_workers to kill w...
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/756
[STORM-1058] create CLI kill_workers to kill workers on a supervisor node
Kill all the workers running on this supervisor.
Currently there is no direct way to kill all the running workers on a supervisor node from a command line. In addition, if the supervisor dies, the workers will not suicide automatically.
Also, this CLI can be called by future node health-check script to cleanly shutdown a supervisor on an problematic node.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhuoliu/storm 1058
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/756.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #756
----
commit 034fa1a30655dfda92e550acbf6af34b4508b8a5
Author: zhuol <zh...@yahoo-inc.com>
Date: 2015-09-22T15:44:43Z
Storm-1058 Add kill_workers CLI
commit eb7259c29b8ab6a56712c23f1036a1b4ebdb742e
Author: zhuol <zh...@yahoo-inc.com>
Date: 2015-09-22T15:45:09Z
kill_worker class
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1058] create CLI kill_workers to kill w...
Posted by jerrypeng <gi...@git.apache.org>.
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/756#issuecomment-144161813
other than my nit comment, looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1058] create CLI kill_workers to kill w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/756
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1058] create CLI kill_workers to kill w...
Posted by redsanket <gi...@git.apache.org>.
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/756#issuecomment-143771262
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1058] create CLI kill_workers to kill w...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/756#issuecomment-144522660
+1 looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1058] create CLI kill_workers to kill w...
Posted by jerrypeng <gi...@git.apache.org>.
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/756#discussion_r40716052
--- Diff: bin/storm.py ---
@@ -348,6 +348,19 @@ def get_errors(*args):
jvmtype="-client",
extrajars=[USER_CONF_DIR, os.path.join(STORM_DIR, "bin")])
+def kill_workers(*args):
+ """Syntax: [storm kill_workers]
+
+ Kill the workers running on this supervisor. This command should be run
+ on a supervisor node. If the cluster is running in secure node, then user needs
--- End diff --
nit: "secure mode" not "node"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---