You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/13 11:10:37 UTC

[GitHub] [shardingsphere] kimmking commented on a change in pull request #6338: Refactor registry center instance

kimmking commented on a change in pull request #6338:
URL: https://github.com/apache/shardingsphere/pull/6338#discussion_r453574133



##########
File path: shardingsphere-control-panel/shardingsphere-orchestration/shardingsphere-orchestration-core/shardingsphere-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/instance/OrchestrationInstance.java
##########
@@ -32,7 +35,9 @@
     private String instanceId;
 
     private OrchestrationInstance() {
-
+        String tag = Strings.isNullOrEmpty(System.getProperty("port"))

Review comment:
       use a special key and make it constants




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org